2 Commits

Include renames

Author	SHA1	Message	Date
glm-5.3-flash	2586c3b217	feat(review 006 Unit 1): channel-open establishment phase + typed client error (E-01, N-1) ... Implements ADR-049 Unit 1 — the open-op wrapper gains an awaited, bounded establishment phase, and the client stops erasing the error. - OpenEstablisher hook + Establishment/EstablishmentError types: register_openable_with_establisher awaits the establisher bounded (earlier of dispatch deadline and per-registration timeout, else ESTABLISHMENT_TIMEOUT = 10s) after allocation, before the reply and before the pump handler is spawned (ADR-049 §1/§2). Implementation note: the establisher takes (input, auth) only — the channel's yield-once BiStream belongs exclusively to the pump handler (amendment recorded in ADR-049). - Establishment failure: teardown_channel + opener-ledger take + policy.on_close un-increment (allocation and teardown balance; the ledger take is the atomic gate, ADR-047 §7), reply channel:open_failed with details {reason, message} — reason ∈ dial_failed / unknown_resource / resource_shortage / handler_error / timeout (ADR-049 §3). SSH contract consumer-visible: a failed open never returns a channel_id. - register_openable unchanged (no establisher = always-OK; existing registrations compile and behave identically — compat gate test). - ChannelClient::open_channel returns ChannelOpenError (breaking at 0.5.0): CallFailed { error: CallError } carries the wire error verbatim (establishment_reason() branches on details.reason); MissingChannelId / AdoptFailed cover the local-only shapes (ADR-049 §4, review 006 N-1). - Tests cover all four verification gates from the review: e2e establisher failure through a real channels connection (typed reason + no-channel + ledger un-increment), bounded timeout, no-establisher compat, establisher-success pump round-trip; plus reason-vocabulary mapping and bound arithmetic. - Bump to 0.5.0 (open_channel error-type change is semver-relevant). Verification: cargo test (608 passed), clippy --all-targets -D warnings, fmt --check, doc --no-deps, wasm32 check — all clean.	2026-09-06 19:00:04 +00:00
glm-5.3-flash	48ceeba55c	docs: ADR-049 channel-open establishment phase; verify review 006 ... Verify review 006's findings against source at 88e3f5e (E-01..E-04 all confirmed; E-02 cost corrected — OperationSpec has no description field, four touchpoints) and file three additional findings from the same sweep (N-1 client error-type gap, N-2 write-only early-arrival counter, N-3 pump-panic posture). ADR-049 resolves E-01 + N-1: split-hook OpenEstablisher awaited bounded by the open-op wrapper (restoring ADR-047 §3's "channel plan" shape), teardown + typed channel:open_failed reply on establishment failure, ChannelClient::open_channel typed error. Review 006 gains the post-verification remediation plan and verdict appendix. Verification: cargo test (597 passed), cargo doc --no-deps clean.	2026-09-06 10:57:20 +00:00