2 Commits

Include renames

Author	SHA1	Message	Date
glm-5.3-flash	f84d214173	feat: per-session fork registry, connect-side serving loop, op/register (review 004 Units 1-3) ... Remediates all six findings of review 004 (per-connection dispatch resolution and client-side op serving). All claims re-verified in source before remediation; F-02's member list gains ScopedPeerEnv (also Clone — fork surface simpler than estimated). - OperationRegistry: interior mutability (parking_lot RwLock on both maps); register takes &self; registration/list_operations return owned clones; fork() deep-copies registrations + cached publish-schema validators (F-02/F-03); OperationRegistryBuilder::from_registry. - install_bootstrap_discovery: services/list, services/list-peers, services/schema registered closed over the fork itself, so per-session openables are discoverable and services/schema answers from the fork (F-06). - Dispatcher::serve_single_stream: full-duplex single-stream loop — call.requested dispatches inbound; responded/completed/error resolve outbound pendings; aborted tries both tables (in-flight sink aborts + pending cascade); published routes inbound sinks (F-04). - ChannelClient::from_connection_with_serving(connection, Option<ServingConfig>): opt-in serving; from_connection keeps the pure-consumer default. - registry::op_register: OpRegisterRequest wire DTO (spec in services/schema JSON + replace flag), op_register_spec, op_register_handler (rebuild -> forwarding stub -> register_imported, forced Internal/FromCall), announce_op; CallError::already_exists; spec_to_json_pub; from_call's rebuild_spec_for + forwarding-handler constructors crate-shared (F-05). - ADR-047 §4 amendment #2: per-session fork is the dispatch-registry mechanism; overlay stays nested-invocation/peer-announced landing zone (F-01/F-02). - ADR-022 amendment 2026-09-03: bootstrap-op set (services/list, services/schema, op/register), opt-in connect-side serving, op/register wire shape (F-04/F-05). - alkhttp ADR-048 reconciliation note + OQ-05 re-pointed at the alkcall ADRs (Unit 1b). - Review 004 status -> remediated; remediation log with gates. Verification: - cargo test: 581 passed, 0 failed (565 baseline + 16 new) - cargo test --all-features: 598 passed, 0 failed - cargo clippy --all-targets -- -D warnings: clean - cargo clippy --all-features --all-targets -- -D warnings: clean - cargo clippy --target wasm32-unknown-unknown -- -D warnings: clean - cargo fmt --check: clean - cargo doc --no-deps: clean Gates: fork_registry_open_op_resolves_and_is_discoverable (open op via fork + services/list shows openable + services/schema validates), serving_loop_hub_to_consumer_call_resolves (hub->consumer call through consumer's serving loop, consumer->hub still resolves), op_register_announce_then_hub_call_routes_back_to_consumer (announce -> overlay -> hub call -> forwarding stub -> consumer serves).	2026-09-03 17:32:45 +00:00
glm-5.3-flash	c0dbf82518	docs(review 004): per-connection dispatch resolution + client-side op serving ... Focused design-mismatch review found via alkhttp's WS data-channel drill-down (alkhttp review 003 WS-24/WS-25). The channel machinery is done and proven; the gaps are the dispatch-resolution mechanism and the connect-side serving half — both upstream of any transport. Findings: - F-01 [major]: top-level dispatch consults only the dispatcher's base registry — ops registered per the ADR-047 §4 amendment's overlay mechanism resolve NOT_FOUND on the wire; the only proven shape (per-session registry as the dispatcher's base) differs from the ADR's wording - F-02 [major]: no Clone/fork surface on OperationRegistry or HandlerRegistration — every inner payload type IS Clone-able (verified type-by-type, incl. jsonschema::Validator and Capabilities), so the fork is a small addition - F-03 [minor]: fork must carry handlers + validators, not just specs - F-04 [major]: connect-side channel-0 read pump resolves responses only; inbound call.requested frames are silently dropped — no serving half on the single-stream shape (ADR-022/AGENTS §8 bidirectionality unreachable from the connect side) - F-05 [major]: no wire mechanism announces client-side ops; the six call.* kinds are closed. Resolution candidate: bootstrap op (op/register) served per-session, handler writes into the connection-local overlay; discovery rides services/list-peers - F-06 [minor]: per-session fork must carry bootstrap discovery ops for per-session openables to be discoverable Includes a non-findings section (e2e reference shape, register_openable completeness, channel-id split, envelope-kind closure, wasm-cleanliness) and a 4-unit plan: ADR decisions (Unit 1) -> fork surface (Unit 2) -> client serving + bootstrap op (Unit 3) -> alkhttp wiring downstream (Unit 4, tracked in alkhttp review 003). Verification: cargo test (565), clippy --all-targets -D warnings, fmt, doc --no-deps — all clean at c16b069. No source changes.	2026-09-03 14:42:57 +00:00