Commit Graph
15 Commits
Author SHA1 Message Date
glm-5.3-flash 73fdadafdd chore(tasks): wave-2 review gate passes green
- verdict GREEN: wave-3 decomposition unblocked; no blockers, no
  booked findings, zero core changes across wave 2 (verified by
  reading the three commits' file stats)
- ssr proof checked line by line against emit.md posture B: machinery
  equality, fragment composition with render-name rule, escape and
  raw-slot goldens, typed error-page mapping, determinism, hygiene
- code proof checked line by line against emit.md postures A/C and
  ADR-003: document order vs sort/reverse, no-op escaping, rebuild and
  registration-order determinism, two-sink equality; banner gap honest
- stop-and-book ledger clean; ADR-001 generality claim holds on real
  code (both postures served with no core exceptions)
- conformance battery verified as the standing set; AGENTS.md carries
  the standing wasm build and feature-matrix postures
- conventions audit and full verification set re-run clean (51 tests,
  clippy, fmt, doc, wasm release, tree inspection, taskgraph)
- inline fix: checked the battery task's completed-but-unchecked
  acceptance boxes

Verification: cargo test (51 passed), cargo test --all-features,
cargo clippy --all-targets -- -D warnings, cargo fmt --check, cargo
doc --no-deps, cargo build --target wasm32-unknown-unknown --release,
taskgraph validate (18 tasks), handlebars tree default-only
2026-11-07 05:43:43 +00:00
glm-5.3-flash 952f208e27 test(conformance): the standing wave-2 conformance battery
- strict-mode matrix: missing variables (top-level, in {{#each}},
  in {{#if}} then and else branches) fail typed through both
  sinks, never silent; the write sink's no-atomicity contract
  pinned by its row
- error-surface completeness: six failure paths each mapping to
  exactly one typed variant; registrations never half-survive;
  hostile context values render clean through both sinks and both
  escape policies with no panic paths
- two-sink correctness: byte-identical output over the ssr-shaped
  and code-shaped fixture postures, re-exercised over the proof
  fixture files (goldens stay pinned by the proof binaries)
- AGENTS.md: the wasm release build becomes standing and
  unconditional; the feature-matrix coincide-today posture and the
  handlebars feature-inspection posture documented honestly
  (ADR-003, ADR-009)

Verification: cargo test (all green), cargo test --all-features
(identical), clippy -D warnings clean, fmt clean, doc clean, wasm
release build clean, handlebars tree features default-only,
taskgraph validate clean
2026-11-06 20:44:52 +00:00
glm-5.3-flash 3b0483e50f test(code-proof): wave-2 code-shape proof through the public API (posture A/C)
- code-shaped fixture set: writer + validator template kinds over one
  composed partial, no-op escaper, strict mode, all public API
- ADR-004 mappings in builder Rust (kind->call names, struct name,
  string-kind flag, source-quoted literals); templates stay dumb
- document order (not sort/hash/reverse) drives rendered order;
  reordered arrays render in the array's new order
- determinism: byte-identical across repeated renders, registry
  rebuilds, differing registration orders, fresh contexts, and both
  sinks (render vs render_to_write)
- banner stays an emit-layer obligation; no banner assertions in the
  proof (gap recorded in task Notes, honestly)

Verification: cargo test (38 passed), cargo clippy --all-targets --
-D warnings, cargo fmt --check, taskgraph validate
2026-11-06 20:34:42 +00:00
glm-5.3-flash 08803b3d17 test(ssr-proof): wave-2 ssr-html proof through the public API (posture B)
- full consumer-shaped fixture set registered from the test binary via
  register_template/register_partial only (ADR-008 machinery equality
  in three caller-supplied text shapes: fixtures, runtime String,
  inline literal)
- page composes fragment partials; the card fragment registers as its
  own template, renders directly by name, and composes via include
- exact goldens pin html-escape posture (hostile data escaped, = and '
  escapes, raw-output {{& }} slot verbatim)
- strict-mode render failure maps consumer-side to an error page built
  from the typed Error's data, panic-free; source chain reachable
- determinism pinned across repeats, registry rebuilds, fresh
  contexts, and both sinks (byte-identical, ADR-003)
- posture-B hygiene rows: no banner, no filesystem; no core changes
  required (stop-and-book: nothing to book)
2026-11-06 20:31:11 +00:00
glm-5.3-flash a4ec8be3e8 chore(tasks): decompose wave 2 into implementation tasks
- w2-ssr-proof and w2-code-proof: the two consumer-shaped proofs,
  parallel by construction (own test binaries, own fixture modules
  per the wave-1 convention)
- w2-conformance-battery: the standing verification set, ordered
  after the proofs so it consolidates over the final wave-2 tree and
  absorbs any stop-and-book findings; folds the wave-1 gate's
  reminder (b) (wasm build standing, not ad-hoc)
- review-wave-2: the wave gate, depends on all three
- decomposition record added to docs/plans/implementation.md with
  the logistic-ordering rationale; wave-2 status flipped to
  decomposed

Verification: taskgraph validate (18 tasks valid); em-dash grep
clean on all changed files
2026-11-06 20:16:11 +00:00
glm-5.3-flash 0a4aa1eefe chore(tasks): wave-1 review gate passes green
- Landed core verified against core.md's six components and
  ADR-002/003/004/005/008/009 postures, checked in code and tests
  rather than prose
- All four wave-1 interpretations confirmed: alktype removal (ADR-009
  decision 1, tree-verified), context-build arms absent by design
  (ADR-008), render-name rule via set-level bookkeeping, naming
  validation by tests only
- Verification set re-run clean: cargo test (27), clippy -D warnings,
  fmt, doc, wasm release build, taskgraph validate (14)
- Gate verdict green: wave-2 decomposition unblocked; three
  non-blocking reminders carried forward (freeze-inventory
  non_exhaustive decision, standing wasm pin, ADR-009 CI matrix)
2026-11-06 20:11:25 +00:00
glm-5.3-flash 14d8a49611 test(fixtures): wave-1 engine fixture doubles (ssr-shaped and code-shaped)
- ssr double: page template composing header/footer partials under the
  HTML escaper, typed context built by a builder fn per ADR-004; golden
  pins for composition, escaping of hostile interpolation, the trusted
  {{& }} slot, and render-by-partial-name rejection
- code double: struct-writer template under the no-op escaper, typed
  context built from a schema document with kind mapping and
  source-escaped literals in the builder; golden pins for document-order
  arrays and the active preserve_order feature
- fixture assets are include_str! files under tests/fixtures/; fixture
  modules are per-test-binary so wave-2 proofs can grow them
- task file updated to completed with Notes and Summary

Verification: cargo test green (19 lib + 8 fixture tests), clippy
-D warnings clean, cargo fmt --check clean
2026-11-06 20:05:42 +00:00
glm-5.3-flash e361b4181a feat(render): add the TemplateSet render entry point (both sinks, deterministic, strict)
- public TemplateSet::render (String sink) and
  TemplateSet::render_to_write (io::Write sink), synchronous and
  deterministic, both surfacing the wave-1 Error enum
- render-name rule enforced behaviorally: the entry resolves names
  against the set-level bookkeeping before the substrate is
  consulted, so a partial's name or an unknown name is a typed
  Error::Render (substrate TemplateNotFound reason), never a
  rendered partial
- strict-mode missing variable is a typed error in both sinks,
  never silently-empty output; the write sink's streaming
  (non-atomic) semantics on mid-render failure documented
- determinism pinned by tests: byte-identical repeated renders,
  byte-identical output across registry rebuilds in opposite
  registration order, and byte-for-byte agreement between sinks

Verification: cargo test (19 passed), cargo clippy --all-targets
-- -D warnings, cargo fmt --check, cargo doc --no-deps, and
cargo build --target wasm32-unknown-unknown --release all green.
2026-11-06 20:01:57 +00:00
glm-5.3-flash 22f32e6fc5 feat(registry): the set builder per ADR-002/005/008
- TemplateSet: one strict handlebars registry per template set; strict
  mode forced at construction, unparameterizable; enforcement test pins
  missing-variable renders as Error::Render, never empty output
- EscapePolicy::{Html, NoOp}: explicit per-set escaper choice; Html
  leaves the substrate default html_escape, NoOp registers
  handlebars::no_escape; both postures pinned by golden render tests
- typed fallible registration of templates and partials; malformed
  text is Error::Registration, never a panic; failed registration
  leaves bookkeeping untouched
- set-level bookkeeping of template vs partial names (decision 1,
  flagged for the gate): the substrate's register_partial is identical
  to template registration, so the render-name rule cannot delegate to
  it; TemplateSet::is_template exposes the tracking for the
  w1-render-entry rejection
- per-set helper registration seam; zero custom helpers by default,
  pinned by test (unknown helper is a typed render error)
- naming conveventions enforced by tests only, not at registration
  (decision 2, flagged for the gate): consumer-facing engine API
  stays naming-neutral per ADR-001/008

Verification: cargo test (15 pass), clippy -D warnings, fmt --check,
wasm32-unknown-unknown release build

Verification: cargo test (15 pass), clippy --all-targets -D warnings, cargo fmt --check, wasm32-unknown-unknown --release
2026-11-06 19:59:19 +00:00
glm-5.3-flash 02037c4f10 feat(error): the public error enum per core.md error model
- src/error.rs: pub enum Error via thiserror with Registration
  (#[from] TemplateError) and Render (#[from] RenderError) variants;
  substrate errors stay reachable through the source chain
- src/lib.rs re-exports alkgen::Error per convention 10
- six unit tests pin variant mapping, source-chain reachability, and
  operation-naming Display strings
- no catch-all; no context-build arm in this scope (recorded
  interpretation, flagged for the wave-1 gate)

Verification: cargo test, clippy -D warnings, fmt --check, cargo doc,
wasm32-unknown-unknown release build, taskgraph validate (14 tasks)
all green
2026-11-06 19:54:47 +00:00
glm-5.3-flash c678615f2d build(manifest): dep posture per ADR-002/009; drop alktype; declare bast-codegen
- pin handlebars = "6.4" on default features; tree verified free of walkdir and rhai
- remove alktype from deps: no consuming code in v0.1.0, so an optional
  entry would be a dead feature; re-add lands with bast-rust-codecs as
  bast-codegen = ["dep:alktype"] (flagged for the wave-1 gate)
- declare [features] bast-codegen = [] (name reserved per ADR-009, gates nothing)
- package metadata to the text-generation framing (ADR-001): description,
  keywords, and the src/lib.rs crate doc; version stays 0.1.0

Verified: cargo test, clippy -D warnings, fmt --check,
wasm32 release build, taskgraph validate, dep-tree inspection
2026-11-06 19:51:04 +00:00
glm-5.3-flash b154b65bed chore(tasks): decompose wave 1 into implementation tasks
Five implementation tasks plus the gate, per the plan's decomposition
record. Deliberately sequential logistics: all tasks edit the same
small module tree and lib.rs re-exports, each consuming the previous
task's surface.

- w1-manifest: dep pins (handlebars 6.4 default features, thiserror),
  alktype removal, bast-codegen feature name declared
- w1-error-model: the one public enum (registration/parse/render)
- w1-registry-construction: set builder, forced strict mode, escaper
  policy, typed registration, helper seam; two decisions to record
- w1-render-entry: both sinks, deterministic, strict errors
- w1-engine-fixtures: ssr-shaped + code-shaped doubles, golden-pinned
- review-wave-1: the cheap-place gate; dispositions the four recorded
  interpretations

Four interpretations flagged for the gate (alktype removal vs
optional-behind-feature, context-build arms, partial render-target
enforcement, naming validation); recorded in the plan.

Verification: taskgraph validate clean (14 tasks), waves + deps
acyclic, em-dash grep clean
2026-11-06 18:27:28 +00:00
glm-5.3-flash 9d57d1612e docs(architecture): review pass: flip specs to reviewed; fix review findings
- Define the fragment-rendering convention: render targets are
  registered templates composing partials; partials are composition
  units (core.md, emit.md posture B)
- Define template kind; trim/restage inline rationale with ADR
  citations (core.md)
- Amend ADR-008: wgsl set ownership resolved engine-owned via OQ-05's
  2026-11-06 resolution
- Add OQ-09: consolidate the untracked bast-rust-codecs detailed-spec
  residue (projection, error shape, writer survey) with paired tracker
  task
- Fix oq-05 tracker name to match the corrected unblocking condition
- Add reviewed-transition rule: deferred OQs with tracker tasks do not
  block reviewed; flip six spec docs draft -> reviewed

Verification: taskgraph validate (8 tasks valid), em-dash grep zero
hits, cargo doc --no-deps clean
2026-11-06 10:33:43 +00:00
glm-5.3-flash 077e52c003 docs(architecture): re-triage OQs to per-target emit policy; fix OQ-05 circular framing
- OQ-01/02/03 re-triaged from open to deferred(scope): partitioning,
  regeneration, and validation strategies are per-target decisions
  owned by each target's emit layer and consumer, not core or
  posture-A-wide policy; session analysis preserved in OQ texts
- OQ-05 ownership decided by applying ADR-008 (engine-owned, ships in
  alkgen, feature-gated, posture C); blocked-on reframed to alkjs
  GPU-layer work so the sequencing is non-circular (alkjs builds on
  the core, never the reverse)
- OQ-06 sequencing clarified; stale far-timeline language dropped
- activation queue recorded (ssr-html, wgsl-jit, then codec sets) in
  targets.md and overview.md, with downstream dev-utility composition
  noted at the overview level
- Preact vs handlebars SSR research outcome recorded in README
- tracker tasks added for oq-01, oq-02, oq-03; oq-05 task updated

Verification: taskgraph validate (7 tasks pass); em-dash grep clean on
touched files; docs-only change, no code touched
2026-11-06 10:06:54 +00:00
glm-5.3-flash a91ea2ec89 docs(architecture): phase 1 base: text-generation core specs, ADRs 001-010, OQ tracker
- overview.md, core.md, emit.md, targets.md: modular spec set for the
  generalized engine (contexts + templates + partials -> text), with
  the three targets (ssr-html, bast-rust-codecs, call-handlers,
  wgsl-jit) as template sets plus emit postures
- ADRs 001-010: one core/template-set split, handlebars 6.4 strict
  substrate, sync/wasm/deterministic posture, typed contexts with
  builders, per-registry escaper, SSR library posture, typed direct
  codecs output contract, template-set ownership, feature gating,
  library-only v1
- open-questions.md: OQ-01..OQ-08 centralized tracker carrying phase-0
  residue (GN-01/02/07/09) with three deferred(scope) entries plus a
  resolved disposition for phase-0 OQ-GN-04
- tasks/architecture/: external-trigger tracker tasks paired with the
  deferred OQs (taskgraph validate passes)
- phase-0.md checklist dispositioned for OQ-GN-04; AGENTS.md lifecycle
  updated to phase 1

Verification: taskgraph validate (4 tasks OK), cargo fmt --check,
cargo test, em-dash grep clean; architecture-reviewer pass returned
zero critical issues
2026-11-06 08:18:43 +00:00