- N-4: GitPackIngest's prepare binding carries push_options:
Option<&PushOptions> (parsed (key, value) pairs, verbatim and
un-interpreted; None until the config gate opens) — pinned in
ADR-013 §11 and backend.md's trait description so opening the
config gate later is value-additive, not a trait redesign
- N-5: ls-refs=unborn verification recorded as a rider in
transport.md §ls-refs + tracker task tasks/architecture/
n5-unborn-head-rider.md (unborn fixture, real client, both
substrates; drop the token if it cannot be served — ADR-003)
- review 001: N-4, N-5 marked resolved
verification: cargo test, clippy -D warnings, fmt --check, doc — clean
Resolves review 001 findings A-2 (critical) and A-6 (major) — the same
signature surface:
- ADR-012 §1: registry traits amended to #[async_trait] (bare async fn
in traits is not dyn-compatible, E0038; ops sit behind Arc<dyn
GitRegistryStore>). Desugared boxed Future form pinned in OQ-03's
freeze inventory. async-trait = "0.1" added to the manifest.
- backend.md concurrency model: the five-trait family is
#[async_trait] Send + Sync dyn-compatible; the wire layer enforces
ADR-009's pipeline-concurrency budget itself (permit acquired around
each GitPackGen/GitPackIngest call — the concrete admission point);
impls must not block the async executor and own their internal
threading (gix impls run spawn_blocking inside the impl — POC-2's
shape restated at its true layer).
- transport.md §fetch: spawn_blocking sentence rephrased to the
trait-contract version (the wire spec stops speaking gix).
- ADR-009: enforcement point of the blocking-pool budget made concrete.
- ADR-013 §6: ingestion spawn_blocking line aligned.
- review 001: A-2, A-6 marked resolved.
Verification: cargo test, clippy -D warnings, fmt --check, doc
--no-deps, check --no-default-features, check --all-features — all
clean.