glm-5.3-flash
e76f91f6d7
- ADR-013: V0-framed push machine grounded in real git 2.43.0 captures
(file://, git://, smart-http mock, raw stdio into real receive-pack):
V0-shaped ref advertisement (caps on first ref line, capabilities^{}
sentinel only for empty repos), served capability set, shallow requests
rejected for v1, thin packs accepted with server-odb bases (no
capability involved; push.thin default), ingestion bound to
Bundle::write_to_directory_eagerly + gix-fsck + one gix-ref transaction
per push (.keep-guarded), unpack-first CAS timing with observed
upstream order, band-1 pkt-line-framed status report, http framing
(probe/Content-Length/chunked), v1 update policy (CAS only; deletes
and force-push allowed)
- docs/research/push-captures.md: the normative push wire record
- transport.md/backend.md/doors.md: receive-pack sections rewritten to
the decided shapes; backend.md ingestion composition bound; stale
OQ-04 references resolved
- ADR-003 amended: V2-only governs fetch; push is V0-framed by upstream
design (fixes the V2-only contradiction found in review)
- ADR-009 amended: haves default reconciled with the client's stateless
ceiling (16384); blocking-pipeline budget covers generation+ingestion
- OQ-04 resolved; tracker task closed; CAS-fail-fast optimization
tracked (tasks/architecture/oq-13-cas-failfast.md)
- research index: poc findings + capture docs listed
Verification: cargo test / clippy -D warnings / fmt --check / doc pass
1.4 KiB
id, name, status, depends_on, scope, risk, impact, level, tags
| id | name | status | depends_on | scope | risk | impact | level | tags | |
|---|---|---|---|---|---|---|---|---|---|
| architecture/oq-13-cas-failfast | Backlog — CAS-before-unpack fail-fast pre-check on push | pending | narrow | low | component | implementation |
|
Description
Optimization backlog item from ADR-013 (§7, §Consequences): a pre-unpack CAS pre-check on receive-pack — reject commands with obviously-wrong old-ids before reading the pack body, failing fast instead of ingesting a pack whose refs would be rejected anyway. The protocol-correct order (unpack-first, then per-ref checks) is what v1 implements; this is an optimization, additive, and two-way (internal behavior, not wire shape — the report shape is unchanged).
Work
When receive-pack implementation is on the critical path for a
deployment with heavy stale-push traffic (measured, not hypothetical):
add the pre-check to the transport push state machine, after command
parse and before ingestion. Rejected refs report the same ng <ref> <reason>; the pack body is then drained (or the connection closed per
the substrate's error rule).
Verification
- All existing push tests still pass (real
git pushagainst the transport). - A stale-old push errors before the pack body is fully read (observable via the body-budget counters or a truncated-body test).
Out of scope
- Changing the report shape or the protocol order (ADR-013 §7 stands).
Summary
Filled on completion.