The pre-freeze code-quality review of the substrate composition (the
review-004/005 precedent's five dimensions plus the two
substrate-specific ones: engine-twin parity and assembly-shape/per-piece
parity), inserted between the wave-9 gate and wave 10's decomposition.
Inline-fixed in the review session (Part A):
- S-1: the pg registry's put/remove transactions touched git_refs
without the {schema}\0git_refs advisory lock the refs CAS twins hold
for their whole call — the F-S2 sibling that didn't get the fix; an
orphan-row window under multi-instance co-tenancy. Fixed per the
gate's own F-S2 pattern (both legs + docs).
- S-2: the live-pg silence-probe gate was module-private while the
compose entry's live tests announce ungated on the same container;
the gate promoted to live_harness and taken by all three.
- D-1: the substrate crate-root doc rewritten (the review-005 D-2
analog — the wave-status changelog paragraphs dropped, the
lfs/lfs_adapter map entries added).
- D-2..D-5: the VersionedRefTable epoch comment corrected (every green
call bumps), a duplicated liveness seam comment removed, stale
wave-7/9 narration replaced with landed module pointers, and the one
library-side expect restructured (convention 2 clean).
Recorded (Part B, the wave-10 decomposition's inputs): R-1 the
postgres.rs placement split (recommendation), R-2 the impl helper
dedups, R-3 the test-harness consolidation, R-4 the mem_registry
disposal, R-5 the per-surface coverage table (review-time evidence;
F-w10-B1's input), R-6 the per-piece parity class F-w10-B2 absorbs,
R-7 the engine-less combo joins F-w10-B6's feature hygiene; N-1..N-4
observations.
Verification: cargo test 376 / -p alkgit 376 / -p alkgit-substrate 184
/ --all-features 379 / live-pg 208 passed 0 skips / both clippy passes
clean / fmt clean / doc zero warnings / fuzz corpus gate 13 green /
taskgraph validate 81 valid.
Reviewed artifacts: all substrate/src modules in full, the wave-9
gate's F-B1/F-S1..S9 fixes at their sites, the twin families swept
family by family.
glm-5.3-flash
7bef60ca33