docs(review 007 Unit 2): WS-31 discovery-shadowing note + record corrections

- WS-31: websocket.md §"Data channels for browsers" + ADR-067's landed
  note record that WS-session discovery is the bootstrap set — the
  hook's bootstrap `services/*` registrations overwrite a
  base-registry `services/*` registration on the WS path by design
  (a deployment's custom `services/list` is shadowed on WS sessions
  only).
- ADR-048's landed note: correction + completion — the WS-26
  retention sentence was aspirational at the landed commit (WS-28) and
  is now real; the UP-02 posture's override half is now an explicit
  surface (`with_ws_op_register_acl` / `OpRegisterAcl`), with the
  note that `ChannelsPolicy` could not carry an op ACL.
- ADR-067's landed note: review-007 notes (WS-28 fix + gate, WS-29
  surface, WS-31 record).
- OQ-05 resolution: the retention claim carries the WS-28 correction.
- review-006 UP-02 log + WS-26 paragraph: corrections marking what the
  pre-fix tree did not have, with the landed remediation named.
- review-002 WS-17: the "bounded at 64 sessions" claim corrected —
  the bare-registry semaphore was per-request and bounded nothing;
  `SessionSlots` is the shared-cap surface.
- review-007 status: open for remediation → remediated, with the
  decisions taken (both "implement" options) and the gate names.

Verification: cargo test 454 passed / 0 failed; cargo doc --no-deps
clean (6 pre-existing warnings, identical at baseline).

Review: docs/reviews/007-ws-data-channel-surface-review.md
This commit is contained in:
2026-09-05 05:45:31 +00:00
parent 24c2e9a224
commit 802d94ec07
7 changed files with 87 additions and 4 deletions
@@ -2,7 +2,23 @@
## Status
Open for remediation.
Remediated (2026-09-05). WS-28: the `ConnectionGuard` now binds in the
channel-0 task's frame (`Option<ConnectionGuard>`, the `SessionGuard`
shape), with the re-added repro gate
(`live_connections_visible_mid_session_and_drain_after_teardown`) —
verified to fail against the pre-fix tree and pass with the fix. The
decisions taken during remediation, both the "implement" options: WS-29
landed the recorded override surface
(`HttpAdapter::with_ws_op_register_acl` + the `OpRegisterAcl` request
extension; builder + extension gates); WS-30 landed the `SessionSlots`
extension (the shared-cap surface for bare-registry routes, with the
review-002 WS-17 correction). WS-31: the discovery-shadowing sentence
is in (websocket.md §"Data channels for browsers", ADR-067's landed
note). WS-32: the builder-path openables gate
(`builder_path_openables_serve_the_data_channel_surface`). The
review-006 UP-02 / WS-26 log entries and ADR-048's landed note carry
corrections where the pre-fix code did not match the recorded claim.
Verification: the standard gate set (below), extended to the new gates.
## Scope