chore(tasks): mark js01, con18-wss, fwd17-19, con18b completed
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
---
|
||||
id: review-002-con18-wss-sweep-exit
|
||||
name: Dead-connection fast-fail + bounded from_wss sweep exit (CON-18)
|
||||
status: pending
|
||||
status: completed
|
||||
depends_on: []
|
||||
scope: narrow
|
||||
risk: low
|
||||
@@ -56,4 +56,8 @@ plus a sweep-generation counter (exit after N idle sweeps post-EOF).
|
||||
The alkcall-side CF-001 note matters: if/when the dead-mux write
|
||||
mapping changes, the fail-fast class here should match. Keep the
|
||||
WS-02 losslessness invariant intact — fast-fail is an *additional*
|
||||
resolution path, not a replacement for the watch signal.
|
||||
resolution path, not a replacement for the watch signal.
|
||||
|
||||
## Summary
|
||||
|
||||
50ms drain interval + monitor return after 8 consecutive empty post-EOF drains (~400ms grace); post-EOF registrations fail fast with retryable CONNECTION_CLOSED; fixed a busy-spin in the old select's eof branch. ADR-070 updated. No public API change.
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
id: review-002-fwd17-19-contract-decisions
|
||||
name: Forwarding contract decisions — non-JSON SSE payloads, double-routed placeholders, percent preservation (FWD-17/18/19 decide+document or fix)
|
||||
status: pending
|
||||
status: completed
|
||||
depends_on: [review-002-fwd15-stream-timeout]
|
||||
scope: narrow
|
||||
risk: low
|
||||
@@ -65,4 +65,8 @@ Deliberately a decide-first task: none of the three is a crash or
|
||||
leak; each is a contract the code half-implies. Keep the decisions
|
||||
small and documented rather than building speculative machinery (e.g.
|
||||
no new envelope schema unless (b) is actually chosen). Coordinate with
|
||||
review-002-fwd13-dot-segments (same helpers, different concerns).
|
||||
review-002-fwd13-dot-segments (same helpers, different concerns).
|
||||
|
||||
## Summary
|
||||
|
||||
FWD-17: non-JSON SSE payloads surface as {data, event} wrapper (event: captured, WHATWG last-wins, leak fixed). FWD-18: structural placeholder values are INVALID_INPUT (no JSON splicing into paths). FWD-19: % in values always encoded, template text preserves pre-encoded % (ADR-066 trust boundary). ADR-066 records all three; SseEvent gained an event field (crate-internal).
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
---
|
||||
id: review-002-js01-placeholder-check
|
||||
name: Fix placeholder check skipped when input_schema has no properties (JS-01)
|
||||
status: pending
|
||||
status: completed
|
||||
depends_on: []
|
||||
scope: single
|
||||
risk: low
|
||||
@@ -53,4 +53,8 @@ declared properties, any placeholder is unbound. The existing test
|
||||
One-line fix + one test. Explicitly approved to fold into any commit
|
||||
that is already touching from_jsonschema.rs (e.g. the wire-tests task)
|
||||
if a session prefers — but if touched standalone, keep it its own
|
||||
commit per the small-units convention.
|
||||
commit per the small-units convention.
|
||||
|
||||
## Summary
|
||||
|
||||
Removed the properties.is_empty() early return in spec_name_references_undeclared - placeholder templates with a properties-less input_schema now fail construction (matches from_openapi unbound_placeholders). Both acceptance branches tested.
|
||||
|
||||
Reference in New Issue
Block a user