alkhttp/tasks/server/review-001-mcp-body-limit.md at 12b35e2c5f8bb16217d937296ca6df9135318843

Files

T

glm-5.3-flash 12b35e2c5f docs(tasks): decompose review 001 remediation Units 1-5 into taskgraph tasks

21 review-001 tasks across server/adapters/client/gateway/websocket/infra,
chunked from the 7-unit remediation plan in
docs/reviews/001-initial-implementation-review.md.

- Scope split by mechanism, not one-per-finding: 15 tasks in generation 1
  (parallelizable), 6 sequenced after their file-sharing precursors
- Deliberately deferred until dependent fixes land: projection/doc
  fidelity partial (Unit 6 beyond dependency hygiene), coverage backfills
  (COV-01..07 via in-task acceptance for forward.rs), and per-finding
  minors (OAI-06/07, HY-02/04/06/10/11, CON-08)
- Cross-crate WS-12 (alkcall demux 4 GiB discard alloc) noted for filing
  in alkcall, not here

taskgraph: validate clean, no cycles, 6 generations

2026-08-29 07:10:15 +00:00

1.7 KiB

Raw Blame History

id, name, status, depends_on, scope, risk, impact, level, tags

name

status

depends_on

scope

risk

impact

level

Description

Review 001 finding SRV-03 (mcp feature only): src/server/adapter.rs:141-150 nests rmcp's StreamableHttpService; the bearer middleware only stashes identity. axum's 2 MiB DefaultBodyLimit applies to axum extractors, but the nested rmcp service collects the raw body itself (body.collect().await, verified against rmcp 1.8.0) with no cap — a single multi-GB chunked POST /mcp is buffered entirely in memory; a few concurrent requests OOM the process. Gateway routes are correctly capped at 2 MiB by the extractors; /mcp is the one uncapped surface.

Fix: wrap the /mcp nest with an explicit DefaultBodyLimit (or an equivalent body-limit layer) sized for MCP traffic. Pick and document the limit (a JSON-RPC batch is the largest legitimate body; something in the 2–8 MiB range is defensible) rather than leaving it at hyper's unlimited default.

Acceptance Criteria

Explicit body limit applied to the /mcp nest; limit value documented in code and ADR-039 or http-server.md if touched
Test: oversized POST /mcp body → 413 (Content-Length and streaming/chunked variants)
Normal-size MCP initialize + tools/call round-trip still passes
cargo test --all-features passes (feature-gated code)

References

docs/reviews/001-initial-implementation-review.md (Part A, SRV-03)
docs/architecture/decisions/039-http-server-and-client-host-colocated.md

Notes

Agent fills during implementation.

Summary

Filled on completion.

1.7 KiB Raw Blame History Unescape Escape