Full-surface integration suite (tests/full_surface.rs, mcp feature): - one HttpAdapter over real TCP (ProtocolHandler::handle path) serving gateway endpoints, /openapi.json, /mcp, and the WS channels session - gateway: search/schema/call/subscribe/batch/publish presence, envelope shapes, error fidelity end-to-end - from_openapi import -> Internal-by-default invisible from the wire -> External facade composes it via env.invoke -> upstream HTTP API called end-to-end (ADR-015 composition model exercised) - to_openapi 6-path doc validated against openapiv3 over the wire - to_mcp: MCP client connects to /mcp on the served adapter, lists the 4 gateway tools, search returns ACL-filtered ops (Sub excluded) Production fix: the WS upgrade route was reserved but never wired into HttpAdapter's router (the ws-upgrade-session tests built their own router). Now wired with ws_bearer_auth (401 without a resolvable token) around ws_upgrade_handler. Docs sync: all 28 'Port notes' sections/blockquotes stripped from ported ADRs/specs; OQ-01/OQ-02 statuses corrected to resolved in overview.md, websocket.md, and the README table (open-questions.md was already current). Publish prep: cargo publish --dry-run --allow-dirty succeeds; cargo doc --no-deps warning-free (ADR link targets fixed); feature combinations (default / test-support / mcp / wss / all) compile warning-free under clippy -D warnings. Verified: cargo test (182 lib default), --all-features (227 lib + 29 integration), clippy -D warnings x3 feature sets, fmt, doc, publish --dry-run.
10 KiB
ADR-066: from_jsonschema as an HTTP-Backed Single-Endpoint Adapter in alkhttp
Ported from alknet ADR-066 (from_jsonschema as an HTTP-Backed Single-Endpoint Adapter in alknet-http); re-targeted to alkhttp.
Status
Accepted (supersedes the from_jsonschema clause of ADR-017 §5 and the
FromJsonSchema provenance row of ADR-022 — both described a schema-only,
no-handler adapter in the call crate)
Context
from_jsonschema was originally specified (alknet ADR-017 §5) as a
schema-only
adapter living in the call crate (alknet-call, now alkcall): it produced
HandlerRegistration bundles
with a NOT_FOUND-returning placeholder handler and FromJsonSchema
provenance. The stated use case was validation, discovery, and
composition-graph construction without a runtime — type-checking a
composition plan without executing it, building a UI of available
operations without standing up the transports.
This is broken. An operation in the OperationRegistry needs a real
handler. A placeholder that returns NOT_FOUND does not work with how
the registry is supposed to function: an Internal op registered with
a dead handler is a trap, not a feature. The "schema-only, no handler"
concept conflated two things — schema validation (a compile-time /
planning activity that doesn't need a registry entry at all) and
operation registration (which always needs a handler). Validation
against a JSON Schema does not require a HandlerRegistration; it
requires the schema and a validator. Registering an operation requires
a handler. The old from_jsonschema tried to do the former by abusing
the latter, and produced something that works for neither.
The misplacement was compounded by a location error: the adapter lived
in the call crate (which is supposed to stay lean — no HTTP client), but
a from_jsonschema that is actually useful for calling non-standard
endpoints needs reqwest, exactly like from_openapi and from_mcp.
The adapter location map in ADR-017 / the call crate's
client-and-adapters.md already
establishes that HTTP-backed adapters live in the HTTP crate; the old
from_jsonschema violated its own stated principle by living in
the call crate. The move was recorded as alknet ADR-066 (moved from
alknet-call to alknet-http); with the extraction, that makes it this
crate — alkhttp. The FromJsonSchema provenance variant itself stays in
the call crate (alkcall ADR-027 records the provenance-side decision:
FromJsonSchema is a handler-bearing leaf in alkcall's
OperationProvenance enum).
A concrete use case now forces the decision: composing a non-standard,
non-OpenAPI, basic REST endpoint that does not have a full OpenAPI
document. The endpoint has a method, a URL, an input/output JSON Schema,
and an auth scheme — but no paths object, no operationId, no
components. from_openapi requires an OpenAPI document; this endpoint
doesn't have one. The gap is: register a single HTTP endpoint as a
call-protocol operation, one at a time, with the caller supplying the
schema directly.
Decision
from_jsonschema becomes an HTTP-backed single-endpoint adapter in
alkhttp, functionally similar to from_openapi but registering
one endpoint at a time instead of parsing a full OpenAPI document:
-
The adapter implementation lives in alkhttp (
src/adapters/from_jsonschema.rs). The forwarding handler uses the same reqwest-backedSharedHttpClientand the same no-env-vars credential injection asfrom_openapi. The adapter implementsOperationAdapter(the trait from alkcall, ADR-017 §5 — unchanged). -
Give it a real forwarding handler. A
from_jsonschema-imported operation is a leaf with a reqwest forwarding handler, identical in shape to afrom_openapi-imported operation — it builds an HTTP request from the input (path/query/body split per a path template), injects credentials fromcontext.capabilities, sends via the shared HTTP client, and parses the response (JSON, text, or binary — same content-type branching asfrom_openapi). For aSubop type withtext/event-streamresponse, it registers aStreamingHandler(ADR-049), same asfrom_openapi. -
Single-endpoint registration. The caller supplies:
- An
OperationSpec(name, op type, input/output JSON Schema,error_schemas,access_control,visibility). - An
HttpServiceConfig(base URL, auth scheme, default headers — the same config typefrom_openapiuses). - A path template + HTTP method (the one endpoint).
The adapter builds one
HandlerRegistrationwithFromJsonSchemaprovenance and a real forwarding handler. The caller registers it in theOperationRegistry. This is the "one endpoint at a time" shape: nopathsobject to iterate, nooperationIdto normalize. - An
-
FromJsonSchemaprovenance stays in alkcall (in theOperationProvenanceenum,registration.rs). The provenance type lives where the registry types live; only the adapter implementation moved.FromJsonSchemais now a leaf provenance — it has a handler (a reqwest forwarding handler), same trust model asFromOpenAPI(HTTP endpoint trusted; handler is a forwarding stub). -
Remove the "schema-only, no handler" concept. The placeholder handler and the "schema-only ops are
Internal, so dispatch should never reach them" rationale are removed. An op registered withFromJsonSchemaprovenance is a real, callable, HTTP-forwarding operation —Internalby default (adapter-registered ops are composition material, ADR-015), but it actually forwards if invoked.The schema-validation-without-a-handler use case (type-checking a composition plan, building a UI) does not require a
HandlerRegistrationat all. That use case is served by consuming theOperationSpecdirectly (the spec already carries the input/ output JSON Schemas); no adapter, no registry entry, no handler is needed. If a future use case requires registering a schema-only op for discovery purposes, that is a separate feature and would warrant its own ADR — it is not whatfrom_jsonschemais.
Relationship to from_openapi
from_openapi |
from_jsonschema |
|
|---|---|---|
| Input | A full OpenAPI 3.x document (JSON or YAML) | A single endpoint: OperationSpec + HttpServiceConfig + path template + method |
| Granularity | One HandlerRegistration per (path, method) in the doc |
One HandlerRegistration per call |
| Schema source | Parsed from the OpenAPI doc (parameters, request body, responses) | Supplied directly by the caller |
| Handler | reqwest forwarding handler (shared HTTP client) | Same reqwest forwarding handler |
| Provenance | FromOpenAPI |
FromJsonSchema |
| Location | alkhttp | alkhttp |
| Use case | Standard OpenAPI APIs (GitHub, OpenAI, Anthropic) | Non-standard, non-OpenAPI, or basic REST endpoints without a full spec |
The two adapters share the forwarding-handler implementation, the
credential injection path, the error-fidelity rule (HTTP_<status>
prefix, ADR-023), and the no-env-vars
invariant (ADR-014).
The
difference is purely the input shape: a full document vs. a single
endpoint.
Consequences
Positive:
from_jsonschemaactually works — it has a real handler, not a placeholder. A concrete use case (non-standard REST endpoints) is served.- The adapter location is consistent: all HTTP-backed adapters
(
from_openapi,from_mcp,from_jsonschema) live in the HTTP crate (alkhttp), where reqwest is. The call crate (alkcall) stays lean. - The "schema-only, no handler" trap is removed. An op in the registry is always callable.
FromJsonSchemaprovenance becomes a real leaf, consistent withFromOpenAPI/FromMCP/FromCall.
Negative:
- The schema-validation-without-a-handler use case (the original stated
purpose) is no longer served by
from_jsonschema. That use case is served by consumingOperationSpecdirectly, but any code that relied on the placeholder handler returningNOT_FOUNDbreaks. The only existing consumer was the call crate's own tests; no downstream consumer depended on this — the placeholder was a trap, not a contract. - The call crate loses a public export (
from_jsonschema,FromJsonSchemathe adapter struct). TheFromJsonSchemaprovenance variant stays; the adapter struct moves. Downstream consumers that referenced the adapter (none currently) would need to use alkhttp's re-export.
Neutral:
FromJsonSchemaprovenance is now a leaf (handler-bearing), not a "no handler" provenance. The ADR-022 table row updates: it can compose? No. Has composition authority? No. Default visibility? Internal. Trust model? HTTP endpoint trusted; handler is a forwarding stub. This aligns with the other leaves. ADR-017 §5 and ADR-022's provenance table/enum-doc are amended (2026-07-09) to point here — the supersession is recorded in the superseded ADRs, not only in this one.
References
- Supersedes the
from_jsonschemaclause of ADR-017 §5 ("FromJsonSchema— imports from a JSON Schema definition (schema-only, no handler)") and the operational spec in the call crate'sclient-and-adapters.md§"from_jsonschema" (alknet mono-repo:docs/architecture/crates/call/client-and-adapters.md). - Supersedes the
FromJsonSchemarow of ADR-022 (the "no handler — schema only" framing). - Aligns with the adapter location principle in
ADR-017 §5 and the
call crate's
client-and-adapters.md§"Adapter Location Map": HTTP-backed adapters live in the HTTP crate (alkhttp). - Reuses the forwarding handler, credential injection, error fidelity
(
HTTP_<status>prefix, ADR-023), streaming shape (ADR-049), and no-env-vars invariant (ADR-014) established byfrom_openapi. - Reuses
HttpServiceConfigandSharedHttpClientfromfrom_openapi(in alkhttp). - alkcall ADR-027 — the decision record in the call crate (
from_jsonschemaas an HTTP-backed adapter;FromJsonSchemaprovenance is a handler-bearing leaf in alkcall'sOperationProvenance).