From 0d0f0f8da6f7ef6f2a1ba926454ece3b13a930f3 Mon Sep 17 00:00:00 2001 From: "glm-5.2" Date: Tue, 23 Jun 2026 15:33:16 +0000 Subject: [PATCH] tasks: mark core/review-core completed --- tasks/core/review-core.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tasks/core/review-core.md b/tasks/core/review-core.md index b9d4064..3722792 100644 --- a/tasks/core/review-core.md +++ b/tasks/core/review-core.md @@ -1,7 +1,7 @@ --- id: core/review-core name: Review alknet-core implementation for spec conformance and pattern consistency -status: pending +status: completed depends_on: [core/endpoint] scope: moderate risk: low @@ -119,4 +119,9 @@ phase. ## Summary -> To be filled on completion \ No newline at end of file +Reviewed alknet-core against all spec docs — implementation is spec-conformant. +Found and fixed one issue: `RawKeyCertResolver`/`Ed25519SigningKey`/`std::path::Path` +were gated on `#[cfg(feature = "iroh")]` but only used in the quinn TLS path, +causing clippy failures on iroh-only builds. Re-gated to +`#[cfg(all(feature = "quinn", feature = "iroh"))]`. All 4 feature combinations +now pass clippy -D warnings; 55 tests pass. Merged to develop. \ No newline at end of file