From 9ab789ec5fa22107f184f30282c76cfc791f868b Mon Sep 17 00:00:00 2001 From: "glm-5.1" Date: Sun, 7 Jun 2026 12:25:29 +0000 Subject: [PATCH] tasks: mark all 6 remaining architecture tasks as completed with notes and summaries --- tasks/architecture/review-adr-foundation.md | 6 +++--- tasks/architecture/review-spec-foundation.md | 6 +++--- tasks/architecture/spec-update-call-protocol.md | 6 +++--- tasks/architecture/spec-update-napi.md | 6 +++--- tasks/architecture/spec-update-overview.md | 6 +++--- tasks/architecture/spec-update-server.md | 6 +++--- 6 files changed, 18 insertions(+), 18 deletions(-) diff --git a/tasks/architecture/review-adr-foundation.md b/tasks/architecture/review-adr-foundation.md index 789c729..dae58c4 100644 --- a/tasks/architecture/review-adr-foundation.md +++ b/tasks/architecture/review-adr-foundation.md @@ -1,7 +1,7 @@ --- id: architecture/review-adr-foundation name: Review Phase 0a ADRs — foundation decisions before spec writing -status: pending +status: completed depends_on: - architecture/adr-034-head-worker-terminology - architecture/adr-032-event-boundary-discipline @@ -44,8 +44,8 @@ This review should happen before any spec documents are created or updated, sinc ## Notes -> To be filled by implementation agent +ADRs reviewed for cross-reference consistency, terminology alignment, and acyclic dependency graph. Two fixes applied: ADR-027 dependency graph diagram clarified and missing cross-reference to ADR-028 added; ADR-033 missing cross-references to ADR-026 and ADR-028 added. ## Summary -> To be filled on completion \ No newline at end of file +All 9 Phase 0a ADRs (026-034) reviewed. No contradictions found between ADRs. Minor fixes: ADR-027 dependency graph made clearer, ADR-027 and ADR-033 cross-references completed. ADR numbering gaps (020-022) noted in README.md footnote. \ No newline at end of file diff --git a/tasks/architecture/review-spec-foundation.md b/tasks/architecture/review-spec-foundation.md index 5dcc413..fe0b1f3 100644 --- a/tasks/architecture/review-spec-foundation.md +++ b/tasks/architecture/review-spec-foundation.md @@ -1,7 +1,7 @@ --- id: architecture/review-spec-foundation name: Review Phase 0 specs — validate consistency, completeness, and ADR alignment -status: pending +status: completed depends_on: - architecture/spec-configuration - architecture/spec-identity @@ -51,8 +51,8 @@ Review all Phase 0 spec documents after they're written. This is the Phase 0 rev ## Notes -> To be filled by implementation agent +Architecture-reviewer subagent found 4 critical, 14 warnings, 8 suggestions. All 4 critical issues fixed: OQ-SVC-05 added to open-questions.md, "NAPI/hub" → "NAPI/head", "AuthService" → "AuthProtocol"/"ConfigIdentityProvider", "noq" → "irpc over iroh QUIC streams". Key warnings fixed: inline OQ text replaced with cross-references in services.md/secret-service.md/storage.md, OQ-SVC-04 status corrected to resolved, duplicate links removed, server.md ForwardingPolicy phrasing aligned with ADR-031, ADR numbering gap footnote added. Additional improvements: ConfigServiceImpl defined in configuration.md, broken workspace-absolute links fixed (feasibility/certbot/fail2ban/event_source_types copied into docs/research/), README doc descriptions updated. ## Summary -> To be filled on completion \ No newline at end of file +All Phase 0 specs reviewed for consistency, completeness, and ADR alignment. 4 critical issues and key warnings resolved. ConfigServiceImpl formally defined. Link portability addressed by copying referenced docs into project tree. \ No newline at end of file diff --git a/tasks/architecture/spec-update-call-protocol.md b/tasks/architecture/spec-update-call-protocol.md index d0b7575..b698ffa 100644 --- a/tasks/architecture/spec-update-call-protocol.md +++ b/tasks/architecture/spec-update-call-protocol.md @@ -1,7 +1,7 @@ --- id: architecture/spec-update-call-protocol name: Update call-protocol.md — add OperationEnv dispatch paths, irpc as backend -status: pending +status: completed depends_on: - architecture/adr-033-operationenv-irpc-call-protocol - architecture/spec-services @@ -57,8 +57,8 @@ The current call-protocol.md already covers: operation paths, EventEnvelope wire ## Notes -> To be filled by implementation agent +Added OperationEnv section (universal composition, three dispatch paths, service assembly, Phase boundary), OperationContext struct, ResponseEnvelope/CallError types, irpc-as-one-backend positioning, Phase 1 local-only constraint, agent service pattern clarified as downstream concern, ADRs 028/033 added, references to identity.md/interface.md/services.md added. ## Summary -> To be filled on completion \ No newline at end of file +Call protocol spec updated with OperationEnv, three dispatch paths, OperationContext, and clear irpc positioning. All acceptance criteria met. \ No newline at end of file diff --git a/tasks/architecture/spec-update-napi.md b/tasks/architecture/spec-update-napi.md index 2c42b44..2f7bd50 100644 --- a/tasks/architecture/spec-update-napi.md +++ b/tasks/architecture/spec-update-napi.md @@ -1,7 +1,7 @@ --- id: architecture/spec-update-napi name: Update napi-and-pubsub.md — add reload API and call protocol references -status: pending +status: completed depends_on: - architecture/spec-configuration - architecture/adr-033-operationenv-irpc-call-protocol @@ -43,8 +43,8 @@ The current spec is reviewed and stable. Changes are additive: ## Notes -> To be filled by implementation agent +Added reload API (reloadAuth, reloadForwarding, reloadAll with ForwardingPolicyConfig and ForwardingRuleConfig interfaces), call protocol integration note, irpc service creation note (Phase 2+), ADR-030 reference, and references to configuration.md, services.md, call-protocol.md. ## Summary -> To be filled on completion \ No newline at end of file +NAPI spec updated with dynamic config reload API per ADR-030. All acceptance criteria met. \ No newline at end of file diff --git a/tasks/architecture/spec-update-overview.md b/tasks/architecture/spec-update-overview.md index 260ca29..cfd3ef0 100644 --- a/tasks/architecture/spec-update-overview.md +++ b/tasks/architecture/spec-update-overview.md @@ -1,7 +1,7 @@ --- id: architecture/spec-update-overview name: Update overview.md — add crate structure, Layer 3, services, identity -status: pending +status: completed depends_on: - architecture/adr-027-crate-decomposition - architecture/adr-026-transport-interface-separation @@ -48,8 +48,8 @@ The existing content (purpose, SSH tunneling, transport pluggability, etc.) stay ## Notes -> To be filled by implementation agent +Added crate structure table (6 crates, phase notes), three-layer model section, service layer section with Phase boundary note, Identity section with struct definition, expanded exports list, rebuilt dependency table per-crate, added 8 new architecture constraints (three-layer model, event boundary, OperationEnv, forwarding policy, static/dynamic config, unified auth, config split), expanded ADR table from 19 to 31 entries, updated references to include all new specs + irpc. ## Summary -> To be filled on completion \ No newline at end of file +Overview spec updated from alpha scope to full Phase 0 scope. All acceptance criteria met. \ No newline at end of file diff --git a/tasks/architecture/spec-update-server.md b/tasks/architecture/spec-update-server.md index 777ac7e..06c9737 100644 --- a/tasks/architecture/spec-update-server.md +++ b/tasks/architecture/spec-update-server.md @@ -1,7 +1,7 @@ --- id: architecture/spec-update-server name: Update server.md — add DynamicConfig, ForwardingPolicy, IdentityProvider references -status: pending +status: completed depends_on: - architecture/adr-030-static-dynamic-config-split - architecture/adr-031-forwarding-policy @@ -56,8 +56,8 @@ The current server.md is thorough but reflects the alpha architecture where auth ## Notes -> To be filled by implementation agent +Rewrote Authentication section around IdentityProvider trait with Phase 1/Phase 2 boundary. Added ForwardingPolicy check before proxy spawn. Added Interface Abstraction section (ServerHandler → SshInterface refactoring). Added --config flag and [[listeners]] TOML to CLI section. Softened single-transport constraint. Added ADRs 026/028/029/030/031 to design decisions and references section. ## Summary -> To be filled on completion \ No newline at end of file +Server spec updated for IdentityProvider, ForwardingPolicy, DynamicConfig, and Interface abstraction. Phase 1 boundary clear. All acceptance criteria met. \ No newline at end of file