alkdev/alknet
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vault: change unlock_new return type to Zeroizing<String> (task: vault/unlock-new-zeroizing-return)

Browse Source 
Drift item #8: the mnemonic phrase is the root of trust — it must not linger in
freed heap memory. Changed unlock_new return from String to Zeroizing<String>
(zeroized on drop). Existing tests work via Deref coercion.

Refs: docs/architecture/crates/vault/README.md drift #8
Implements: ADR-025 (resolves W7)
This commit is contained in:
glm-5.2
2026-06-23 13:33:55 +00:00
parent aec4bc9b87 685413dee4
commit ad1174b485
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
crates/alknet-vault/src/service.rs
View File

@@ -47,6 +47,7 @@ use crate::derivation::{self, DerivationError, PATHS};
use crate::encryption::{self, EncryptedData, EncryptionKey}; use crate::encryption::{self, EncryptedData, EncryptionKey};
use crate::mnemonic::{Language, Mnemonic, Seed}; use crate::mnemonic::{Language, Mnemonic, Seed};
use crate::protocol::{DerivedKey, KeyType}; use crate::protocol::{DerivedKey, KeyType};
use zeroize::Zeroizing;
/// Handle to a running VaultService for local (in-process) use. /// Handle to a running VaultService for local (in-process) use.
/// ///
@@ -147,7 +148,7 @@ impl VaultServiceHandle {
/// ///
/// Returns the generated mnemonic phrase. Store this phrase securely — /// Returns the generated mnemonic phrase. Store this phrase securely —
/// it is the root of trust for all derived keys. /// it is the root of trust for all derived keys.
pub fn unlock_new(&self, word_count: usize) -> Result<String, VaultServiceError> { pub fn unlock_new(&self, word_count: usize) -> Result<Zeroizing<String>, VaultServiceError> {
let mut inner = self.inner.write().unwrap(); let mut inner = self.inner.write().unwrap();
if inner.unlocked { if inner.unlocked {
return Err(VaultServiceError::AlreadyUnlocked); return Err(VaultServiceError::AlreadyUnlocked);
@@ -155,7 +156,7 @@ impl VaultServiceHandle {
let mnemonic = Mnemonic::generate(word_count)?; let mnemonic = Mnemonic::generate(word_count)?;
let seed = mnemonic.to_seed(None); let seed = mnemonic.to_seed(None);
let phrase = mnemonic.phrase().to_string(); let phrase = Zeroizing::new(mnemonic.phrase().to_string());
inner.mnemonic = Some(mnemonic); inner.mnemonic = Some(mnemonic);
inner.seed = Some(seed); inner.seed = Some(seed);