From bf868157d327634b17f30503e6d368bdcf5d3ff2 Mon Sep 17 00:00:00 2001 From: "glm-5.2" Date: Tue, 21 Jul 2026 10:40:43 +0000 Subject: [PATCH] fix(typedef): resolve pre-existing clippy warnings in test code - sequential_reader.rs: change test helper write_u32/write_string param from &mut Vec to &mut [u8] (clippy::ptr_arg) - validation.rs: replace 3.14/2.71 with 3.5/2.5 in test instances to avoid clippy::approx_constant (f32::consts::PI approximation) --- crates/alknet-typedef/src/sequential_reader.rs | 4 ++-- crates/alknet-typedef/src/validation.rs | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/alknet-typedef/src/sequential_reader.rs b/crates/alknet-typedef/src/sequential_reader.rs index 060d00e..1710bf2 100644 --- a/crates/alknet-typedef/src/sequential_reader.rs +++ b/crates/alknet-typedef/src/sequential_reader.rs @@ -852,7 +852,7 @@ mod tests { const LE: Endian = Endian::Little; const BE: Endian = Endian::Big; - fn write_u32(buf: &mut Vec, offset: usize, value: u32, endian: Endian) { + fn write_u32(buf: &mut [u8], offset: usize, value: u32, endian: Endian) { let bytes = match endian { Endian::Little => value.to_le_bytes(), Endian::Big => value.to_be_bytes(), @@ -860,7 +860,7 @@ mod tests { buf[offset..offset + 4].copy_from_slice(&bytes); } - fn write_string(buf: &mut Vec, offset: usize, value: &str, endian: Endian) -> usize { + fn write_string(buf: &mut [u8], offset: usize, value: &str, endian: Endian) -> usize { let bytes = value.as_bytes(); let total = 4 + bytes.len(); write_u32(buf, offset, bytes.len() as u32, endian); diff --git a/crates/alknet-typedef/src/validation.rs b/crates/alknet-typedef/src/validation.rs index 8029cf6..1b95fee 100644 --- a/crates/alknet-typedef/src/validation.rs +++ b/crates/alknet-typedef/src/validation.rs @@ -605,7 +605,7 @@ mod tests { let validator = validator_for(&schema); let instance = json!({ "id": 42, - "score": 3.14, + "score": 3.5, "flag": 1, "count": 1000 }); @@ -688,7 +688,7 @@ mod tests { "required": ["f32", "f64"] }); let validator = validator_for(&schema); - assert!(validator.is_valid(&json!({"f32": 3.14, "f64": 2.71}))); + assert!(validator.is_valid(&json!({"f32": 3.5, "f64": 2.5}))); assert!(validator.is_valid(&json!({"f32": 0, "f64": 0}))); assert!(!validator.is_valid(&json!({"f32": "x", "f64": 0}))); }