tasks: add 5 cleanup tasks from Phase 1 review, mark review complete
Review found Phase 1 approved with minor issues. Created cleanup tasks: - napi-identity-provider-wiring (bug: NAPI bypasses IdentityProvider) - panic-free-static-config (code smell: panic/unwrap in production path) - non-exhaustive-public-api (future-proofing public API types) - adr-doc-comments (doc convention: ADR references in new modules) - ssh-session-recv-stub-doc (documentation: mark stubs as planned)
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
---
|
||||
id: review/phase1-core-modifications
|
||||
name: Review Phase 1 core modifications — config split, identity, forwarding, OperationEnv, interface abstraction
|
||||
status: pending
|
||||
status: completed
|
||||
depends_on:
|
||||
- core/ssh-interface-extraction
|
||||
- core/operationenv-local-dispatch
|
||||
@@ -55,8 +55,8 @@ Review the Phase 1 core modifications after all implementation tasks are complet
|
||||
|
||||
## Notes
|
||||
|
||||
> To be filled by review agent
|
||||
> Review completed by code-reviewer agent. All 13 checklist items passed. 5 warnings identified (W1: NAPI bypasses IdentityProvider = functional bug with cleanup task created; W2: task notes unfilled = by design; W3: SshSession::recv() stub = documented as future work with cleanup task; W4: ServerAuthConfig bridge = acceptable transition debt; W5: panic/unwrap in StaticConfig = code smell with cleanup task created). 4 non-blocking suggestions also generated cleanup tasks.
|
||||
|
||||
## Summary
|
||||
|
||||
> To be filled on completion
|
||||
Phase 1 core modifications approved with minor changes recommended. 385 tests pass, all feature flags compile, clippy clean. All ADRs 026-034 correctly reflected. Main concern: NAPI handler bypasses IdentityProvider/ForwardingPolicy (cleanup task created). 5 cleanup tasks created to address warnings and suggestions before proceeding to Phase 2.
|
||||
Reference in New Issue
Block a user