11 Commits

Author SHA1 Message Date
c58eccd5a6 feat(call/protocol/dispatch-streaming-branch): branch handle_stream on op_type; Subscription → invoke_streaming → pump each → call.completed
Add DispatchResult::Once|Stream enum and Dispatcher::dispatch() that branches
on the registered op_type (ADR-049 §6): Query/Mutation → invoke() (unchanged
Once path), Subscription → invoke_streaming() (Stream path). handle_stream
matches on DispatchResult: the Once path writes one call.responded/call.error
frame (no call.completed); the Stream path pumps each ResponseEnvelope to the
wire via pump_stream (ResponseEnvelope.into() → call.responded for Ok,
call.error for Err), then writes call.completed on natural stream end. An Err
envelope is terminal — last_was_error suppresses call.completed after an error.
The streaming branch clears context.deadline to None (subscriptions are
unbounded — ADR-049 §6, call-protocol Timeouts). Abort (ADR-016) needs no new
code: handle_abort removes the pending entry and dropping the pump task
releases handler resources via Drop. dispatch_requested delegates to dispatch
for backward compatibility with existing callers.
2026-07-02 09:56:05 +00:00
62bebe5122 docs(http): mark http/adapters/from-openapi-sse-streaming completed — SSE streaming forwarding 2026-07-02 09:48:39 +00:00
a1e4752fdf Merge branch 'feat/http/adapters/from-openapi-sse-streaming' into develop 2026-07-02 09:48:07 +00:00
6f05dd8995 feat(http/adapters/from-openapi-sse-streaming): branch from_openapi forwarding on op_type; Subscription → StreamingHandler (SSE → BoxStream<ResponseEnvelope>)
build_registration now branches on op_type: Subscription ops register a
StreamingHandler (HandlerKind::Stream) via make_streaming_handler that
streams SSE response chunks as ResponseEnvelope::ok() items (one per
data: frame); Query/Mutation ops keep the existing Handler
(HandlerKind::Once) via forward(). Closes the gap where a from_openapi-
imported Subscription returned only the last SSE event.

- forward_stream(): non-async fn returning ResponseStream; sends the
  request with Accept: text/event-stream, then streams SSE chunks via
  stream::unfold over response.bytes_stream(), reusing parse_sse_frames
  (multi-event, partial trailing, comments, multi-line data, BOM).
  HTTP error (non-2xx) → single ResponseEnvelope::error(), stream ends;
  SSE stream end → ResponseStream ends (→ call.completed on wire).
- Removed stream_subscription() (the collect-all placeholder that
  truncated to the last event). parse_sse_frames stays (reused).
- Query/Mutation forwarding unchanged (existing forward() path).
- Tests: Subscription registration is HandlerKind::Stream; Query
  registration is HandlerKind::Once; SSE subscription streams multiple
  ResponseEnvelope::ok() (one per data: frame); HTTP error → single
  error envelope; Query forwarding unchanged (single response).
2026-07-02 09:45:55 +00:00
d841cc35b9 docs(call): mark call/client/from-call-streaming-forwarding completed — streaming forwarding handler 2026-07-02 09:45:48 +00:00
5c37e5b3af Merge branch 'feat/call/client/from-call-streaming-forwarding' into develop 2026-07-02 09:45:29 +00:00
67b1adba98 feat(call/client/from-call-streaming-forwarding): branch from_call forwarding on op_type
Subscription ops discovered via services/list + services/schema now
register a StreamingHandler (HandlerKind::Stream) that calls
CallConnection::subscribe_with_payload and forwards the remote stream
end-to-end (ADR-049 §8). Query/Mutation ops keep the existing
make_forwarding_handler (HandlerKind::Once).

- Add CallConnection::subscribe_with_payload(payload) mirroring
  call_with_payload so the forwarding handler can populate forwarded_for
  (ADR-032) + auth_token on the subscription payload. subscribe() now
  delegates to subscribe_with_payload.
- Add make_streaming_forwarding_handler() in from_call.rs using
  make_streaming_handler + futures::stream::once(...).flatten() to await
  subscribe_with_payload then forward its stream.
- Branch build_bundles on spec.op_type (already parsed by rebuild_spec_for).
- Reuse build_forwarded_payload — no new payload-construction code.
- composition_authority: None, scoped_env: None for FromCall streaming
  leaves (same as Query/Mutation FromCall leaves).
- Abort cascade (ADR-016 §6) already wired via PendingRequestMap in
  subscribe_with_payload.

Closes the gap where a from_call-imported Subscription truncated to the
first value.
2026-07-02 09:43:45 +00:00
f12e227df0 docs(call): mark call/registry/invoke-streaming completed — invoke_streaming() streaming dispatch 2026-07-02 09:41:59 +00:00
acaa0513e4 feat(call/registry): add OperationRegistry::invoke_streaming() returning ResponseStream
Streaming dispatch path for Subscription operations — counterpart to
invoke(). Same visibility + ACL checks (internal → handler_identity,
external → identity), then dispatches to the StreamingHandler. Pre-handler
errors (not-found, forbidden, INVALID_OPERATION_TYPE for non-Subscription
ops) yield a single error ResponseEnvelope via stream::once and end the
stream. Adds 6 unit tests covering dispatch, not-found, wrong-kind,
internal-from-external, ACL denied, and internal-call handler_identity ACL.

Refs ADR-049 §3, §5.
2026-07-02 09:39:31 +00:00
185ddb82b5 docs(call): mark call/registry/streaming-handler-handlerkind completed — StreamingHandler/HandlerKind foundation 2026-07-02 09:29:11 +00:00
9c81129f24 feat(call): introduce StreamingHandler, HandlerKind, ResponseStream + INVALID_OPERATION_TYPE (ADR-049)
Add the foundational types for ADR-049 streaming handlers:
- StreamingHandler, ResponseStream type aliases and HandlerKind enum
  (Once | Stream) in registration.rs, with make_streaming_handler() helper
- CallError::invalid_operation_type() in wire.rs (sixth protocol code,
  retryable: false)
- HandlerRegistration.handler flipped from Handler to HandlerKind;
  HandlerRegistration::new() now takes HandlerKind
- OperationRegistryBuilder absorbs wrapping: with_local/with_leaf/
  with_leaf_provenance wrap raw Handler in HandlerKind::Once for
  Query/Mutation; new with_local_streaming/with_leaf_streaming take a
  StreamingHandler and wrap in HandlerKind::Stream for Subscription.
  Builder validates kind matches spec.op_type (mismatch = startup error)
- OperationRegistry::register() returns Result<(), String> with a clear
  mismatch message; all call sites updated to handle the Result
- invoke() matches on HandlerKind: Once -> existing path; Stream ->
  INVALID_OPERATION_TYPE error envelope (guards against silent
  truncation; invoke_streaming() added in a downstream task)
- OverlayOperationEnv::invoke_with_policy matches on HandlerKind:
  Once -> dispatch; Stream -> INVALID_OPERATION_TYPE (composition is
  request/response-only)
- Migrated every HandlerRegistration::new() construction site (~95)
  to wrap raw Handler in HandlerKind::Once(handler); the builder sites
  are handled by the builder-absorbs-wrapping change
- Updated two websocket subscription tests that relied on Subscription
  ops dispatching via invoke() to expect INVALID_OPERATION_TYPE
- Added unit tests for invoke/register validation and
  make_streaming_handler
2026-07-02 09:28:05 +00:00
24 changed files with 2659 additions and 905 deletions

View File

@@ -572,7 +572,7 @@ mod tests {
use crate::protocol::connection::CallConnection; use crate::protocol::connection::CallConnection;
use crate::protocol::wire::ResponseEnvelope; use crate::protocol::wire::ResponseEnvelope;
use crate::registry::registration::{ use crate::registry::registration::{
make_handler, Handler, HandlerRegistration, OperationProvenance, make_handler, Handler, HandlerKind, HandlerRegistration, OperationProvenance,
}; };
use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::Identity; use alknet_core::auth::Identity;
@@ -640,14 +640,16 @@ mod tests {
fn registry_with_caps() -> Arc<OperationRegistry> { fn registry_with_caps() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("pub/run"), .register(HandlerRegistration::new(
caps_inspect_handler(), external_spec("pub/run"),
OperationProvenance::Local, HandlerKind::Once(caps_inspect_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new().with_api_key("google", "pub-key".to_string()), None,
)); Capabilities::new().with_api_key("google", "pub-key".to_string()),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -709,7 +711,9 @@ mod tests {
let client = CallClient::new(Arc::clone(&registry), Arc::new(NoopIdentityProvider)); let client = CallClient::new(Arc::clone(&registry), Arc::new(NoopIdentityProvider));
let conn = client.spawn_dispatch(stub_connection()); let conn = client.spawn_dispatch(stub_connection());
assert_eq!( assert_eq!(
conn.connection().expect("quic connection present").remote_alpn(), conn.connection()
.expect("quic connection present")
.remote_alpn(),
b"alknet/call" b"alknet/call"
); );
std::mem::drop(conn); std::mem::drop(conn);

View File

@@ -19,7 +19,9 @@ use crate::client::AdapterError;
use crate::protocol::connection::CallConnection; use crate::protocol::connection::CallConnection;
use crate::protocol::wire::ResponseEnvelope; use crate::protocol::wire::ResponseEnvelope;
use crate::registry::context::OperationContext; use crate::registry::context::OperationContext;
use crate::registry::registration::{Handler, HandlerRegistration, OperationProvenance}; use crate::registry::registration::{
Handler, HandlerKind, HandlerRegistration, OperationProvenance, StreamingHandler,
};
use crate::registry::spec::{ use crate::registry::spec::{
AccessControl, ErrorDefinition, OperationSpec, OperationType, Visibility, AccessControl, ErrorDefinition, OperationSpec, OperationType, Visibility,
}; };
@@ -121,14 +123,23 @@ fn build_bundles(
}); });
} }
let handler = make_forwarding_handler( let kind = match spec.op_type {
Arc::new(op_summary.connection.clone()), OperationType::Subscription => HandlerKind::Stream(make_streaming_forwarding_handler(
remote_name, Arc::new(op_summary.connection.clone()),
op_summary.credentials_auth_token.clone(), remote_name,
); op_summary.credentials_auth_token.clone(),
)),
OperationType::Query | OperationType::Mutation => {
HandlerKind::Once(make_forwarding_handler(
Arc::new(op_summary.connection.clone()),
remote_name,
op_summary.credentials_auth_token.clone(),
))
}
};
bundles.push(HandlerRegistration::new( bundles.push(HandlerRegistration::new(
spec, spec,
handler, kind,
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -309,8 +320,10 @@ fn parse_access_control(v: &Value) -> AccessControl {
} }
} }
/// Construct a forwarding handler for a `FromCall` leaf: on invocation, calls /// Construct a forwarding handler for a `FromCall` `Query`/`Mutation` leaf:
/// the remote op via the `CallConnection` and returns its `ResponseEnvelope`. /// on invocation, calls the remote op via the `CallConnection` and returns
/// its `ResponseEnvelope` (single `call_with_payload()`, `HandlerKind::Once`).
/// `Subscription` ops use [`make_streaming_forwarding_handler`] instead.
/// ///
/// Per ADR-032 §3, the handler populates `forwarded_for` on the /// Per ADR-032 §3, the handler populates `forwarded_for` on the
/// `call.requested` payload from the hub's `OperationContext.identity` (the /// `call.requested` payload from the hub's `OperationContext.identity` (the
@@ -323,12 +336,6 @@ fn parse_access_control(v: &Value) -> AccessControl {
/// If `context.identity` is `None` (the hub chose not to disclose, or has not /// If `context.identity` is `None` (the hub chose not to disclose, or has not
/// authenticated an originator), `forwarded_for` is omitted — the spoke /// authenticated an originator), `forwarded_for` is omitted — the spoke
/// receives only the hub's identity. /// receives only the hub's identity.
///
/// For a `Subscription` op, the handler calls `subscribe` and streams until
/// `completed`/`aborted` (the streaming path is exercised at the
/// `CallConnection` layer; the handler here forwards the first response for
/// query/mutation and delegates streaming to the caller via the returned
/// envelope).
fn make_forwarding_handler( fn make_forwarding_handler(
connection: Arc<CallConnection>, connection: Arc<CallConnection>,
remote_name: String, remote_name: String,
@@ -357,6 +364,40 @@ fn make_forwarding_handler(
}) })
} }
/// Construct a streaming forwarding handler for a `FromCall` `Subscription`
/// leaf: on invocation, calls `CallConnection::subscribe_with_payload()` and
/// forwards the remote stream end-to-end. Each `call.responded` from the
/// remote becomes a stream item, `call.completed` ends the stream, and
/// `call.aborted` drops it (ADR-049 §8). No truncation, no first-value
/// fallback.
///
/// `forwarded_for` is populated from `context.identity` (ADR-032 §3) and
/// `auth_token` from the hub's own call-protocol token, exactly as the
/// request/response forwarding handler does — both via `build_forwarded_payload`
/// (no new payload-construction code). The `subscribe_with_payload` path
/// registers the request in `PendingRequestMap`, so the abort cascade
/// (ADR-016 §6) is already wired: a parent abort drops the
/// `SubscriptionStream`, which sends `call.aborted` to the remote node.
fn make_streaming_forwarding_handler(
connection: Arc<CallConnection>,
remote_name: String,
credentials_auth_token: Option<String>,
) -> StreamingHandler {
use crate::registry::registration::make_streaming_handler;
use futures::stream::{once, StreamExt};
make_streaming_handler(move |input, context| {
let connection = Arc::clone(&connection);
let remote_name = remote_name.clone();
let auth_token = credentials_auth_token.clone();
once(async move {
let payload =
build_forwarded_payload(&remote_name, input, &context, auth_token.as_deref());
connection.subscribe_with_payload(payload).await
})
.flatten()
})
}
/// Build the `call.requested` payload for a forwarded call, populating /// Build the `call.requested` payload for a forwarded call, populating
/// `forwarded_for` from the hub's `OperationContext.identity` (ADR-032 §3). /// `forwarded_for` from the hub's `OperationContext.identity` (ADR-032 §3).
/// `forwarded_for` is omitted when `context.identity` is `None` (the hub /// `forwarded_for` is omitted when `context.identity` is `None` (the hub
@@ -389,7 +430,7 @@ fn build_forwarded_payload(
mod tests { mod tests {
use super::*; use super::*;
use crate::protocol::connection::CallConnection; use crate::protocol::connection::CallConnection;
use crate::registry::registration::make_handler; use crate::registry::registration::{make_handler, make_streaming_handler};
use crate::registry::spec::OperationType; use crate::registry::spec::OperationType;
use alknet_core::auth::Identity; use alknet_core::auth::Identity;
use alknet_core::types::{Capabilities, MockConnection}; use alknet_core::types::{Capabilities, MockConnection};
@@ -549,7 +590,7 @@ mod tests {
); );
let reg = HandlerRegistration::new( let reg = HandlerRegistration::new(
spec, spec,
handler, HandlerKind::Once(handler),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -722,6 +763,15 @@ mod tests {
} }
} }
fn op_summary_typed(name: &str, op_type: &str, conn: &CallConnection) -> OpSummary {
OpSummary {
name: name.to_string(),
schema: sample_schema_json(name, op_type),
connection: conn.clone(),
credentials_auth_token: None,
}
}
#[test] #[test]
fn build_bundles_same_peer_collision_returns_same_peer_collision_error() { fn build_bundles_same_peer_collision_returns_same_peer_collision_error() {
let conn = CallConnection::new(stub_connection()); let conn = CallConnection::new(stub_connection());
@@ -822,4 +872,234 @@ mod tests {
assert_eq!(bundles.len(), 1); assert_eq!(bundles.len(), 1);
assert_eq!(bundles[0].spec.name, "worker/exec"); assert_eq!(bundles[0].spec.name, "worker/exec");
} }
// --- ADR-049 §8: streaming forwarding for Subscription ops -------------
#[test]
fn build_bundles_subscription_op_produces_stream_kind() {
let conn = CallConnection::new(stub_connection());
let discovered = vec![op_summary_typed("events/stream", "subscription", &conn)];
let bundles = build_bundles(discovered, &None, &None).expect("bundles");
assert_eq!(bundles.len(), 1);
assert_eq!(bundles[0].spec.op_type, OperationType::Subscription);
assert!(
matches!(bundles[0].handler, HandlerKind::Stream(_)),
"Subscription op must register HandlerKind::Stream"
);
assert_eq!(bundles[0].provenance, OperationProvenance::FromCall);
assert!(bundles[0].composition_authority.is_none());
assert!(bundles[0].scoped_env.is_none());
}
#[test]
fn build_bundles_query_op_produces_once_kind() {
let conn = CallConnection::new(stub_connection());
let discovered = vec![op_summary_typed("fs/readFile", "query", &conn)];
let bundles = build_bundles(discovered, &None, &None).expect("bundles");
assert_eq!(bundles.len(), 1);
assert_eq!(bundles[0].spec.op_type, OperationType::Query);
assert!(
matches!(bundles[0].handler, HandlerKind::Once(_)),
"Query op must register HandlerKind::Once"
);
}
#[test]
fn build_bundles_mutation_op_produces_once_kind() {
let conn = CallConnection::new(stub_connection());
let discovered = vec![op_summary_typed("fs/writeFile", "mutation", &conn)];
let bundles = build_bundles(discovered, &None, &None).expect("bundles");
assert_eq!(bundles.len(), 1);
assert_eq!(bundles[0].spec.op_type, OperationType::Mutation);
assert!(
matches!(bundles[0].handler, HandlerKind::Once(_)),
"Mutation op must register HandlerKind::Once"
);
}
#[test]
fn build_bundles_mixed_op_types_route_to_correct_kind() {
let conn = CallConnection::new(stub_connection());
let discovered = vec![
op_summary_typed("fs/readFile", "query", &conn),
op_summary_typed("fs/writeFile", "mutation", &conn),
op_summary_typed("events/stream", "subscription", &conn),
];
let bundles = build_bundles(discovered, &None, &None).expect("bundles");
assert_eq!(bundles.len(), 3);
let by_name: std::collections::HashMap<&str, &HandlerKind> = bundles
.iter()
.map(|b| (b.spec.name.as_str(), &b.handler))
.collect();
assert!(matches!(by_name["fs/readFile"], HandlerKind::Once(_)));
assert!(matches!(by_name["fs/writeFile"], HandlerKind::Once(_)));
assert!(matches!(by_name["events/stream"], HandlerKind::Stream(_)));
}
/// Verify `make_streaming_forwarding_handler` produces a `StreamingHandler`
/// that builds the forwarded payload with `forwarded_for` populated from
/// `context.identity` (ADR-032) and calls `subscribe_with_payload`. Since
/// `subscribe_with_payload` on a mock connection returns a closed stream
/// (no transport), we capture the payload by intercepting the build step:
/// the handler's contract is "build payload via `build_forwarded_payload`,
/// then call `subscribe_with_payload(payload)`". We mirror the existing
/// `forwarding_handler_populates_forwarded_for` test by constructing the
/// handler and exercising the payload-construction path it relies on, plus
/// asserting the produced stream terminates (the mock-connection path
/// yields one error envelope then ends — no truncation, no hang).
#[tokio::test]
async fn streaming_forwarding_handler_populates_forwarded_for_and_streams() {
use futures::stream::StreamExt;
let conn = Arc::new(CallConnection::new(stub_connection()));
let captured_payload = Arc::new(StdMutex::new(None::<Value>));
let captured = Arc::clone(&captured_payload);
let handler: StreamingHandler = {
let conn = Arc::clone(&conn);
make_streaming_handler(move |input, context| {
let conn = Arc::clone(&conn);
let captured = Arc::clone(&captured);
let remote_name = "events/stream".to_string();
use futures::stream::{once, StreamExt};
once(async move {
let payload = build_forwarded_payload(&remote_name, input, &context, None);
*captured.lock().unwrap() = Some(payload.clone());
conn.subscribe_with_payload(payload).await
})
.flatten()
})
};
let ctx = test_context(Some(alice_identity()));
let mut stream = handler(json!({}), ctx);
let first = stream.next().await;
assert!(
first.is_some(),
"streaming forwarding handler must produce at least one envelope"
);
if let Some(env) = first {
assert!(
env.result.is_err(),
"mock connection has no transport, so the stream yields an error envelope"
);
}
let second = stream.next().await;
assert!(
second.is_none(),
"stream must terminate after the error (no truncation, no hang)"
);
let payload = captured_payload.lock().unwrap().clone().expect("captured");
assert_eq!(payload["operationId"], "events/stream");
assert_eq!(payload["forwarded_for"]["id"], "alice");
}
/// The streaming forwarding handler omits `forwarded_for` when
/// `context.identity` is `None`, mirroring the request/response handler.
#[tokio::test]
async fn streaming_forwarding_handler_omits_forwarded_for_when_identity_none() {
use futures::stream::StreamExt;
let conn = Arc::new(CallConnection::new(stub_connection()));
let captured_payload = Arc::new(StdMutex::new(None::<Value>));
let captured = Arc::clone(&captured_payload);
let handler: StreamingHandler = {
let conn = Arc::clone(&conn);
make_streaming_handler(move |input, context| {
let conn = Arc::clone(&conn);
let captured = Arc::clone(&captured);
let remote_name = "events/stream".to_string();
use futures::stream::{once, StreamExt};
once(async move {
let payload = build_forwarded_payload(&remote_name, input, &context, None);
*captured.lock().unwrap() = Some(payload.clone());
conn.subscribe_with_payload(payload).await
})
.flatten()
})
};
let ctx = test_context(None);
let mut stream = handler(json!({}), ctx);
let _ = stream.next().await;
let payload = captured_payload.lock().unwrap().clone().expect("captured");
assert!(
payload.get("forwarded_for").is_none(),
"forwarded_for must be omitted when context.identity is None"
);
assert_eq!(payload["operationId"], "events/stream");
}
/// The streaming forwarding handler populates `auth_token` when the hub's
/// own call-protocol token is provided.
#[tokio::test]
async fn streaming_forwarding_handler_sets_auth_token_when_provided() {
use futures::stream::StreamExt;
let conn = Arc::new(CallConnection::new(stub_connection()));
let captured_payload = Arc::new(StdMutex::new(None::<Value>));
let captured = Arc::clone(&captured_payload);
let handler: StreamingHandler = {
let conn = Arc::clone(&conn);
make_streaming_handler(move |input, context| {
let conn = Arc::clone(&conn);
let captured = Arc::clone(&captured);
let remote_name = "events/stream".to_string();
use futures::stream::{once, StreamExt};
once(async move {
let payload = build_forwarded_payload(
&remote_name,
input,
&context,
Some("alk_hub_token"),
);
*captured.lock().unwrap() = Some(payload.clone());
conn.subscribe_with_payload(payload).await
})
.flatten()
})
};
let ctx = test_context(Some(alice_identity()));
let mut stream = handler(json!({}), ctx);
let _ = stream.next().await;
let payload = captured_payload.lock().unwrap().clone().expect("captured");
assert_eq!(payload["auth_token"], "alk_hub_token");
assert_eq!(payload["forwarded_for"]["id"], "alice");
}
/// `make_streaming_forwarding_handler` produces a `StreamingHandler` (not a
/// `Handler`) — verifies the helper returns the right type and that
/// `build_bundles` wires it into `HandlerKind::Stream`.
#[test]
fn make_streaming_forwarding_handler_returns_streaming_handler() {
let handler = make_streaming_forwarding_handler(
Arc::new(CallConnection::new(stub_connection())),
"events/stream".to_string(),
None,
);
let reg = HandlerRegistration::new(
OperationSpec::new(
"events/stream",
OperationType::Subscription,
Visibility::External,
json!({}),
json!({}),
vec![],
AccessControl::default(),
),
HandlerKind::Stream(handler),
OperationProvenance::FromCall,
None,
None,
Capabilities::new(),
);
assert!(matches!(reg.handler, HandlerKind::Stream(_)));
assert_eq!(reg.provenance, OperationProvenance::FromCall);
assert!(reg.composition_authority.is_none());
assert!(reg.scoped_env.is_none());
}
} }

View File

@@ -11,7 +11,9 @@ use serde_json::Value;
use crate::client::{AdapterError, OperationAdapter}; use crate::client::{AdapterError, OperationAdapter};
use crate::protocol::wire::{CallError, ResponseEnvelope}; use crate::protocol::wire::{CallError, ResponseEnvelope};
use crate::registry::context::OperationContext; use crate::registry::context::OperationContext;
use crate::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use crate::registry::registration::{
make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
};
use crate::registry::spec::OperationSpec; use crate::registry::spec::OperationSpec;
/// Build a [`HandlerRegistration`] from a JSON Schema-described operation. /// Build a [`HandlerRegistration`] from a JSON Schema-described operation.
@@ -30,7 +32,7 @@ pub fn from_jsonschema(spec: OperationSpec, _schema: Value) -> HandlerRegistrati
}); });
HandlerRegistration::new( HandlerRegistration::new(
spec, spec,
handler, HandlerKind::Once(handler),
OperationProvenance::FromJsonSchema, OperationProvenance::FromJsonSchema,
None, None,
None, None,
@@ -138,7 +140,10 @@ mod tests {
async fn placeholder_handler_returns_error_when_invoked() { async fn placeholder_handler_returns_error_when_invoked() {
let bundle = from_jsonschema_fn::from_jsonschema(test_spec("ns/op"), serde_json::json!({})); let bundle = from_jsonschema_fn::from_jsonschema(test_spec("ns/op"), serde_json::json!({}));
let ctx = test_context("req-1"); let ctx = test_context("req-1");
let response = (bundle.handler)(serde_json::json!({}), ctx).await; let response = match &bundle.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
match response.result { match response.result {
Err(e) => { Err(e) => {
assert_eq!(e.code, "NOT_FOUND"); assert_eq!(e.code, "NOT_FOUND");

View File

@@ -166,7 +166,9 @@ mod tests {
}; };
use crate::registry::context::{AbortPolicy, OperationContext, ScopedPeerEnv}; use crate::registry::context::{AbortPolicy, OperationContext, ScopedPeerEnv};
use crate::registry::env::OperationEnv; use crate::registry::env::OperationEnv;
use crate::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use crate::registry::registration::{
make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
};
use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::AuthToken; use alknet_core::auth::AuthToken;
use alknet_core::types::Capabilities; use alknet_core::types::Capabilities;
@@ -245,22 +247,24 @@ mod tests {
handler: crate::registry::registration::Handler, handler: crate::registry::registration::Handler,
) -> Arc<OperationRegistry> { ) -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
OperationSpec::new( .register(HandlerRegistration::new(
name, OperationSpec::new(
OperationType::Query, name,
visibility, OperationType::Query,
serde_json::json!({}), visibility,
serde_json::json!({}), serde_json::json!({}),
vec![], serde_json::json!({}),
acl, vec![],
), acl,
handler, ),
OperationProvenance::Local, HandlerKind::Once(handler),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -421,14 +425,16 @@ mod tests {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
let scoped = ScopedPeerEnv::new(["fs/readFile"]); let scoped = ScopedPeerEnv::new(["fs/readFile"]);
let caps = Capabilities::new().with_api_key("google", "k".to_string()); let caps = Capabilities::new().with_api_key("google", "k".to_string());
registry.register(HandlerRegistration::new( registry
external_spec("agent/run", AccessControl::default()), .register(HandlerRegistration::new(
echo_handler(), external_spec("agent/run", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
Some(scoped.clone()), None,
caps.clone(), Some(scoped.clone()),
)); caps.clone(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let adapter = CallAdapter::new(registry, provider); let adapter = CallAdapter::new(registry, provider);
@@ -543,7 +549,7 @@ mod tests {
vec![], vec![],
AccessControl::default(), AccessControl::default(),
), ),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -610,7 +616,7 @@ mod tests {
vec![], vec![],
AccessControl::default(), AccessControl::default(),
), ),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,

View File

@@ -26,7 +26,7 @@ use super::wire::{
use crate::protocol::wire::ResponseEnvelope; use crate::protocol::wire::ResponseEnvelope;
use crate::registry::context::{generate_request_id, AbortPolicy, OperationContext, ScopedPeerEnv}; use crate::registry::context::{generate_request_id, AbortPolicy, OperationContext, ScopedPeerEnv};
use crate::registry::env::OperationEnv; use crate::registry::env::OperationEnv;
use crate::registry::registration::{Handler, HandlerRegistration}; use crate::registry::registration::{HandlerKind, HandlerRegistration};
use crate::registry::spec::AccessResult; use crate::registry::spec::AccessResult;
const DEFAULT_CALL_TIMEOUT: Duration = Duration::from_secs(30); const DEFAULT_CALL_TIMEOUT: Duration = Duration::from_secs(30);
@@ -168,11 +168,26 @@ impl CallConnection {
operation_id: &str, operation_id: &str,
input: Value, input: Value,
) -> impl Stream<Item = ResponseEnvelope> { ) -> impl Stream<Item = ResponseEnvelope> {
let request_id = generate_request_id();
let payload = serde_json::json!({ let payload = serde_json::json!({
"operationId": operation_id, "operationId": operation_id,
"input": input, "input": input,
}); });
self.subscribe_with_payload(payload).await
}
/// Subscribe to a remote op with a caller-constructed `call.requested`
/// payload. The payload MUST include `operationId` and `input`; the
/// caller may add `forwarded_for` (ADR-032) and `auth_token` (ADR-017 §7)
/// for the hub forwarding path used by `from_call`'s streaming forwarding
/// handler. Mirrors [`call_with_payload`](Self::call_with_payload) so the
/// forwarding handler can populate `forwarded_for` + `auth_token` on the
/// subscription payload (the plain [`subscribe`](Self::subscribe) builds
/// the payload internally and omits those fields).
pub async fn subscribe_with_payload(
&self,
payload: Value,
) -> impl Stream<Item = ResponseEnvelope> {
let request_id = generate_request_id();
let connection = match &self.connection { let connection = match &self.connection {
Some(c) => c, Some(c) => c,
@@ -307,7 +322,7 @@ impl OperationEnv for OverlayOperationEnv {
return ResponseEnvelope::not_found(parent.request_id.clone(), &name); return ResponseEnvelope::not_found(parent.request_id.clone(), &name);
} }
let handler: Handler; let handler: HandlerKind;
let composition_authority; let composition_authority;
let scoped_env; let scoped_env;
let access_control; let access_control;
@@ -316,7 +331,7 @@ impl OperationEnv for OverlayOperationEnv {
let Some(registration) = overlay.get(&name) else { let Some(registration) = overlay.get(&name) else {
return ResponseEnvelope::not_found(parent.request_id.clone(), &name); return ResponseEnvelope::not_found(parent.request_id.clone(), &name);
}; };
handler = Arc::clone(&registration.handler); handler = registration.handler.clone();
composition_authority = registration.composition_authority.clone(); composition_authority = registration.composition_authority.clone();
scoped_env = registration scoped_env = registration
.scoped_env .scoped_env
@@ -355,7 +370,15 @@ impl OperationEnv for OverlayOperationEnv {
internal: true, internal: true,
}; };
handler(input, context).await match handler {
HandlerKind::Once(h) => h(input, context).await,
HandlerKind::Stream(_) => ResponseEnvelope::error(
parent.request_id.clone(),
CallError::invalid_operation_type(
"OperationEnv::invoke() called on a Subscription op; composition is request/response-only",
),
),
}
} }
fn contains(&self, name: &str) -> bool { fn contains(&self, name: &str) -> bool {
@@ -421,7 +444,7 @@ impl Stream for SubscriptionStream {
mod tests { mod tests {
use super::*; use super::*;
use crate::registry::context::CompositionAuthority; use crate::registry::context::CompositionAuthority;
use crate::registry::registration::{make_handler, OperationProvenance}; use crate::registry::registration::{make_handler, Handler, HandlerKind, OperationProvenance};
use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::types::{Capabilities, MockConnection}; use alknet_core::types::{Capabilities, MockConnection};
use std::collections::HashMap; use std::collections::HashMap;
@@ -476,7 +499,7 @@ mod tests {
fn imported_registration(name: &str) -> HandlerRegistration { fn imported_registration(name: &str) -> HandlerRegistration {
HandlerRegistration::new( HandlerRegistration::new(
external_spec(name), external_spec(name),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -608,7 +631,7 @@ mod tests {
}); });
conn.register_imported(HandlerRegistration::new( conn.register_imported(HandlerRegistration::new(
external_spec("worker/exec"), external_spec("worker/exec"),
inspect_handler, HandlerKind::Once(inspect_handler),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -631,7 +654,9 @@ mod tests {
fn connection_accessor_returns_underlying_connection() { fn connection_accessor_returns_underlying_connection() {
let conn = CallConnection::new(stub_connection()); let conn = CallConnection::new(stub_connection());
assert_eq!( assert_eq!(
conn.connection().expect("quic connection present").remote_alpn(), conn.connection()
.expect("quic connection present")
.remote_alpn(),
b"alknet/call" b"alknet/call"
); );
} }
@@ -960,4 +985,39 @@ mod tests {
assert!(conn.connection().is_some(), "QUIC connection present"); assert!(conn.connection().is_some(), "QUIC connection present");
assert!(conn.identity().is_none(), "no identity set yet"); assert!(conn.identity().is_none(), "no identity set yet");
} }
#[tokio::test]
async fn overlay_env_invoke_on_stream_kind_returns_invalid_operation_type() {
use crate::registry::registration::make_streaming_handler;
let conn = CallConnection::new(stub_connection());
let streaming_handler = make_streaming_handler(|input, ctx| {
futures::stream::iter(vec![ResponseEnvelope::ok(ctx.request_id, input)])
});
conn.register_imported(HandlerRegistration::new(
OperationSpec::new(
"events/stream",
OperationType::Subscription,
Visibility::External,
serde_json::json!({}),
serde_json::json!({}),
vec![],
AccessControl::default(),
),
HandlerKind::Stream(streaming_handler),
OperationProvenance::FromCall,
None,
None,
Capabilities::new(),
));
let env = conn.overlay_env();
let scoped = ScopedPeerEnv::new(["events/stream"]);
let ctx = root_context("root-stream", scoped, env.clone());
let response = env
.invoke("events", "stream", serde_json::json!({}), &ctx)
.await;
match response.result {
Err(e) => assert_eq!(e.code, "INVALID_OPERATION_TYPE"),
other => panic!("expected INVALID_OPERATION_TYPE, got {other:?}"),
}
}
} }

View File

@@ -17,6 +17,7 @@ use std::time::{Duration, Instant};
use alknet_core::auth::{AuthToken, Identity, IdentityProvider}; use alknet_core::auth::{AuthToken, Identity, IdentityProvider};
use alknet_core::types::StreamError; use alknet_core::types::StreamError;
use futures::stream::StreamExt;
use serde_json::Value; use serde_json::Value;
use tokio::task::JoinHandle; use tokio::task::JoinHandle;
use tracing::{debug, warn}; use tracing::{debug, warn};
@@ -30,11 +31,37 @@ use super::wire::{
use crate::protocol::adapter::SessionOverlaySource; use crate::protocol::adapter::SessionOverlaySource;
use crate::registry::context::{AbortPolicy, OperationContext, ScopedPeerEnv}; use crate::registry::context::{AbortPolicy, OperationContext, ScopedPeerEnv};
use crate::registry::env::{LocalOperationEnv, OperationEnv, PeerCompositeEnv}; use crate::registry::env::{LocalOperationEnv, OperationEnv, PeerCompositeEnv};
use crate::registry::registration::OperationRegistry; use crate::registry::registration::{OperationRegistry, ResponseStream};
use crate::registry::spec::OperationType;
const DEFAULT_TIMEOUT: Duration = Duration::from_secs(30); const DEFAULT_TIMEOUT: Duration = Duration::from_secs(30);
const SWEEPER_INTERVAL: Duration = Duration::from_secs(10); const SWEEPER_INTERVAL: Duration = Duration::from_secs(10);
/// Outcome of dispatching a `call.requested` event. The dispatcher branches on
/// the registered operation's `op_type` (ADR-049 §6): `Query`/`Mutation` produce
/// a single [`ResponseEnvelope`] (`Once`), `Subscription` produces a
/// [`ResponseStream`] (`Stream`) that `handle_stream` pumps to the wire.
///
/// This enum is the branch point the spec describes ("branches on `op_type` in
/// `handle_stream`"): `dispatch` returns it and `handle_stream` matches on it,
/// keeping the Once path (one frame, no `call.completed`) and the Stream path
/// (each envelope → frame, `call.completed` on natural end) visibly distinct.
pub enum DispatchResult {
Once(ResponseEnvelope),
Stream(ResponseStream),
}
impl std::fmt::Debug for DispatchResult {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match self {
DispatchResult::Once(env) => f.debug_tuple("Once").field(env).finish(),
DispatchResult::Stream(_) => {
f.debug_tuple("Stream").field(&"<ResponseStream>").finish()
}
}
}
}
/// Shared dispatcher for an established `CallConnection`. Constructed by /// Shared dispatcher for an established `CallConnection`. Constructed by
/// both `CallAdapter` (accept path) and `CallClient` (connect path) and used /// both `CallAdapter` (accept path) and `CallClient` (connect path) and used
/// to run the dispatch loop. Holds no per-connection state; the /// to run the dispatch loop. Holds no per-connection state; the
@@ -166,6 +193,36 @@ impl Dispatcher {
request_id: String, request_id: String,
payload: Value, payload: Value,
) -> ResponseEnvelope { ) -> ResponseEnvelope {
match self.dispatch(connection, request_id, payload).await {
DispatchResult::Once(envelope) => envelope,
DispatchResult::Stream(mut stream) => stream.next().await.unwrap_or_else(|| {
ResponseEnvelope::error(
String::new(),
CallError::internal(
"dispatch_requested called on a Subscription op; use the streaming path",
),
)
}),
}
}
/// Dispatch a `call.requested` event, branching on the registered
/// operation's `op_type` (ADR-049 §6). `Query`/`Mutation` → `invoke()` →
/// [`DispatchResult::Once`]; `Subscription` → `invoke_streaming()` →
/// [`DispatchResult::Stream`]. Unknown ops and ACL failures resolve via
/// the registry's own envelope/error paths (Once for `invoke`, a single
/// error envelope for `invoke_streaming`).
///
/// For the streaming branch the root context's deadline is cleared
/// (`deadline: None`): subscriptions are long-running and unbounded — the
/// 30s request/response deadline does not apply (ADR-049 §6, call-protocol
/// Timeouts). The Once branch keeps the deadline from `build_root_context`.
pub async fn dispatch(
&self,
connection: &Arc<CallConnection>,
request_id: String,
payload: Value,
) -> DispatchResult {
let operation_id = payload let operation_id = payload
.get("operationId") .get("operationId")
.and_then(|v| v.as_str()) .and_then(|v| v.as_str())
@@ -180,7 +237,13 @@ impl Dispatcher {
let input = payload.get("input").cloned().unwrap_or(Value::Null); let input = payload.get("input").cloned().unwrap_or(Value::Null);
let context = self.build_root_context( let is_subscription = self
.registry
.registration(&operation_name)
.map(|r| r.spec.op_type == OperationType::Subscription)
.unwrap_or(false);
let mut context = self.build_root_context(
request_id.clone(), request_id.clone(),
&operation_name, &operation_name,
identity, identity,
@@ -188,7 +251,16 @@ impl Dispatcher {
connection, connection,
); );
self.registry.invoke(&operation_name, input, context).await if is_subscription {
context.deadline = None;
let stream = self
.registry
.invoke_streaming(&operation_name, input, context);
DispatchResult::Stream(stream)
} else {
let envelope = self.registry.invoke(&operation_name, input, context).await;
DispatchResult::Once(envelope)
}
} }
pub async fn handle_abort(&self, connection: &Arc<CallConnection>, request_id: &str) { pub async fn handle_abort(&self, connection: &Arc<CallConnection>, request_id: &str) {
@@ -225,14 +297,20 @@ impl Dispatcher {
let request_id = envelope.id.clone(); let request_id = envelope.id.clone();
let payload = envelope.payload.clone(); let payload = envelope.payload.clone();
let response = self match self
.dispatch_requested(&connection, request_id.clone(), payload) .dispatch(&connection, request_id.clone(), payload)
.await; .await
{
let event: EventEnvelope = response.into(); DispatchResult::Once(response) => {
if let Err(err) = writer.write_frame(&event).await { let event: EventEnvelope = response.into();
warn!(error = %err, "failed to write response frame; closing stream"); if let Err(err) = writer.write_frame(&event).await {
break; warn!(error = %err, "failed to write response frame; closing stream");
break;
}
}
DispatchResult::Stream(stream) => {
self.pump_stream(&mut writer, &request_id, stream).await;
}
} }
} }
EVENT_ABORTED => { EVENT_ABORTED => {
@@ -246,6 +324,43 @@ impl Dispatcher {
} }
} }
/// Pump a subscription's [`ResponseStream`] to the wire: each
/// [`ResponseEnvelope`] becomes an [`EventEnvelope`] frame (`call.responded`
/// for `Ok`, `call.error` for `Err`). On natural stream end (the stream
/// returned `None` without the last item being an `Err`), write a
/// `call.completed` frame. An `Err` envelope is terminal — the stream
/// ends after it and we do NOT write `call.completed` (ADR-049 §6).
///
/// If a frame write fails the pump stops early; the stream is dropped on
/// return, releasing the handler's resources via `Drop` (ADR-016). The
/// pump is cancellable: it runs inside the `handle_stream` task, so a
/// `call.aborted` for this request ID (handled by `handle_abort` on
/// another stream) or connection close cancels the task and drops the
/// stream.
pub(crate) async fn pump_stream<W: tokio::io::AsyncWrite + Unpin>(
&self,
writer: &mut super::wire::FrameFramedWriter<W>,
request_id: &str,
mut stream: ResponseStream,
) {
let mut last_was_error = false;
while let Some(envelope) = stream.next().await {
last_was_error = envelope.result.is_err();
let event: EventEnvelope = envelope.into();
if let Err(err) = writer.write_frame(&event).await {
warn!(error = %err, "failed to write streaming frame; closing stream");
return;
}
}
if !last_was_error {
let completed = EventEnvelope::completed(request_id);
if let Err(err) = writer.write_frame(&completed).await {
warn!(error = %err, "failed to write call.completed");
}
}
}
/// Run the shared dispatch loop over an established `CallConnection`: /// Run the shared dispatch loop over an established `CallConnection`:
/// spawn the pending-entry sweeper, accept bidirectional streams until the /// spawn the pending-entry sweeper, accept bidirectional streams until the
/// connection closes, dispatch each stream via `handle_stream`, and fail /// connection closes, dispatch each stream via `handle_stream`, and fail
@@ -325,8 +440,10 @@ impl Clone for Dispatcher {
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;
use crate::protocol::wire::EVENT_RESPONDED; use crate::protocol::wire::{EVENT_COMPLETED, EVENT_ERROR, EVENT_RESPONDED};
use crate::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use crate::registry::registration::{
make_handler, make_streaming_handler, HandlerKind, HandlerRegistration, OperationProvenance,
};
use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::{AuthToken, Identity, IdentityProvider}; use alknet_core::auth::{AuthToken, Identity, IdentityProvider};
use alknet_core::types::{Capabilities, MockConnection}; use alknet_core::types::{Capabilities, MockConnection};
@@ -412,24 +529,26 @@ mod tests {
fn registry_with(name: &str, visibility: Visibility, acl: AccessControl) -> OperationRegistry { fn registry_with(name: &str, visibility: Visibility, acl: AccessControl) -> OperationRegistry {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
OperationSpec::new( .register(HandlerRegistration::new(
name, OperationSpec::new(
OperationType::Query, name,
visibility, OperationType::Query,
serde_json::json!({}), visibility,
serde_json::json!({}), serde_json::json!({}),
vec![], serde_json::json!({}),
acl, vec![],
), acl,
make_handler(|input, context| async move { ),
ResponseEnvelope::ok(context.request_id, input) HandlerKind::Once(make_handler(|input, context| async move {
}), ResponseEnvelope::ok(context.request_id, input)
OperationProvenance::Local, })),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
registry registry
} }
@@ -451,14 +570,16 @@ mod tests {
serde_json::json!({ "has_google": has_google }), serde_json::json!({ "has_google": has_google }),
) )
}); });
registry.register(HandlerRegistration::new( registry
external_spec("admin/run", AccessControl::default()), .register(HandlerRegistration::new(
handler, external_spec("admin/run", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(handler),
None, OperationProvenance::Local,
None, None,
caps, None,
)); caps,
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider); let dp = Dispatcher::new(registry, provider);
@@ -486,20 +607,22 @@ mod tests {
serde_json::json!({ "has_google": has_google }), serde_json::json!({ "has_google": has_google }),
) )
}); });
registry.register(HandlerRegistration::new( registry
external_spec( .register(HandlerRegistration::new(
"admin/run", external_spec(
AccessControl { "admin/run",
required_scopes: vec!["admin".to_string()], AccessControl {
..Default::default() required_scopes: vec!["admin".to_string()],
}, ..Default::default()
), },
handler, ),
OperationProvenance::Local, HandlerKind::Once(handler),
None, OperationProvenance::Local,
None, None,
caps, None,
)); caps,
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new( let provider: Arc<dyn IdentityProvider> = Arc::new(
StaticIdentityProvider::new() StaticIdentityProvider::new()
@@ -609,14 +732,16 @@ mod tests {
serde_json::json!({ "forwarded_for_id": forwarded_id }), serde_json::json!({ "forwarded_for_id": forwarded_id }),
) )
}); });
registry.register(HandlerRegistration::new( registry
external_spec("fs/readFile", AccessControl::default()), .register(HandlerRegistration::new(
handler, external_spec("fs/readFile", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(handler),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider); let dp = Dispatcher::new(registry, provider);
@@ -648,14 +773,16 @@ mod tests {
serde_json::json!({ "present": present }), serde_json::json!({ "present": present }),
) )
}); });
registry.register(HandlerRegistration::new( registry
external_spec("fs/readFile", AccessControl::default()), .register(HandlerRegistration::new(
handler, external_spec("fs/readFile", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(handler),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider); let dp = Dispatcher::new(registry, provider);
@@ -736,14 +863,16 @@ mod tests {
serde_json::json!({ "peer_ids": peer_ids }), serde_json::json!({ "peer_ids": peer_ids }),
) )
}); });
registry.register(HandlerRegistration::new( registry
external_spec("fs/readFile", AccessControl::default()), .register(HandlerRegistration::new(
handler, external_spec("fs/readFile", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(handler),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider); let dp = Dispatcher::new(registry, provider);
@@ -795,7 +924,11 @@ mod tests {
let child_id = "ws-abort-child".to_string(); let child_id = "ws-abort-child".to_string();
{ {
let mut pending = conn.pending().lock(); let mut pending = conn.pending().lock();
pending.register_call(parent_id.clone(), Instant::now() + Duration::from_secs(30), None); pending.register_call(
parent_id.clone(),
Instant::now() + Duration::from_secs(30),
None,
);
pending.register_call( pending.register_call(
child_id.clone(), child_id.clone(),
Instant::now() + Duration::from_secs(30), Instant::now() + Duration::from_secs(30),
@@ -844,11 +977,400 @@ mod tests {
"input": { "v": 42 }, "input": { "v": 42 },
}); });
let request_id = "ws-roundtrip-1".to_string(); let request_id = "ws-roundtrip-1".to_string();
let response = dp.dispatch_requested(&conn, request_id.clone(), payload).await; let response = dp
.dispatch_requested(&conn, request_id.clone(), payload)
.await;
assert!(response.result.is_ok()); assert!(response.result.is_ok());
let envelope: EventEnvelope = response.into(); let envelope: EventEnvelope = response.into();
assert_eq!(envelope.r#type, EVENT_RESPONDED); assert_eq!(envelope.r#type, EVENT_RESPONDED);
assert_eq!(envelope.id, "ws-roundtrip-1"); assert_eq!(envelope.id, "ws-roundtrip-1");
assert_eq!(envelope.payload.get("output"), Some(&serde_json::json!({ "v": 42 }))); assert_eq!(
envelope.payload.get("output"),
Some(&serde_json::json!({ "v": 42 }))
);
}
// --- streaming dispatch branch (ADR-049 §6) ---------------------------
fn subscription_spec(name: &str, acl: AccessControl) -> OperationSpec {
OperationSpec::new(
name,
OperationType::Subscription,
Visibility::External,
serde_json::json!({}),
serde_json::json!({}),
vec![],
acl,
)
}
fn encode_frame(envelope: &EventEnvelope) -> Vec<u8> {
let body = serde_json::to_vec(envelope).expect("serialize envelope");
let mut buf = (body.len() as u32).to_be_bytes().to_vec();
buf.extend_from_slice(&body);
buf
}
async fn read_all_frames(
reader: &mut (impl tokio::io::AsyncRead + Unpin),
) -> Vec<EventEnvelope> {
let mut buf = Vec::new();
use tokio::io::AsyncReadExt;
let _ = reader.read_to_end(&mut buf).await;
let mut frames = Vec::new();
let mut cursor = std::io::Cursor::new(buf);
loop {
let mut len_buf = [0u8; 4];
match tokio::io::AsyncReadExt::read_exact(&mut cursor, &mut len_buf).await {
Ok(_) => {}
Err(_) => break,
}
let len = u32::from_be_bytes(len_buf) as usize;
let mut body = vec![0u8; len];
if tokio::io::AsyncReadExt::read_exact(&mut cursor, &mut body)
.await
.is_err()
{
break;
}
let envelope: EventEnvelope =
serde_json::from_slice(&body).expect("deserialize written frame");
frames.push(envelope);
}
frames
}
fn registry_with_subscription(
name: &str,
handler: crate::registry::registration::StreamingHandler,
) -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new();
registry
.register(HandlerRegistration::new(
subscription_spec(name, AccessControl::default()),
HandlerKind::Stream(handler),
OperationProvenance::Local,
None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry)
}
#[tokio::test]
async fn dispatch_subscription_returns_stream_result() {
let handler = make_streaming_handler(|input, ctx| {
futures::stream::iter(vec![
ResponseEnvelope::ok(ctx.request_id.clone(), input.clone()),
ResponseEnvelope::ok(ctx.request_id.clone(), serde_json::json!({"done": true})),
])
});
let registry = registry_with_subscription("events/stream", handler);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let payload = serde_json::json!({
"operationId": "/events/stream",
"input": { "v": 1 },
});
match dp.dispatch(&conn, "sub-1".to_string(), payload).await {
DispatchResult::Stream(mut stream) => {
use futures::stream::StreamExt;
let first = stream.next().await.expect("first envelope");
assert_eq!(first.request_id, "sub-1");
assert_eq!(first.result, Ok(serde_json::json!({ "v": 1 })));
let second = stream.next().await.expect("second envelope");
assert_eq!(second.result, Ok(serde_json::json!({ "done": true })));
assert!(
stream.next().await.is_none(),
"stream ends after two values"
);
}
other => panic!("expected Stream, got {other:?}"),
}
}
#[tokio::test]
async fn dispatch_subscription_clears_deadline_to_none() {
let handler = make_streaming_handler(|_input, ctx| {
let deadline = ctx.deadline;
futures::stream::iter(vec![ResponseEnvelope::ok(
ctx.request_id.clone(),
serde_json::json!({ "deadline_is_none": deadline.is_none() }),
)])
});
let registry = registry_with_subscription("events/stream", handler);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let payload = serde_json::json!({
"operationId": "/events/stream",
"input": {},
});
match dp.dispatch(&conn, "sub-dl".to_string(), payload).await {
DispatchResult::Stream(mut stream) => {
use futures::stream::StreamExt;
let env = stream.next().await.expect("one envelope");
let out = env.result.expect("ok");
assert_eq!(out["deadline_is_none"], Value::Bool(true));
}
other => panic!("expected Stream, got {other:?}"),
}
}
#[tokio::test]
async fn dispatch_query_keeps_deadline_some() {
let mut registry = OperationRegistry::new();
let handler = make_handler(|_input, ctx| async move {
let deadline_is_some = ctx.deadline.is_some();
ResponseEnvelope::ok(
ctx.request_id.clone(),
serde_json::json!({ "deadline_is_some": deadline_is_some }),
)
});
registry
.register(HandlerRegistration::new(
external_spec("echo/run", AccessControl::default()),
HandlerKind::Once(handler),
OperationProvenance::Local,
None,
None,
Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let payload = serde_json::json!({
"operationId": "/echo/run",
"input": {},
});
match dp.dispatch(&conn, "q-1".to_string(), payload).await {
DispatchResult::Once(env) => {
let out = env.result.expect("ok");
assert_eq!(out["deadline_is_some"], Value::Bool(true));
}
other => panic!("expected Once, got {other:?}"),
}
}
#[tokio::test]
async fn handle_stream_subscription_pumps_each_frame_then_completed() {
let handler = make_streaming_handler(|input, ctx| {
let first = input.clone();
let rid = ctx.request_id.clone();
futures::stream::iter(vec![
ResponseEnvelope::ok(rid.clone(), first),
ResponseEnvelope::ok(rid.clone(), serde_json::json!({"n": 2})),
ResponseEnvelope::ok(rid, serde_json::json!({"n": 3})),
])
});
let registry = registry_with_subscription("events/stream", handler);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let request = EventEnvelope::requested(
"sub-pump-1",
serde_json::json!({
"operationId": "/events/stream",
"input": { "n": 1 },
}),
);
let recv = tokio::io::BufReader::new(std::io::Cursor::new(encode_frame(&request)));
let (send, mut sink) = tokio::io::duplex(8 * 1024);
let send = alknet_core::types::SendStream::from_mock(send);
let recv = alknet_core::types::RecvStream::from_mock(recv);
dp.handle_stream(conn, send, recv).await;
let frames = read_all_frames(&mut sink).await;
assert_eq!(frames.len(), 4, "3 responded + 1 completed");
for (i, f) in frames[..3].iter().enumerate() {
assert_eq!(f.r#type, EVENT_RESPONDED, "frame {i} is call.responded");
assert_eq!(f.id, "sub-pump-1");
}
assert_eq!(frames[3].r#type, EVENT_COMPLETED);
assert_eq!(frames[3].id, "sub-pump-1");
assert_eq!(frames[3].payload, serde_json::json!({}));
}
#[tokio::test]
async fn handle_stream_subscription_error_is_terminal_no_completed() {
let handler = make_streaming_handler(|_input, ctx| {
let rid = ctx.request_id.clone();
futures::stream::iter(vec![
ResponseEnvelope::ok(rid.clone(), serde_json::json!({"ok": true})),
ResponseEnvelope::error(rid.clone(), CallError::internal("boom")),
])
});
let registry = registry_with_subscription("events/stream", handler);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let request = EventEnvelope::requested(
"sub-err-1",
serde_json::json!({
"operationId": "/events/stream",
"input": {},
}),
);
let recv = tokio::io::BufReader::new(std::io::Cursor::new(encode_frame(&request)));
let (send, mut sink) = tokio::io::duplex(8 * 1024);
let send = alknet_core::types::SendStream::from_mock(send);
let recv = alknet_core::types::RecvStream::from_mock(recv);
dp.handle_stream(conn, send, recv).await;
let frames = read_all_frames(&mut sink).await;
assert_eq!(frames.len(), 2, "1 responded + 1 error, no completed");
assert_eq!(frames[0].r#type, EVENT_RESPONDED);
assert_eq!(frames[1].r#type, EVENT_ERROR);
assert_eq!(frames[1].id, "sub-err-1");
assert_eq!(
frames[1].payload.get("code"),
Some(&Value::String("INTERNAL".into()))
);
}
#[tokio::test]
async fn handle_stream_query_dispatch_unchanged_one_frame_no_completed() {
let registry = Arc::new(registry_with(
"echo/run",
Visibility::External,
AccessControl::default(),
));
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let request = EventEnvelope::requested(
"q-pump-1",
serde_json::json!({
"operationId": "/echo/run",
"input": { "msg": "hi" },
}),
);
let recv = tokio::io::BufReader::new(std::io::Cursor::new(encode_frame(&request)));
let (send, mut sink) = tokio::io::duplex(8 * 1024);
let send = alknet_core::types::SendStream::from_mock(send);
let recv = alknet_core::types::RecvStream::from_mock(recv);
dp.handle_stream(conn, send, recv).await;
let frames = read_all_frames(&mut sink).await;
assert_eq!(frames.len(), 1, "query: exactly one frame, no completed");
assert_eq!(frames[0].r#type, EVENT_RESPONDED);
assert_eq!(frames[0].id, "q-pump-1");
assert_eq!(
frames[0].payload.get("output"),
Some(&serde_json::json!({ "msg": "hi" }))
);
}
#[tokio::test]
async fn handle_stream_subscription_unknown_op_yields_single_error_no_completed() {
let registry = Arc::new(OperationRegistry::new());
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let request = EventEnvelope::requested(
"sub-missing-1",
serde_json::json!({
"operationId": "/no/such/stream",
"input": {},
}),
);
let recv = tokio::io::BufReader::new(std::io::Cursor::new(encode_frame(&request)));
let (send, mut sink) = tokio::io::duplex(8 * 1024);
let send = alknet_core::types::SendStream::from_mock(send);
let recv = alknet_core::types::RecvStream::from_mock(recv);
dp.handle_stream(conn, send, recv).await;
let frames = read_all_frames(&mut sink).await;
assert_eq!(frames.len(), 1, "unknown op: single error, no completed");
assert_eq!(frames[0].r#type, EVENT_ERROR);
assert_eq!(frames[0].id, "sub-missing-1");
assert_eq!(
frames[0].payload.get("code"),
Some(&Value::String("NOT_FOUND".into()))
);
}
#[tokio::test]
async fn handle_stream_aborted_for_streaming_request_drops_stream() {
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::Arc as StdArc;
let dropped = StdArc::new(AtomicBool::new(false));
let dropped_clone = StdArc::clone(&dropped);
let handler = make_streaming_handler(move |_input, ctx| {
let rid = ctx.request_id.clone();
let flag = StdArc::clone(&dropped_clone);
struct DropGuard(StdArc<AtomicBool>);
impl Drop for DropGuard {
fn drop(&mut self) {
self.0.store(true, Ordering::SeqCst);
}
}
let guard = DropGuard(StdArc::clone(&flag));
futures::stream::poll_fn(move |_cx| {
if flag.load(Ordering::SeqCst) {
return std::task::Poll::Ready(None);
}
std::task::Poll::Ready(Some(ResponseEnvelope::ok(
rid.clone(),
serde_json::json!({"tick": 1}),
)))
})
.map(move |env| {
let _keep_guard = &guard;
env
})
});
let registry = registry_with_subscription("events/stream", handler);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = Dispatcher::new(registry, provider);
let conn = Arc::new(CallConnection::new(stub_connection()));
let request = EventEnvelope::requested(
"sub-abort-1",
serde_json::json!({
"operationId": "/events/stream",
"input": {},
}),
);
let recv = tokio::io::BufReader::new(std::io::Cursor::new(encode_frame(&request)));
let (send, _sink) = tokio::io::duplex(8 * 1024);
let send = alknet_core::types::SendStream::from_mock(send);
let recv = alknet_core::types::RecvStream::from_mock(recv);
let conn_clone = Arc::clone(&conn);
let dp_clone = dp.clone();
let handle = tokio::spawn(async move {
dp_clone.handle_stream(conn_clone, send, recv).await;
});
tokio::time::sleep(std::time::Duration::from_millis(50)).await;
dp.handle_abort(&conn, "sub-abort-1").await;
assert!(
!conn.pending().lock().contains("sub-abort-1"),
"abort removes the pending entry"
);
handle.abort();
let _ = handle.await;
assert!(
dropped.load(Ordering::SeqCst),
"stream future dropped → Drop guard released handler resources"
);
} }
} }

View File

@@ -105,6 +105,10 @@ impl CallError {
pub fn timeout(message: impl Into<String>) -> Self { pub fn timeout(message: impl Into<String>) -> Self {
Self::new("TIMEOUT", message, true) Self::new("TIMEOUT", message, true)
} }
pub fn invalid_operation_type(message: impl Into<String>) -> Self {
Self::new("INVALID_OPERATION_TYPE", message, false)
}
} }
impl Eq for CallError {} impl Eq for CallError {}

View File

@@ -324,7 +324,10 @@ pub fn services_schema_handler(registry: Arc<OperationRegistry>) -> Handler {
mod tests { mod tests {
use super::*; use super::*;
use crate::registry::context::{CompositionAuthority, ScopedPeerEnv}; use crate::registry::context::{CompositionAuthority, ScopedPeerEnv};
use crate::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use crate::registry::registration::{
make_handler, make_streaming_handler, HandlerKind, HandlerRegistration,
OperationProvenance, StreamingHandler,
};
use alknet_core::types::Capabilities; use alknet_core::types::Capabilities;
use std::collections::HashMap; use std::collections::HashMap;
use std::time::Duration; use std::time::Duration;
@@ -359,6 +362,12 @@ mod tests {
) )
} }
fn echo_streaming_handler() -> StreamingHandler {
make_streaming_handler(|input, context| {
futures::stream::iter(vec![ResponseEnvelope::ok(context.request_id, input)])
})
}
fn noop_env() -> Arc<dyn crate::registry::env::OperationEnv + Send + Sync> { fn noop_env() -> Arc<dyn crate::registry::env::OperationEnv + Send + Sync> {
struct NoopEnv; struct NoopEnv;
#[async_trait::async_trait] #[async_trait::async_trait]
@@ -439,36 +448,42 @@ mod tests {
fn registry_with_access_controlled_ops() -> Arc<OperationRegistry> { fn registry_with_access_controlled_ops() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec_with_acl("public/echo", AccessControl::default()), .register(HandlerRegistration::new(
echo_handler(), external_spec_with_acl("public/echo", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
external_spec_with_acl( .unwrap();
"admin/secret", registry
AccessControl { .register(HandlerRegistration::new(
required_scopes: vec!["admin".to_string()], external_spec_with_acl(
..Default::default() "admin/secret",
}, AccessControl {
), required_scopes: vec!["admin".to_string()],
echo_handler(), ..Default::default()
OperationProvenance::Local, },
None, ),
None, HandlerKind::Once(echo_handler()),
Capabilities::new(), OperationProvenance::Local,
)); None,
registry.register(HandlerRegistration::new( None,
internal_spec("internal/hidden"), Capabilities::new(),
echo_handler(), ))
OperationProvenance::Local, .unwrap();
None, registry
None, .register(HandlerRegistration::new(
Capabilities::new(), internal_spec("internal/hidden"),
)); HandlerKind::Once(echo_handler()),
OperationProvenance::Local,
None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -485,59 +500,67 @@ mod tests {
fn registry_with_ops() -> Arc<OperationRegistry> { fn registry_with_ops() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("fs/readFile"), .register(HandlerRegistration::new(
echo_handler(), external_spec("fs/readFile"),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
internal_spec("secret/internal"), .unwrap();
echo_handler(), registry
OperationProvenance::Local, .register(HandlerRegistration::new(
None, internal_spec("secret/internal"),
None, HandlerKind::Once(echo_handler()),
Capabilities::new(), OperationProvenance::Local,
)); None,
registry.register(HandlerRegistration::new( None,
OperationSpec::new( Capabilities::new(),
"events/subscribe", ))
OperationType::Subscription, .unwrap();
Visibility::External, registry
json!({}), .register(HandlerRegistration::new(
json!({}), OperationSpec::new(
vec![], "events/subscribe",
AccessControl::default(), OperationType::Subscription,
), Visibility::External,
echo_handler(), json!({}),
OperationProvenance::Local, json!({}),
None, vec![],
None, AccessControl::default(),
Capabilities::new(), ),
)); HandlerKind::Stream(echo_streaming_handler()),
registry.register(HandlerRegistration::new( OperationProvenance::Local,
OperationSpec::new( None,
"fs/readFileErr", None,
OperationType::Query, Capabilities::new(),
Visibility::External, ))
json!({}), .unwrap();
json!({}), registry
vec![super::super::spec::ErrorDefinition { .register(HandlerRegistration::new(
code: "FILE_NOT_FOUND".to_string(), OperationSpec::new(
description: "file not found".to_string(), "fs/readFileErr",
schema: json!({ "type": "object" }), OperationType::Query,
http_status: None, Visibility::External,
}], json!({}),
AccessControl::default(), json!({}),
), vec![super::super::spec::ErrorDefinition {
echo_handler(), code: "FILE_NOT_FOUND".to_string(),
OperationProvenance::Local, description: "file not found".to_string(),
None, schema: json!({ "type": "object" }),
None, http_status: None,
Capabilities::new(), }],
)); AccessControl::default(),
),
HandlerKind::Once(echo_handler()),
OperationProvenance::Local,
None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -669,22 +692,26 @@ mod tests {
let schema_handler = services_schema_handler(Arc::clone(&registry)); let schema_handler = services_schema_handler(Arc::clone(&registry));
let mut discovery_registry = OperationRegistry::new(); let mut discovery_registry = OperationRegistry::new();
discovery_registry.register(HandlerRegistration::new( discovery_registry
services_list_spec(), .register(HandlerRegistration::new(
list_handler, services_list_spec(),
OperationProvenance::Local, HandlerKind::Once(list_handler),
CompositionAuthority::none(), OperationProvenance::Local,
ScopedPeerEnv::empty().into(), CompositionAuthority::none(),
Capabilities::new(), ScopedPeerEnv::empty().into(),
)); Capabilities::new(),
discovery_registry.register(HandlerRegistration::new( ))
services_schema_spec(), .unwrap();
schema_handler, discovery_registry
OperationProvenance::Local, .register(HandlerRegistration::new(
CompositionAuthority::none(), services_schema_spec(),
ScopedPeerEnv::empty().into(), HandlerKind::Once(schema_handler),
Capabilities::new(), OperationProvenance::Local,
)); CompositionAuthority::none(),
ScopedPeerEnv::empty().into(),
Capabilities::new(),
))
.unwrap();
let discovery = Arc::new(discovery_registry); let discovery = Arc::new(discovery_registry);
let ctx = root_context("req-6"); let ctx = root_context("req-6");

View File

@@ -303,7 +303,9 @@ impl OperationEnv for PeerCompositeEnv {
mod tests { mod tests {
use super::*; use super::*;
use crate::registry::context::CompositionAuthority; use crate::registry::context::CompositionAuthority;
use crate::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use crate::registry::registration::{
make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
};
use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use crate::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::Identity; use alknet_core::auth::Identity;
use alknet_core::types::Capabilities; use alknet_core::types::Capabilities;
@@ -406,22 +408,24 @@ mod tests {
scoped_env: Option<ScopedPeerEnv>, scoped_env: Option<ScopedPeerEnv>,
) -> Arc<OperationRegistry> { ) -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
OperationSpec::new( .register(HandlerRegistration::new(
name, OperationSpec::new(
OperationType::Query, name,
spec_visibility, OperationType::Query,
serde_json::json!({}), spec_visibility,
serde_json::json!({}), serde_json::json!({}),
vec![], serde_json::json!({}),
AccessControl::default(), vec![],
), AccessControl::default(),
handler, ),
OperationProvenance::Local, HandlerKind::Once(handler),
composition_authority, OperationProvenance::Local,
scoped_env, composition_authority,
Capabilities::new(), scoped_env,
)); Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }

File diff suppressed because it is too large Load Diff

View File

@@ -15,7 +15,7 @@ use alknet_call::registry::discovery::{
services_list_handler, services_list_spec, services_schema_handler, services_schema_spec, services_list_handler, services_list_spec, services_schema_handler, services_schema_spec,
}; };
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, Handler, HandlerRegistration, OperationProvenance, OperationRegistry, make_handler, Handler, HandlerKind, HandlerRegistration, OperationProvenance, OperationRegistry,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::{Identity, IdentityProvider}; use alknet_core::auth::{Identity, IdentityProvider};
@@ -124,58 +124,66 @@ async fn build_raw_quinn_server(
/// services/list + services/schema discovery handlers. /// services/list + services/schema discovery handlers.
fn build_server_registry() -> Arc<OperationRegistry> { fn build_server_registry() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("server/echo"), .register(HandlerRegistration::new(
echo_handler(), external_spec("server/echo"),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
external_spec("server/secret"), .unwrap();
echo_handler(), registry
OperationProvenance::Local, .register(HandlerRegistration::new(
None, external_spec("server/secret"),
None, HandlerKind::Once(echo_handler()),
Capabilities::new().with_api_key("google", "server-secret".to_string()), OperationProvenance::Local,
)); None,
None,
Capabilities::new().with_api_key("google", "server-secret".to_string()),
))
.unwrap();
let discovery_registry = Arc::new(registry); let discovery_registry = Arc::new(registry);
let list_handler = services_list_handler(Arc::clone(&discovery_registry)); let list_handler = services_list_handler(Arc::clone(&discovery_registry));
let schema_handler = services_schema_handler(Arc::clone(&discovery_registry)); let schema_handler = services_schema_handler(Arc::clone(&discovery_registry));
let mut full = OperationRegistry::new(); let mut full = OperationRegistry::new();
full.register(HandlerRegistration::new( full.register(HandlerRegistration::new(
external_spec("server/echo"), external_spec("server/echo"),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
Capabilities::new(), Capabilities::new(),
)); ))
.unwrap();
full.register(HandlerRegistration::new( full.register(HandlerRegistration::new(
external_spec("server/secret"), external_spec("server/secret"),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
Capabilities::new().with_api_key("google", "server-secret".to_string()), Capabilities::new().with_api_key("google", "server-secret".to_string()),
)); ))
.unwrap();
full.register(HandlerRegistration::new( full.register(HandlerRegistration::new(
services_list_spec(), services_list_spec(),
list_handler, HandlerKind::Once(list_handler),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
Capabilities::new(), Capabilities::new(),
)); ))
.unwrap();
full.register(HandlerRegistration::new( full.register(HandlerRegistration::new(
services_schema_spec(), services_schema_spec(),
schema_handler, HandlerKind::Once(schema_handler),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
Capabilities::new(), Capabilities::new(),
)); ))
.unwrap();
Arc::new(full) Arc::new(full)
} }
@@ -191,14 +199,16 @@ async fn two_node_call_round_trip() {
// it as UnknownIssuer since the self-signed cert is not in the platform // it as UnknownIssuer since the self-signed cert is not in the platform
// root store. // root store.
let mut client_registry = OperationRegistry::new(); let mut client_registry = OperationRegistry::new();
client_registry.register(HandlerRegistration::new( client_registry
external_spec("client/echo"), .register(HandlerRegistration::new(
echo_handler(), external_spec("client/echo"),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let client_registry = Arc::new(client_registry); let client_registry = Arc::new(client_registry);
let client = CallClient::new(Arc::clone(&client_registry), Arc::new(NoopIdentityProvider)); let client = CallClient::new(Arc::clone(&client_registry), Arc::new(NoopIdentityProvider));

View File

@@ -12,7 +12,9 @@
use alknet_call::client::{AdapterError, OperationAdapter}; use alknet_call::client::{AdapterError, OperationAdapter};
use alknet_call::protocol::wire::{CallError, ResponseEnvelope}; use alknet_call::protocol::wire::{CallError, ResponseEnvelope};
use alknet_call::registry::context::OperationContext; use alknet_call::registry::context::OperationContext;
use alknet_call::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use alknet_call::registry::registration::{
make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
};
use alknet_call::registry::spec::{ use alknet_call::registry::spec::{
AccessControl, ErrorDefinition, OperationSpec, OperationType, Visibility, AccessControl, ErrorDefinition, OperationSpec, OperationType, Visibility,
}; };
@@ -156,7 +158,7 @@ fn build_registration(
HandlerRegistration::new( HandlerRegistration::new(
spec, spec,
handler, HandlerKind::Once(handler),
OperationProvenance::FromMCP, OperationProvenance::FromMCP,
None, None,
None, None,

View File

@@ -17,12 +17,16 @@ use std::sync::Arc;
use alknet_call::client::{AdapterError, OperationAdapter}; use alknet_call::client::{AdapterError, OperationAdapter};
use alknet_call::protocol::wire::{CallError, ResponseEnvelope}; use alknet_call::protocol::wire::{CallError, ResponseEnvelope};
use alknet_call::registry::context::OperationContext; use alknet_call::registry::context::OperationContext;
use alknet_call::registry::registration::{make_handler, HandlerRegistration, OperationProvenance}; use alknet_call::registry::registration::{
make_handler, make_streaming_handler, HandlerKind, HandlerRegistration, OperationProvenance,
ResponseStream,
};
use alknet_call::registry::spec::{ use alknet_call::registry::spec::{
AccessControl, ErrorDefinition, OperationSpec, OperationType, Visibility, AccessControl, ErrorDefinition, OperationSpec, OperationType, Visibility,
}; };
use alknet_core::types::Capabilities; use alknet_core::types::Capabilities;
use async_trait::async_trait; use async_trait::async_trait;
use futures::stream;
use futures::StreamExt; use futures::StreamExt;
use reqwest::header::{HeaderMap, HeaderName, HeaderValue, ACCEPT, AUTHORIZATION, CONTENT_TYPE}; use reqwest::header::{HeaderMap, HeaderName, HeaderValue, ACCEPT, AUTHORIZATION, CONTENT_TYPE};
use reqwest::Method; use reqwest::Method;
@@ -438,33 +442,61 @@ impl FromOpenAPI {
.map(|e| (e.http_status.unwrap_or(0), e.code.clone())) .map(|e| (e.http_status.unwrap_or(0), e.code.clone()))
.collect(); .collect();
let handler = make_handler(move |input: Value, context: OperationContext| { let handler = if op_type == OperationType::Subscription {
let path_template = path_template.clone(); let stream_handler =
let method_upper = method_upper.clone(); make_streaming_handler(move |input: Value, context: OperationContext| {
let auth_scheme = auth_scheme.clone(); let path_template = path_template.clone();
let default_headers = default_headers.clone(); let method_upper = method_upper.clone();
let base_url = base_url.clone(); let auth_scheme = auth_scheme.clone();
let namespace = namespace.clone(); let default_headers = default_headers.clone();
let http_client = Arc::clone(&http_client); let base_url = base_url.clone();
let error_status_codes = error_status_codes.clone(); let namespace = namespace.clone();
let op_type = op_type; let http_client = Arc::clone(&http_client);
async move { let error_status_codes = error_status_codes.clone();
forward( forward_stream(
&http_client, &http_client,
&base_url, &base_url,
&path_template, &path_template,
&method_upper, &method_upper,
&auth_scheme, &auth_scheme,
&default_headers, &default_headers,
&namespace, &namespace,
&error_status_codes, &error_status_codes,
op_type, input,
input, context,
context, )
) });
.await HandlerKind::Stream(stream_handler)
} } else {
}); let once_handler = make_handler(move |input: Value, context: OperationContext| {
let path_template = path_template.clone();
let method_upper = method_upper.clone();
let auth_scheme = auth_scheme.clone();
let default_headers = default_headers.clone();
let base_url = base_url.clone();
let namespace = namespace.clone();
let http_client = Arc::clone(&http_client);
let error_status_codes = error_status_codes.clone();
let op_type = op_type;
async move {
forward(
&http_client,
&base_url,
&path_template,
&method_upper,
&auth_scheme,
&default_headers,
&namespace,
&error_status_codes,
op_type,
input,
context,
)
.await
}
});
HandlerKind::Once(once_handler)
};
let capabilities = Capabilities::new(); let capabilities = Capabilities::new();
Ok(HandlerRegistration::new( Ok(HandlerRegistration::new(
@@ -664,10 +696,6 @@ async fn forward(
let status = response.status(); let status = response.status();
if op_type == OperationType::Subscription && status.is_success() {
return stream_subscription(request_id, response).await;
}
if !status.is_success() { if !status.is_success() {
let code = error_status_codes let code = error_status_codes
.iter() .iter()
@@ -719,35 +747,136 @@ async fn forward(
} }
} }
async fn stream_subscription(request_id: String, response: reqwest::Response) -> ResponseEnvelope { #[allow(clippy::too_many_arguments)]
let mut stream = response.bytes_stream(); fn forward_stream(
let mut buffer = String::new(); http_client: &Arc<SharedHttpClient>,
let mut last_event: Option<Value> = None; base_url: &str,
while let Some(chunk_result) = stream.next().await { path_template: &str,
match chunk_result { method: &str,
Ok(chunk) => { auth_scheme: &Option<HttpAuthScheme>,
buffer.push_str(&String::from_utf8_lossy(&chunk)); default_headers: &HashMap<String, String>,
let (events, remaining) = parse_sse_frames(&buffer); namespace: &str,
buffer = remaining; error_status_codes: &[(u16, String)],
for event in events { input: Value,
let parsed = if event.data.trim().is_empty() { context: OperationContext,
Value::Null ) -> ResponseStream {
} else { let request_id = context.request_id.clone();
serde_json::from_str(&event.data)
.unwrap_or(Value::String(event.data.clone())) let (http_method, url, body, headers) = match build_request(
}; base_url,
last_event = Some(parsed.clone()); path_template,
method,
auth_scheme,
default_headers,
namespace,
&input,
&context,
) {
Ok(parts) => parts,
Err(err) => {
return Box::pin(stream::once(async move {
ResponseEnvelope::error(request_id, err)
}));
}
};
let http_client = Arc::clone(http_client);
let error_status_codes = error_status_codes.to_vec();
let request_id_stream = request_id.clone();
let error_status_codes_stream = error_status_codes.clone();
let init = async move {
let request_builder = http_client
.client()
.request(http_method, url.as_str())
.headers(headers)
.header(ACCEPT, "text/event-stream");
let request_builder = match body.as_ref() {
Some(b) => {
let serialized = serde_json::to_string(b).unwrap_or_else(|_| String::from("null"));
request_builder.body(serialized)
}
None => request_builder,
};
request_builder.send().await
};
let sse = stream::once(init).flat_map(move |result| {
let request_id = request_id_stream.clone();
let error_status_codes = error_status_codes_stream.clone();
match result {
Err(err) => Box::pin(stream::once(async move {
ResponseEnvelope::error(
request_id,
CallError::internal(format!("HTTP request failed: {err}")),
)
})) as ResponseStream,
Ok(response) => {
let status = response.status();
if !status.is_success() {
let code = error_status_codes
.iter()
.find(|(s, _)| *s == status.as_u16())
.map(|(_, c)| c.clone())
.unwrap_or_else(|| format!("HTTP_{}", status.as_u16()));
let message = format!(
"HTTP {}: {}",
status.as_u16(),
status.canonical_reason().unwrap_or("")
);
Box::pin(stream::once(async move {
ResponseEnvelope::error(request_id, CallError::new(code, message, false))
})) as ResponseStream
} else {
let request_id_inner = request_id.clone();
Box::pin(
stream::unfold(
(response.bytes_stream(), String::new()),
move |(mut bytes, mut buffer)| {
let request_id = request_id_inner.clone();
async move {
match bytes.next().await {
Some(Ok(chunk)) => {
buffer.push_str(&String::from_utf8_lossy(&chunk));
let (events, remaining) = parse_sse_frames(&buffer);
let envelopes: Vec<ResponseEnvelope> = events
.into_iter()
.map(|e| {
let parsed = if e.data.trim().is_empty() {
Value::Null
} else {
serde_json::from_str(&e.data).unwrap_or(
Value::String(e.data.clone()),
)
};
ResponseEnvelope::ok(&request_id, parsed)
})
.collect();
Some((envelopes, (bytes, remaining)))
}
Some(Err(err)) => {
let error = CallError::internal(format!(
"SSE stream error: {err}"
));
Some((
vec![ResponseEnvelope::error(request_id, error)],
(bytes, buffer),
))
}
None => None,
}
}
},
)
.flat_map(stream::iter),
) as ResponseStream
} }
} }
Err(err) => {
return ResponseEnvelope::error(
request_id,
CallError::internal(format!("SSE stream error: {err}")),
);
}
} }
} });
ResponseEnvelope::ok(request_id, last_event.unwrap_or(Value::Null))
Box::pin(sse)
} }
struct SseEvent { struct SseEvent {
@@ -1151,7 +1280,10 @@ mod tests {
.unwrap(); .unwrap();
let registration = &bundles[0]; let registration = &bundles[0];
let ctx = noop_context("req-10", Capabilities::new()); let ctx = noop_context("req-10", Capabilities::new());
let response = (registration.handler)(serde_json::json!({}), ctx).await; let response = match &registration.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
assert_eq!(response.request_id, "req-10"); assert_eq!(response.request_id, "req-10");
match response.result { match response.result {
Ok(v) => assert_eq!(v, serde_json::json!({"ok":true})), Ok(v) => assert_eq!(v, serde_json::json!({"ok":true})),
@@ -1176,7 +1308,10 @@ mod tests {
.unwrap(); .unwrap();
let registration = &bundles[0]; let registration = &bundles[0];
let ctx = noop_context("req-11", Capabilities::new()); let ctx = noop_context("req-11", Capabilities::new());
let response = (registration.handler)(serde_json::json!({}), ctx).await; let response = match &registration.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
match response.result { match response.result {
Err(e) => { Err(e) => {
assert_eq!(e.code, "HTTP_404"); assert_eq!(e.code, "HTTP_404");
@@ -1186,6 +1321,34 @@ mod tests {
} }
} }
#[tokio::test]
async fn subscription_op_registration_is_handler_kind_stream() {
let spec = OpenAPISpec::from_json(
r##"{"openapi":"3.0.0","info":{"title":"T","version":"1"},
"paths":{"/stream":{"post":{"operationId":"stream","responses":{"200":{"content":{"text/event-stream":{"schema":{}}}}}}}}}"##,
)
.unwrap();
let bundles = adapter(spec, config("svc", "https://x", None))
.import()
.await
.unwrap();
assert!(matches!(bundles[0].handler, HandlerKind::Stream(_)));
}
#[tokio::test]
async fn query_op_registration_is_handler_kind_once() {
let spec = OpenAPISpec::from_json(
r#"{"openapi":"3.0.0","info":{"title":"T","version":"1"},
"paths":{"/data":{"get":{"operationId":"data","responses":{"200":{"content":{"application/json":{"schema":{}}}}}}}}}"#,
)
.unwrap();
let bundles = adapter(spec, config("svc", "https://x", None))
.import()
.await
.unwrap();
assert!(matches!(bundles[0].handler, HandlerKind::Once(_)));
}
#[tokio::test] #[tokio::test]
async fn integration_sse_subscription_streams_responded_events() { async fn integration_sse_subscription_streams_responded_events() {
let sse_body = "data: {\"n\":1}\n\ndata: {\"n\":2}\n\n"; let sse_body = "data: {\"n\":1}\n\ndata: {\"n\":2}\n\n";
@@ -1201,10 +1364,67 @@ mod tests {
.unwrap(); .unwrap();
let registration = &bundles[0]; let registration = &bundles[0];
let ctx = noop_context("req-12", Capabilities::new()); let ctx = noop_context("req-12", Capabilities::new());
let response = (registration.handler)(serde_json::json!({}), ctx).await; let stream = match &registration.handler {
assert!(response.result.is_ok()); HandlerKind::Stream(h) => h(serde_json::json!({}), ctx),
let last = response.result.unwrap(); _ => panic!("expected Stream handler"),
assert_eq!(last, serde_json::json!({"n":2})); };
let collected: Vec<ResponseEnvelope> = stream.collect().await;
assert_eq!(collected.len(), 2);
assert_eq!(collected[0].result, Ok(serde_json::json!({"n":1})));
assert_eq!(collected[1].result, Ok(serde_json::json!({"n":2})));
assert_eq!(collected[0].request_id, "req-12");
assert_eq!(collected[1].request_id, "req-12");
}
#[tokio::test]
async fn integration_sse_subscription_http_error_returns_single_error_envelope() {
let base = spawn_echo_server(404, r#"{"error":"missing"}"#, "application/json").await;
let spec = OpenAPISpec::from_json(
r##"{"openapi":"3.0.0","info":{"title":"T","version":"1"},
"paths":{"/stream":{"post":{"operationId":"stream","responses":{
"200":{"content":{"text/event-stream":{"schema":{}}}},
"404":{"content":{"application/json":{"schema":{"type":"object"}}}}
}}}}}"##,
)
.unwrap();
let bundles = adapter(spec, config("svc", &base, None))
.import()
.await
.unwrap();
let registration = &bundles[0];
let ctx = noop_context("req-err", Capabilities::new());
let stream = match &registration.handler {
HandlerKind::Stream(h) => h(serde_json::json!({}), ctx),
_ => panic!("expected Stream handler"),
};
let collected: Vec<ResponseEnvelope> = stream.collect().await;
assert_eq!(collected.len(), 1);
match &collected[0].result {
Err(e) => assert_eq!(e.code, "HTTP_404"),
other => panic!("expected HTTP_404 error, got {other:?}"),
}
}
#[tokio::test]
async fn integration_query_forwarding_unchanged_single_response() {
let base = spawn_echo_server(200, r#"{"ok":true}"#, "application/json").await;
let spec = OpenAPISpec::from_json(
r#"{"openapi":"3.0.0","info":{"title":"T","version":"1"},
"paths":{"/data":{"get":{"operationId":"data","responses":{"200":{"content":{"application/json":{"schema":{}}}}}}}}}"#,
)
.unwrap();
let bundles = adapter(spec, config("svc", &base, None))
.import()
.await
.unwrap();
let registration = &bundles[0];
let ctx = noop_context("req-q", Capabilities::new());
let response = match &registration.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
assert_eq!(response.request_id, "req-q");
assert_eq!(response.result, Ok(serde_json::json!({"ok":true})));
} }
#[test] #[test]
@@ -1447,11 +1667,16 @@ mod tests {
.unwrap(); .unwrap();
let registration = &bundles[0]; let registration = &bundles[0];
let ctx = noop_context("req-16", Capabilities::new()); let ctx = noop_context("req-16", Capabilities::new());
let response = (registration.handler)( let response = match &registration.handler {
serde_json::json!({"id":"42","filter":"new","body":{"name":"widget"}}), HandlerKind::Once(h) => {
ctx, h(
) serde_json::json!({"id":"42","filter":"new","body":{"name":"widget"}}),
.await; ctx,
)
.await
}
_ => panic!("expected Once handler"),
};
assert!( assert!(
response.result.is_ok(), response.result.is_ok(),
"expected Ok, got {:?}", "expected Ok, got {:?}",
@@ -1483,7 +1708,10 @@ mod tests {
let registration = &bundles[0]; let registration = &bundles[0];
let caps = Capabilities::new().with_http_token("openai", "sk-test-token".to_string()); let caps = Capabilities::new().with_http_token("openai", "sk-test-token".to_string());
let ctx = noop_context("req-17", caps); let ctx = noop_context("req-17", caps);
let _ = (registration.handler)(serde_json::json!({}), ctx).await; let _ = match &registration.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
let captured = rx.await.unwrap(); let captured = rx.await.unwrap();
assert_eq!( assert_eq!(
captured.headers.get("authorization").unwrap(), captured.headers.get("authorization").unwrap(),
@@ -1519,7 +1747,10 @@ mod tests {
.unwrap(); .unwrap();
let registration = &bundles[0]; let registration = &bundles[0];
let ctx = noop_context("req-18", Capabilities::new()); let ctx = noop_context("req-18", Capabilities::new());
let response = (registration.handler)(serde_json::json!({}), ctx).await; let response = match &registration.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
match response.result { match response.result {
Ok(Value::String(s)) => assert_eq!(s, "hello world"), Ok(Value::String(s)) => assert_eq!(s, "hello world"),
other => panic!("expected String, got {other:?}"), other => panic!("expected String, got {other:?}"),
@@ -1540,7 +1771,10 @@ mod tests {
.unwrap(); .unwrap();
let registration = &bundles[0]; let registration = &bundles[0];
let ctx = noop_context("req-19", Capabilities::new()); let ctx = noop_context("req-19", Capabilities::new());
let response = (registration.handler)(serde_json::json!({}), ctx).await; let response = match &registration.handler {
HandlerKind::Once(h) => h(serde_json::json!({}), ctx).await,
_ => panic!("expected Once handler"),
};
match response.result { match response.result {
Err(e) => assert_eq!(e.code, "HTTP_500"), Err(e) => assert_eq!(e.code, "HTTP_500"),
other => panic!("expected HTTP_500, got {other:?}"), other => panic!("expected HTTP_500, got {other:?}"),

View File

@@ -432,7 +432,7 @@ mod tests {
services_list_handler, services_list_spec, services_schema_handler, services_schema_spec, services_list_handler, services_list_spec, services_schema_handler, services_schema_spec,
}; };
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, OperationRegistry, make_handler, HandlerKind, HandlerRegistration, OperationProvenance, OperationRegistry,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::{AuthToken, Identity, IdentityProvider}; use alknet_core::auth::{AuthToken, Identity, IdentityProvider};
@@ -502,44 +502,52 @@ mod tests {
) -> Arc<OperationRegistry> { ) -> Arc<OperationRegistry> {
let mut inner = OperationRegistry::new(); let mut inner = OperationRegistry::new();
for (name, op_type, acl) in specs { for (name, op_type, acl) in specs {
inner.register(HandlerRegistration::new( inner
external_spec(&name, op_type, acl), .register(HandlerRegistration::new(
make_echo_handler(), external_spec(&name, op_type, acl),
OperationProvenance::Local, HandlerKind::Once(make_echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
} }
let inner = Arc::new(inner); let inner = Arc::new(inner);
let mut dispatch_registry = OperationRegistry::new(); let mut dispatch_registry = OperationRegistry::new();
for op in inner.list_operations() { for op in inner.list_operations() {
dispatch_registry.register(HandlerRegistration::new( dispatch_registry
external_spec(&op.name, op.op_type, op.access_control.clone()), .register(HandlerRegistration::new(
make_echo_handler(), external_spec(&op.name, op.op_type, op.access_control.clone()),
HandlerKind::Once(make_echo_handler()),
OperationProvenance::Local,
None,
None,
Capabilities::new(),
))
.unwrap();
}
dispatch_registry
.register(HandlerRegistration::new(
services_list_spec(),
HandlerKind::Once(services_list_handler(Arc::clone(&inner))),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, ScopedPeerEnv::empty().into(),
Capabilities::new(), Capabilities::new(),
)); ))
} .unwrap();
dispatch_registry.register(HandlerRegistration::new( dispatch_registry
services_list_spec(), .register(HandlerRegistration::new(
services_list_handler(Arc::clone(&inner)), services_schema_spec(),
OperationProvenance::Local, HandlerKind::Once(services_schema_handler(Arc::clone(&inner))),
None, OperationProvenance::Local,
ScopedPeerEnv::empty().into(), None,
Capabilities::new(), ScopedPeerEnv::empty().into(),
)); Capabilities::new(),
dispatch_registry.register(HandlerRegistration::new( ))
services_schema_spec(), .unwrap();
services_schema_handler(Arc::clone(&inner)),
OperationProvenance::Local,
None,
ScopedPeerEnv::empty().into(),
Capabilities::new(),
));
Arc::new(dispatch_registry) Arc::new(dispatch_registry)
} }

View File

@@ -528,7 +528,7 @@ mod tests {
use super::*; use super::*;
use alknet_call::protocol::wire::ResponseEnvelope; use alknet_call::protocol::wire::ResponseEnvelope;
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::types::Capabilities; use alknet_core::types::Capabilities;
@@ -539,14 +539,16 @@ mod tests {
} }
fn register(registry: &mut OperationRegistry, spec: OperationSpec) { fn register(registry: &mut OperationRegistry, spec: OperationSpec) {
registry.register(HandlerRegistration::new( registry
spec, .register(HandlerRegistration::new(
noop_handler(), spec,
OperationProvenance::Local, HandlerKind::Once(noop_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
} }
fn external_spec(name: &str, errors: Vec<ErrorDefinition>) -> OperationSpec { fn external_spec(name: &str, errors: Vec<ErrorDefinition>) -> OperationSpec {
@@ -1003,22 +1005,24 @@ mod tests {
#[test] #[test]
fn internal_operations_excluded_from_error_projection() { fn internal_operations_excluded_from_error_projection() {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
OperationSpec::new( .register(HandlerRegistration::new(
"internal/op", OperationSpec::new(
OperationType::Query, "internal/op",
Visibility::Internal, OperationType::Query,
json!({}), Visibility::Internal,
json!({}), json!({}),
vec![error("INTERNAL_ERROR", Some(418))], json!({}),
AccessControl::default(), vec![error("INTERNAL_ERROR", Some(418))],
), AccessControl::default(),
noop_handler(), ),
OperationProvenance::Local, HandlerKind::Once(noop_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let spec = to_openapi(&registry); let spec = to_openapi(&registry);
let responses = responses(&spec, PATH_CALL, "post"); let responses = responses(&spec, PATH_CALL, "post");
assert!( assert!(

View File

@@ -117,7 +117,7 @@ mod tests {
services_list_handler, services_list_spec, services_schema_handler, services_schema_spec, services_list_handler, services_list_spec, services_schema_handler, services_schema_spec,
}; };
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::AuthToken; use alknet_core::auth::AuthToken;
@@ -187,45 +187,51 @@ mod tests {
fn registry_with(name: &str, visibility: Visibility, acl: AccessControl) -> OperationRegistry { fn registry_with(name: &str, visibility: Visibility, acl: AccessControl) -> OperationRegistry {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
OperationSpec::new( .register(HandlerRegistration::new(
name, OperationSpec::new(
OperationType::Query, name,
visibility, OperationType::Query,
serde_json::json!({}), visibility,
serde_json::json!({}), serde_json::json!({}),
vec![], serde_json::json!({}),
acl, vec![],
), acl,
make_handler(|input, context| async move { ),
ResponseEnvelope::ok(context.request_id, input) HandlerKind::Once(make_handler(|input, context| async move {
}), ResponseEnvelope::ok(context.request_id, input)
OperationProvenance::Local, })),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
registry registry
} }
fn registry_with_discovery(inner: Arc<OperationRegistry>) -> OperationRegistry { fn registry_with_discovery(inner: Arc<OperationRegistry>) -> OperationRegistry {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
services_list_spec(), .register(HandlerRegistration::new(
services_list_handler(Arc::clone(&inner)), services_list_spec(),
OperationProvenance::Local, HandlerKind::Once(services_list_handler(Arc::clone(&inner))),
None, OperationProvenance::Local,
ScopedPeerEnv::empty().into(), None,
Capabilities::new(), ScopedPeerEnv::empty().into(),
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
services_schema_spec(), .unwrap();
services_schema_handler(Arc::clone(&inner)), registry
OperationProvenance::Local, .register(HandlerRegistration::new(
None, services_schema_spec(),
ScopedPeerEnv::empty().into(), HandlerKind::Once(services_schema_handler(Arc::clone(&inner))),
Capabilities::new(), OperationProvenance::Local,
)); None,
ScopedPeerEnv::empty().into(),
Capabilities::new(),
))
.unwrap();
registry registry
} }
@@ -270,32 +276,36 @@ mod tests {
#[tokio::test] #[tokio::test]
async fn invoke_for_services_list_returns_access_control_filtered_list() { async fn invoke_for_services_list_returns_access_control_filtered_list() {
let mut inner = OperationRegistry::new(); let mut inner = OperationRegistry::new();
inner.register(HandlerRegistration::new( inner
external_spec("public/echo", AccessControl::default()), .register(HandlerRegistration::new(
make_handler(|input, context| async move { external_spec("public/echo", AccessControl::default()),
ResponseEnvelope::ok(context.request_id, input) HandlerKind::Once(make_handler(|input, context| async move {
}), ResponseEnvelope::ok(context.request_id, input)
OperationProvenance::Local, })),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
inner.register(HandlerRegistration::new( ))
external_spec( .unwrap();
"admin/secret", inner
AccessControl { .register(HandlerRegistration::new(
required_scopes: vec!["admin".to_string()], external_spec(
..Default::default() "admin/secret",
}, AccessControl {
), required_scopes: vec!["admin".to_string()],
make_handler(|input, context| async move { ..Default::default()
ResponseEnvelope::ok(context.request_id, input) },
}), ),
OperationProvenance::Local, HandlerKind::Once(make_handler(|input, context| async move {
None, ResponseEnvelope::ok(context.request_id, input)
None, })),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
let inner = Arc::new(inner); let inner = Arc::new(inner);
let discovery = Arc::new(registry_with_discovery(Arc::clone(&inner))); let discovery = Arc::new(registry_with_discovery(Arc::clone(&inner)));
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
@@ -327,16 +337,18 @@ mod tests {
#[tokio::test] #[tokio::test]
async fn invoke_for_services_schema_returns_spec_for_known_op() { async fn invoke_for_services_schema_returns_spec_for_known_op() {
let mut inner = OperationRegistry::new(); let mut inner = OperationRegistry::new();
inner.register(HandlerRegistration::new( inner
external_spec("fs/readFile", AccessControl::default()), .register(HandlerRegistration::new(
make_handler(|input, context| async move { external_spec("fs/readFile", AccessControl::default()),
ResponseEnvelope::ok(context.request_id, input) HandlerKind::Once(make_handler(|input, context| async move {
}), ResponseEnvelope::ok(context.request_id, input)
OperationProvenance::Local, })),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let inner = Arc::new(inner); let inner = Arc::new(inner);
let discovery = Arc::new(registry_with_discovery(Arc::clone(&inner))); let discovery = Arc::new(registry_with_discovery(Arc::clone(&inner)));
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
@@ -373,16 +385,18 @@ mod tests {
#[tokio::test] #[tokio::test]
async fn invoke_for_internal_op_returns_not_found_not_leaked() { async fn invoke_for_internal_op_returns_not_found_not_leaked() {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
internal_spec("secret/op", AccessControl::default()), .register(HandlerRegistration::new(
make_handler(|input, context| async move { internal_spec("secret/op", AccessControl::default()),
ResponseEnvelope::ok(context.request_id, input) HandlerKind::Once(make_handler(|input, context| async move {
}), ResponseEnvelope::ok(context.request_id, input)
OperationProvenance::Local, })),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = dispatch(registry, provider); let dp = dispatch(registry, provider);
@@ -499,16 +513,18 @@ mod tests {
let caps = Capabilities::new().with_api_key("google", "k".to_string()); let caps = Capabilities::new().with_api_key("google", "k".to_string());
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("agent/run", AccessControl::default()), .register(HandlerRegistration::new(
make_handler(|input, context| async move { external_spec("agent/run", AccessControl::default()),
ResponseEnvelope::ok(context.request_id, input) HandlerKind::Once(make_handler(|input, context| async move {
}), ResponseEnvelope::ok(context.request_id, input)
OperationProvenance::Local, })),
Some(authority), OperationProvenance::Local,
Some(scoped.clone()), Some(authority),
caps, Some(scoped.clone()),
)); caps,
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = dispatch(registry, provider); let dp = dispatch(registry, provider);

View File

@@ -295,7 +295,7 @@ mod tests {
services_list_handler, services_list_spec, services_schema_handler, services_schema_spec, services_list_handler, services_list_spec, services_schema_handler, services_schema_spec,
}; };
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType};
use alknet_core::auth::{AuthToken, Identity}; use alknet_core::auth::{AuthToken, Identity};
@@ -376,46 +376,52 @@ mod tests {
fn registry_with_echo() -> Arc<OperationRegistry> { fn registry_with_echo() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("echo/run", AccessControl::default()), .register(HandlerRegistration::new(
echo_handler(), external_spec("echo/run", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
fn registry_with_restricted_op() -> Arc<OperationRegistry> { fn registry_with_restricted_op() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec( .register(HandlerRegistration::new(
"admin/run", external_spec(
AccessControl { "admin/run",
required_scopes: vec!["admin".to_string()], AccessControl {
..Default::default() required_scopes: vec!["admin".to_string()],
}, ..Default::default()
), },
echo_handler(), ),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
fn registry_with_internal_op() -> Arc<OperationRegistry> { fn registry_with_internal_op() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
internal_spec("secret/op"), .register(HandlerRegistration::new(
echo_handler(), internal_spec("secret/op"),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -424,37 +430,43 @@ mod tests {
) -> Arc<OperationRegistry> { ) -> Arc<OperationRegistry> {
let mut inner = OperationRegistry::new(); let mut inner = OperationRegistry::new();
for op in inner_ops { for op in inner_ops {
inner.register(op); inner.register(op).unwrap();
} }
let inner = Arc::new(inner); let inner = Arc::new(inner);
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
services_list_spec(), .register(HandlerRegistration::new(
services_list_handler(Arc::clone(&inner)), services_list_spec(),
OperationProvenance::Local, HandlerKind::Once(services_list_handler(Arc::clone(&inner))),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
services_schema_spec(), .unwrap();
services_schema_handler(Arc::clone(&inner)), registry
OperationProvenance::Local, .register(HandlerRegistration::new(
None, services_schema_spec(),
None, HandlerKind::Once(services_schema_handler(Arc::clone(&inner))),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
for spec in inner.list_operations() { for spec in inner.list_operations() {
let name = spec.name.clone(); let name = spec.name.clone();
let reg = inner.registration(&name).unwrap(); let reg = inner.registration(&name).unwrap();
registry.register(HandlerRegistration::new( registry
reg.spec.clone(), .register(HandlerRegistration::new(
Arc::clone(&reg.handler), reg.spec.clone(),
reg.provenance, reg.handler.clone(),
reg.composition_authority.clone(), reg.provenance,
reg.scoped_env.clone(), reg.composition_authority.clone(),
reg.capabilities.clone(), reg.scoped_env.clone(),
)); reg.capabilities.clone(),
))
.unwrap();
} }
Arc::new(registry) Arc::new(registry)
} }
@@ -572,7 +584,7 @@ mod tests {
let ops = vec![ let ops = vec![
HandlerRegistration::new( HandlerRegistration::new(
external_spec("public/echo", AccessControl::default()), external_spec("public/echo", AccessControl::default()),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
@@ -586,7 +598,7 @@ mod tests {
..Default::default() ..Default::default()
}, },
), ),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
@@ -625,7 +637,7 @@ mod tests {
async fn schema_returns_full_spec_for_authorized_op() { async fn schema_returns_full_spec_for_authorized_op() {
let ops = vec![HandlerRegistration::new( let ops = vec![HandlerRegistration::new(
external_spec("echo/run", AccessControl::default()), external_spec("echo/run", AccessControl::default()),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
@@ -657,7 +669,7 @@ mod tests {
..Default::default() ..Default::default()
}, },
), ),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
@@ -709,22 +721,26 @@ mod tests {
#[tokio::test] #[tokio::test]
async fn batch_internal_op_returns_not_found_in_array() { async fn batch_internal_op_returns_not_found_in_array() {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
internal_spec("secret/op"), .register(HandlerRegistration::new(
echo_handler(), internal_spec("secret/op"),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
external_spec("echo/run", AccessControl::default()), .unwrap();
echo_handler(), registry
OperationProvenance::Local, .register(HandlerRegistration::new(
None, external_spec("echo/run", AccessControl::default()),
None, HandlerKind::Once(echo_handler()),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let router = build_router(registry, unused_provider()); let router = build_router(registry, unused_provider());
let req = Request::builder() let req = Request::builder()
@@ -823,14 +839,16 @@ mod tests {
#[test] #[test]
fn is_internal_op_detects_registered_internal_op() { fn is_internal_op_detects_registered_internal_op() {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
internal_spec("secret/op"), .register(HandlerRegistration::new(
echo_handler(), internal_spec("secret/op"),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
assert!(is_internal_op(&registry, "secret/op")); assert!(is_internal_op(&registry, "secret/op"));
assert!(is_internal_op(&registry, "/secret/op")); assert!(is_internal_op(&registry, "/secret/op"));
} }
@@ -838,14 +856,16 @@ mod tests {
#[test] #[test]
fn is_internal_op_false_for_external_op() { fn is_internal_op_false_for_external_op() {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("echo/run", AccessControl::default()), .register(HandlerRegistration::new(
echo_handler(), external_spec("echo/run", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(echo_handler()),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
assert!(!is_internal_op(&registry, "echo/run")); assert!(!is_internal_op(&registry, "echo/run"));
} }
@@ -906,7 +926,7 @@ mod tests {
let ops = vec![ let ops = vec![
HandlerRegistration::new( HandlerRegistration::new(
external_spec("public/echo", AccessControl::default()), external_spec("public/echo", AccessControl::default()),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
@@ -920,7 +940,7 @@ mod tests {
..Default::default() ..Default::default()
}, },
), ),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,
@@ -953,7 +973,7 @@ mod tests {
async fn schema_unknown_op_returns_404() { async fn schema_unknown_op_returns_404() {
let ops = vec![HandlerRegistration::new( let ops = vec![HandlerRegistration::new(
external_spec("echo/run", AccessControl::default()), external_spec("echo/run", AccessControl::default()),
echo_handler(), HandlerKind::Once(echo_handler()),
OperationProvenance::Local, OperationProvenance::Local,
None, None,
None, None,

View File

@@ -18,7 +18,7 @@ mod tests {
use alknet_call::protocol::wire::{EventEnvelope, ResponseEnvelope, EVENT_RESPONDED}; use alknet_call::protocol::wire::{EventEnvelope, ResponseEnvelope, EVENT_RESPONDED};
use alknet_call::registry::context::AbortPolicy; use alknet_call::registry::context::AbortPolicy;
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, make_handler, HandlerKind, HandlerRegistration, OperationProvenance,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::{Identity, IdentityProvider}; use alknet_core::auth::{Identity, IdentityProvider};
@@ -77,14 +77,18 @@ mod tests {
fn echo_registry() -> Arc<alknet_call::registry::registration::OperationRegistry> { fn echo_registry() -> Arc<alknet_call::registry::registration::OperationRegistry> {
let mut registry = alknet_call::registry::registration::OperationRegistry::new(); let mut registry = alknet_call::registry::registration::OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("echo/run"), .register(HandlerRegistration::new(
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), external_spec("echo/run"),
OperationProvenance::Local, HandlerKind::Once(make_handler(|input, ctx| async move {
None, ResponseEnvelope::ok(ctx.request_id, input)
None, })),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -174,7 +178,9 @@ mod tests {
assert!(!env.contains("worker/exec")); assert!(!env.contains("worker/exec"));
conn.register_imported(HandlerRegistration::new( conn.register_imported(HandlerRegistration::new(
external_spec("worker/exec"), external_spec("worker/exec"),
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), HandlerKind::Once(make_handler(|input, ctx| async move {
ResponseEnvelope::ok(ctx.request_id, input)
})),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,

View File

@@ -30,7 +30,7 @@ mod tests {
}; };
use alknet_call::registry::env::{OperationEnv, PeerRef}; use alknet_call::registry::env::{OperationEnv, PeerRef};
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, OperationRegistry, make_handler, HandlerKind, HandlerRegistration, OperationProvenance, OperationRegistry,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::{Identity, IdentityProvider}; use alknet_core::auth::{Identity, IdentityProvider};
@@ -113,7 +113,9 @@ mod tests {
) -> HandlerRegistration { ) -> HandlerRegistration {
HandlerRegistration::new( HandlerRegistration::new(
external_spec(name, acl), external_spec(name, acl),
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), HandlerKind::Once(make_handler(|input, ctx| async move {
ResponseEnvelope::ok(ctx.request_id, input)
})),
OperationProvenance::FromCall, OperationProvenance::FromCall,
composition_authority, composition_authority,
None, None,
@@ -123,14 +125,18 @@ mod tests {
fn echo_registry() -> Arc<OperationRegistry> { fn echo_registry() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("echo/run", AccessControl::default()), .register(HandlerRegistration::new(
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), external_spec("echo/run", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(make_handler(|input, ctx| async move {
None, ResponseEnvelope::ok(ctx.request_id, input)
None, })),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -454,9 +460,9 @@ mod tests {
conn.register_imported(HandlerRegistration::new( conn.register_imported(HandlerRegistration::new(
external_spec("ui/dragged", AccessControl::default()), external_spec("ui/dragged", AccessControl::default()),
make_handler(|input, ctx| async move { HandlerKind::Once(make_handler(|input, ctx| async move {
ResponseEnvelope::ok(ctx.request_id, serde_json::json!({ "echoed": input })) ResponseEnvelope::ok(ctx.request_id, serde_json::json!({ "echoed": input }))
}), })),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -654,7 +660,7 @@ mod tests {
}; };
conn.register_imported(HandlerRegistration::new( conn.register_imported(HandlerRegistration::new(
subscription_spec("events/stream"), subscription_spec("events/stream"),
handler, HandlerKind::Once(handler),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,

View File

@@ -249,7 +249,7 @@ mod tests {
}; };
use alknet_call::registry::env::OperationEnv; use alknet_call::registry::env::OperationEnv;
use alknet_call::registry::registration::{ use alknet_call::registry::registration::{
make_handler, HandlerRegistration, OperationProvenance, make_handler, make_streaming_handler, HandlerKind, HandlerRegistration, OperationProvenance,
}; };
use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility}; use alknet_call::registry::spec::{AccessControl, OperationSpec, OperationType, Visibility};
use alknet_core::auth::{AuthToken, Identity}; use alknet_core::auth::{AuthToken, Identity};
@@ -330,77 +330,92 @@ mod tests {
fn echo_registry() -> Arc<OperationRegistry> { fn echo_registry() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec("echo/run", AccessControl::default()), .register(HandlerRegistration::new(
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), external_spec("echo/run", AccessControl::default()),
OperationProvenance::Local, HandlerKind::Once(make_handler(|input, ctx| async move {
None, ResponseEnvelope::ok(ctx.request_id, input)
None, })),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
fn registry_with_restricted_op() -> Arc<OperationRegistry> { fn registry_with_restricted_op() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
external_spec( .register(HandlerRegistration::new(
"admin/run", external_spec(
AccessControl { "admin/run",
required_scopes: vec!["admin".to_string()], AccessControl {
..Default::default() required_scopes: vec!["admin".to_string()],
}, ..Default::default()
), },
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), ),
OperationProvenance::Local, HandlerKind::Once(make_handler(|input, ctx| async move {
None, ResponseEnvelope::ok(ctx.request_id, input)
None, })),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
fn registry_with_subscription() -> Arc<OperationRegistry> { fn registry_with_subscription() -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
let count = Arc::new(StdMutex::new(0u32)); let count = Arc::new(StdMutex::new(0u32));
let handler = make_handler(move |_input, ctx| { let handler = make_streaming_handler(move |_input, ctx| {
let counter = Arc::clone(&count); let counter = Arc::clone(&count);
async move { let mut c = counter.lock().unwrap();
let mut c = counter.lock().unwrap(); *c += 1;
*c += 1; let value = *c;
let value = *c; futures::stream::iter(vec![ResponseEnvelope::ok(
ResponseEnvelope::ok(ctx.request_id, serde_json::json!({ "n": value })) ctx.request_id,
} serde_json::json!({ "n": value }),
)])
}); });
registry.register(HandlerRegistration::new( registry
subscription_spec("events/stream"), .register(HandlerRegistration::new(
handler, subscription_spec("events/stream"),
OperationProvenance::Local, HandlerKind::Stream(handler),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
fn registry_with_discovery(inner: Arc<OperationRegistry>) -> Arc<OperationRegistry> { fn registry_with_discovery(inner: Arc<OperationRegistry>) -> Arc<OperationRegistry> {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
services_list_spec(), .register(HandlerRegistration::new(
services_list_handler(Arc::clone(&inner)), services_list_spec(),
OperationProvenance::Local, HandlerKind::Once(services_list_handler(Arc::clone(&inner))),
None, OperationProvenance::Local,
None, None,
Capabilities::new(), None,
)); Capabilities::new(),
registry.register(HandlerRegistration::new( ))
services_schema_spec(), .unwrap();
services_schema_handler(Arc::clone(&inner)), registry
OperationProvenance::Local, .register(HandlerRegistration::new(
None, services_schema_spec(),
None, HandlerKind::Once(services_schema_handler(Arc::clone(&inner))),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
Arc::new(registry) Arc::new(registry)
} }
@@ -543,22 +558,26 @@ mod tests {
#[tokio::test] #[tokio::test]
async fn handle_inbound_envelope_internal_op_yields_not_found() { async fn handle_inbound_envelope_internal_op_yields_not_found() {
let mut registry = OperationRegistry::new(); let mut registry = OperationRegistry::new();
registry.register(HandlerRegistration::new( registry
OperationSpec::new( .register(HandlerRegistration::new(
"secret/op", OperationSpec::new(
OperationType::Query, "secret/op",
Visibility::Internal, OperationType::Query,
serde_json::json!({}), Visibility::Internal,
serde_json::json!({}), serde_json::json!({}),
vec![], serde_json::json!({}),
AccessControl::default(), vec![],
), AccessControl::default(),
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), ),
OperationProvenance::Local, HandlerKind::Once(make_handler(|input, ctx| async move {
None, ResponseEnvelope::ok(ctx.request_id, input)
None, })),
Capabilities::new(), OperationProvenance::Local,
)); None,
None,
Capabilities::new(),
))
.unwrap();
let registry = Arc::new(registry); let registry = Arc::new(registry);
let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new()); let provider: Arc<dyn IdentityProvider> = Arc::new(StaticIdentityProvider::new());
let dp = dispatcher(registry, provider); let dp = dispatcher(registry, provider);
@@ -753,19 +772,18 @@ mod tests {
let dp = dispatcher(registry, provider); let dp = dispatcher(registry, provider);
let conn = Arc::new(CallConnection::new_overlay_only(identity("ws-peer"))); let conn = Arc::new(CallConnection::new_overlay_only(identity("ws-peer")));
let mut received = Vec::new(); let request = EventEnvelope::requested(
for i in 0..3 { "sub-0",
let request = EventEnvelope::requested( serde_json::json!({ "operationId": "/events/stream", "input": {} }),
format!("sub-{i}"), );
serde_json::json!({ "operationId": "/events/stream", "input": {} }), let out = handle_inbound_envelope(&dp, &conn, request)
); .await
let out = handle_inbound_envelope(&dp, &conn, request) .expect("response");
.await assert_eq!(out.r#type, EVENT_ERROR);
.expect("response"); assert_eq!(
assert_eq!(out.r#type, EVENT_RESPONDED); out.payload.get("code"),
received.push(out.id); Some(&serde_json::json!("INVALID_OPERATION_TYPE"))
} );
assert_eq!(received.len(), 3);
} }
#[tokio::test] #[tokio::test]
@@ -868,7 +886,9 @@ mod tests {
conn.register_imported(HandlerRegistration::new( conn.register_imported(HandlerRegistration::new(
external_spec("ui/dragged", AccessControl::default()), external_spec("ui/dragged", AccessControl::default()),
make_handler(|input, ctx| async move { ResponseEnvelope::ok(ctx.request_id, input) }), HandlerKind::Once(make_handler(|input, ctx| async move {
ResponseEnvelope::ok(ctx.request_id, input)
})),
OperationProvenance::FromCall, OperationProvenance::FromCall,
None, None,
None, None,
@@ -1044,28 +1064,27 @@ mod tests {
drive_ws_session(socket, &dp, &conn).await; drive_ws_session(socket, &dp, &conn).await;
}); });
let mut got = Vec::new(); let request = EventEnvelope::requested(
for i in 0..3 { "sub-ws-0",
let request = EventEnvelope::requested( serde_json::json!({ "operationId": "/events/stream", "input": {} }),
format!("sub-ws-{i}"), );
serde_json::json!({ "operationId": "/events/stream", "input": {} }), client
); .send_binary(serialize_envelope(&request).unwrap())
client .await;
.send_binary(serialize_envelope(&request).unwrap())
.await;
let msg = client.recv_timeout(Duration::from_secs(5)).await; let msg = client.recv_timeout(Duration::from_secs(5)).await;
match msg { match msg {
MockMsg::Binary(bytes) => { MockMsg::Binary(bytes) => {
let env: EventEnvelope = serde_json::from_slice(&bytes).unwrap(); let env: EventEnvelope = serde_json::from_slice(&bytes).unwrap();
assert_eq!(env.id, format!("sub-ws-{i}")); assert_eq!(env.id, "sub-ws-0");
assert_eq!(env.r#type, EVENT_RESPONDED); assert_eq!(env.r#type, EVENT_ERROR);
got.push(env.id); assert_eq!(
} env.payload.get("code"),
other => panic!("expected binary, got {other:?}"), Some(&serde_json::json!("INVALID_OPERATION_TYPE"))
);
} }
other => panic!("expected binary, got {other:?}"),
} }
assert_eq!(got.len(), 3);
client.close().await; client.close().await;
server_handle.await.ok(); server_handle.await.ok();

View File

@@ -1,7 +1,7 @@
--- ---
id: call/client/from-call-streaming-forwarding id: call/client/from-call-streaming-forwarding
name: Implement from_call streaming forwarding handler (Subscription → CallConnection::subscribe → StreamingHandler) name: Implement from_call streaming forwarding handler (Subscription → CallConnection::subscribe → StreamingHandler)
status: pending status: completed
depends_on: [call/registry/streaming-handler-handlerkind] depends_on: [call/registry/streaming-handler-handlerkind]
scope: narrow scope: narrow
risk: medium risk: medium
@@ -169,4 +169,4 @@ or the pending entry's removal handles it).
## Summary ## Summary
> To be filled on completion > Branched build_bundles on spec.op_type: Subscription → make_streaming_forwarding_handler (HandlerKind::Stream), Query/Mutation → existing make_forwarding_handler (HandlerKind::Once). Added CallConnection::subscribe_with_payload() mirroring call_with_payload (registers in PendingRequestMap, abort cascade wired). Streaming forwarding handler reuses build_forwarded_payload for forwarded_for + auth_token (ADR-032). composition_authority: None, scoped_env: None for FromCall streaming leaves. Added 7 unit tests covering all branches and forwarding behavior.

View File

@@ -1,7 +1,7 @@
--- ---
id: call/registry/invoke-streaming id: call/registry/invoke-streaming
name: Implement OperationRegistry::invoke_streaming() returning ResponseStream name: Implement OperationRegistry::invoke_streaming() returning ResponseStream
status: pending status: completed
depends_on: [call/registry/streaming-handler-handlerkind] depends_on: [call/registry/streaming-handler-handlerkind]
scope: narrow scope: narrow
risk: medium risk: medium
@@ -167,4 +167,4 @@ streams. The error envelope carries the `request_id` from the context.
## Summary ## Summary
> To be filled on completion > Added OperationRegistry::invoke_streaming() in crates/alknet-call/src/registry/registration.rs — the streaming dispatch path for Subscription operations. Same visibility + ACL checks as invoke() (provably identical security axis), then dispatches the StreamingHandler and returns its ResponseStream. Pre-handler errors (not-found, forbidden, INVALID_OPERATION_TYPE for non-Subscription ops) yield a single error ResponseEnvelope via stream::once, then end. Added 6 unit tests covering all paths (subscription dispatch, unknown op, query op cross-kind error, internal op from external, ACL denied, internal call using handler_identity).

View File

@@ -1,7 +1,7 @@
--- ---
id: call/registry/streaming-handler-handlerkind id: call/registry/streaming-handler-handlerkind
name: Introduce StreamingHandler, HandlerKind, ResponseStream types and migrate HandlerRegistration to HandlerKind name: Introduce StreamingHandler, HandlerKind, ResponseStream types and migrate HandlerRegistration to HandlerKind
status: pending status: completed
depends_on: [] depends_on: []
scope: broad scope: broad
risk: medium risk: medium
@@ -253,4 +253,4 @@ need the explicit `HandlerKind::Once(...)` wrap.
## Summary ## Summary
> To be filled on completion > Introduced StreamingHandler/ResponseStream type aliases and HandlerKind enum (Once|Stream) + make_streaming_handler() helper in registration.rs; added CallError::invalid_operation_type() (sixth protocol code, retryable: false) in wire.rs; flipped HandlerRegistration.handler to HandlerKind and changed new() signature; builder absorbs wrapping (with_local/with_leaf wrap Handler in Once for Query/Mutation, new with_local_streaming/with_leaf_streaming take StreamingHandler and wrap in Stream for Subscription) with kind/op_type mismatch validation; OperationRegistry::register() now returns Result<(), String> with clear mismatch message; invoke() errors on HandlerKind::Stream with INVALID_OPERATION_TYPE; OverlayOperationEnv::invoke_with_policy matches on HandlerKind (Stream -> INVALID_OPERATION_TYPE); migrated all ~95 HandlerRegistration::new() call sites to wrap in HandlerKind::Once(handler); updated two websocket subscription tests to expect INVALID_OPERATION_TYPE; added unit tests for invoke/register validation, make_streaming_handler, and overlay Stream-kind rejection. All verification passes (build, clippy -D warnings, test, fmt --check) for alknet-call + alknet-http.

View File

@@ -1,7 +1,7 @@
--- ---
id: http/adapters/from-openapi-sse-streaming id: http/adapters/from-openapi-sse-streaming
name: Implement from_openapi Subscription forwarding as StreamingHandler (SSE response → BoxStream<ResponseEnvelope>) name: Implement from_openapi Subscription forwarding as StreamingHandler (SSE response → BoxStream<ResponseEnvelope>)
status: pending status: completed
depends_on: [call/registry/streaming-handler-handlerkind] depends_on: [call/registry/streaming-handler-handlerkind]
scope: narrow scope: narrow
risk: medium risk: medium
@@ -240,4 +240,4 @@ HandlerRegistration::new(spec, handler, OperationProvenance::FromOpenAPI, None,
## Summary ## Summary
> To be filled on completion > Branched build_registration on op_type: Subscription → make_streaming_handler + forward_stream() (HandlerKind::Stream), Query/Mutation → existing make_handler + forward() (HandlerKind::Once). forward_stream() sends Accept: text/event-stream, streams SSE chunks via stream::unfold over response.bytes_stream(), reusing parse_sse_frames; each data: frame → one ResponseEnvelope::ok(), HTTP error → single ResponseEnvelope::error(), SSE end → ResponseStream ends. Removed stream_subscription() collect-all placeholder. Added 4 tests + updated integration test. 234 tests pass.