glm-5.1
5c820a41e9
Add 10 new tasks under tasks/architecture/ for Phase 0a (ADR writing): - 9 ADR tasks (026-034) with dependency-ordered structure - 1 review checkpoint task before Phase 0b spec writing ADR dependency graph (3 generations): Gen 1 (parallel): 026, 029, 030, 031, 032, 034 Gen 2 (depends on 029): 027, 028 Gen 3 (depends on 027+028): 033 Gen 4: review checkpoint Also mark all 34 prior implementation tasks as completed — they were finished but still showing as pending in the taskgraph.
1.7 KiB
1.7 KiB
id, name, status, depends_on, scope, risk, impact, level
| id | name | status | depends_on | scope | risk | impact | level | |||
|---|---|---|---|---|---|---|---|---|---|---|
| review/core-foundation | Review core foundation — transport traits, auth, error types, key loading | completed |
|
broad | low | phase | review |
Description
Review the core foundation layer before proceeding to server/client implementation. Verify that transport abstractions match architecture, auth logic is correct, errors follow the layered pattern, and key loading handles all spec'd formats.
This is the critical review before building the higher-level server and client components on top of these foundations.
Acceptance Criteria
- Transport trait matches transport.md: correct bounds, object-safety, describe() method
- TransportAcceptor matches transport.md: returns TransportInfo with correct metadata
- TCP, TLS, iroh transports all produce correct stream types per implementations table
- ACME integration with TLS works (or feature gates correctly prevent compilation without it)
- Key loading handles file paths and in-memory data, rejects PEM format
- authorized_keys parsing handles cert-authority entries with options
- Server auth: Ed25519 key matching (constant-time), cert-authority validation (signature, expiry, principal)
- Client auth: key pair presentation, Handler implementation
- Error types cover all four layers (transport, auth, channel, config)
- All tests pass:
cargo test --workspace cargo clippy --workspacepasses with no warnings
References
- docs/architecture/transport.md, docs/architecture/client.md, docs/architecture/server.md
Notes
To be filled by implementation agent
Summary
To be filled on completion