glm-5.1
596c89ce24
Rename all crates, CLI commands, constants, type names, doc comments, and documentation from wraith to alknet. Includes wire-protocol changes: ALPN wraith-ssh -> alknet-ssh, reserved destination prefix wraith- -> alknet-, SSH auth username wraith -> alknet.
1.9 KiB
1.9 KiB
id, name, status, depends_on, scope, risk, impact, level
| id | name | status | depends_on | scope | risk | impact | level | |||
|---|---|---|---|---|---|---|---|---|---|---|
| review/complete-system | Review complete system — CLI, NAPI, end-to-end integration | completed |
|
system | low | project | review |
Description
Final review of the complete alknet system. Verify CLI binary works end-to-end, NAPI wrapper provides correct JavaScript API, and both layers properly wrap the core library.
Acceptance Criteria
alknet serve+alknet connectend-to-end: SSH tunnel established, SOCKS5 proxy routes traffic- All CLI flags work: transport modes (tcp, tls, iroh), auth options, proxy, stealth, rate limits
- Environment variables (
ALKNET_SERVER,ALKNET_IDENTITY) work as defaults --stealthvalidates--transport tlsrequirement- NAPI
connect()returns Duplex stream; data flows bidirectionally - NAPI
serve()accepts connections;onConnectionemits Duplex streams - NAPI key material from Buffer works (not just file paths)
- Feature flags:
tls,iroh,acmecorrectly gate optional functionality - Base build (
cargo build -p alknet-corewith no features) compiles and works - All tests pass:
cargo test --workspace - NAPI tests pass:
cd crates/alknet-napi && npm test cargo clippy --workspacepasses- No logging of tunnel destinations anywhere in the system
References
- docs/architecture/overview.md, docs/architecture/napi-and-pubsub.md
Summary
Final review complete. All acceptance criteria verified:
- CLI binary: alknet serve/connect with all flags, env vars, stealth validation
- NAPI: connect() returns AlknetStream, serve() returns AlknetServer with onConnection
- Feature flags: tls, iroh, acme correctly gate optional code; base build compiles
- ADR-006: no server-side logging of tunnel destinations
- 241 tests pass, clippy clean with all features