glm-5.2
5941280bca
Address the root cause of rework-causing hedging: the architect was
put in a logical bind where it couldn't express justified uncertainty
('the pieces exist but the shape isn't clear yet'). The only options
were 'decide now' (premature) or 'deferred(scope)' (false — the
information isn't missing, it's un-synthesized). The agent picked
deferred(scope) with a circular blocking condition (OQ-64 blocked on
OQ-55, OQ-55 needs OQ-64) because there was no honest way to say 'I
can see the pieces but I can't see the shape.'
Changes to the architect role spec:
- Add deferred(unclear) state: the pieces exist but the composition
isn't clear; resolution requires investigation (work through
examples, POC), not waiting. Has an investigation target and an
impacts field.
- Add 'Impacts' field to the OQ format: what does this block
downstream? Be specific ('blocks the first hub deployment because
the hub dials workers' not 'blocks the hub crate'). The triage
signal that makes deferral urgency visible — the field that would
have made the AlknetClient circular hedge visible.
- Add circular-reasoning guard to self-review: 'check that your
blocking condition isn't a prerequisite of the thing you're
deferring.'
- Trim anti-patterns #9-#11 (hedging synonyms catalog, ~40 lines):
detection belongs in the reviewer, not the architect's self-review.
The architect is too close to its own reasoning to see its own
circular hedges.
- Trim door-types section (30→10 lines): keep the one-paragraph
summary, cut the elaboration.
Changes to the architecture-reviewer role spec:
- Add Decision Quality (F) category: false-deferral check
distinguishing three cases — (1) hedging on a resolved decision, (2)
false deferral / circular hedge (the blocking condition is a
prerequisite of the thing being deferred), (3) legitimate deferral.
- Add Impacts Field Coverage (G) category: check that unresolved OQs
have specific impacts fields.
- Note: the Decision Quality category is often the highest-value
check on poorly-defined projects — the architect cannot self-review
it (circular reasoning is invisible from inside the circle).
Retrofit existing OQs:
- Add Impacts field to all 16 unresolved OQs (10 deferred, 6 open).
- Update OQ-63 (TlsError shape) to reflect ADR-087's client-side
addition — the error type now covers both server and client
variants.
- Move OQ-65 (WebSocket carrying channels) to alknet-http theme
(done in prior commit; this commit adds its impacts field).
- Verified: no circular reasoning found in existing deferrals. The
AlknetClient hedge (OQ-64) was the circular one; it's already
resolved by ADR-087.
1.4 KiB
1.4 KiB
OQ-52: CallConnection::wait_for_close() for Supervision Loop
- Origin: crates/hub/README.md
- Status: open
- Door type: Two-way
- Priority: medium
- Impacts: Blocks clean supervision loop implementation — the hub's
supervise_workercurrently pollsaccept_bi()untilConnectionClosed(the interim). Aclosed()method would make this event-driven. - Resolution: Not yet decided.
The hub's worker supervision loop needs a way to await connection close so it
can call detach_peer and retry. Today CallConnection exposes connection()
(the underlying Connection) but not a "wait for run_loop exit" future.
Options:
- (a) Add a
closed()method toCallConnectionthat returns aFuture<Output = ()>resolving whenrun_loopexits. The dispatcher signals atokio::sync::Notifyon exit;closed()awaits it. - (b) Use a
tokio::sync::oneshotchannel created by the caller and passed to the dispatcher, signaled onrun_loopexit. - (c) Poll
connection().accept_bi()in a loop until it returnsConnectionClosed— works but is polling, not event-driven.
Option (a) is the cleanest: a method on CallConnection that any caller
(not just the hub) can use to await connection close. It is a small additive
change to alknet-call.
- Cross-references: ADR-067, crates/hub/README.md