tasks: decompose the review-002 fix round — eight dependency-ordered tasks

The general review (docs/reviews/002-protocol-core-implementation-review.md)
decomposed into the fix-round group, grouped so no session carries
both a code-fix vertical and the test sweep:

- fix-bind-reply2-reentry: C-1 (the BIND reply#2 re-entry guard) +
  D-1 (the reader decision) + N-6 (the constructor prologue
  helper) + S-2 (the reap doc line) — one consumer session
- fix-producer-gate-policy: C-3 (the explicit BIND gate input) +
  D-2 (the register/builder coverage) + S-1/N-2 (the stage doc
  lines) — one producer session
- fix-rfc1928-posture: N-1 (the keep-or-cut pass) + N-4 (the honest
  refusal vocabulary) — one fork posture session
- fix-hygiene-residue: D-3 (the ErrorDefinition declaration) +
  N-3 (the unreachable let-else) + N-9 (the is_mid_frame note)
- fix-coverage-residue: N-8's attributed line list — tests only,
  after the code fixes (final shapes)
- fix-test-helper-consolidation: N-5 — after the coverage round
- architecture/adr-014-idle-timeout-posture: C-2 — the ADR-sized
  decision, independent, before the doors exist
- review-fix-round-002: the closing checkpoint; the batch-2 gate

The review doc's disposition table now names the landed tasks.
N-7 is recorded-only (the review's own recommendation).
This commit is contained in:
glm-5.3-flash committed 2026-09-24 11:18:21 +00:00
1 parent d612d7f7f2
commit 6d14d35a54
9 files changed
+828 -10

No files matched your search

@@ -838,17 +838,25 @@ without this note.
# Suggested Disposition
| Batch | Items | Shape |
|---|---|---|
| 1 — correctness | C-1, C-3 (+ the D-2 test) | small code + tests; one session |
| 2 — hygiene | D-1, D-3, N-1 (cut list), N-3, N-4 | posture + small deletions/rewordings |
| 3 — coverage | D-2, N-8 (the split/stage-exit/read_reply2 items) | tests only; folds into batch 1's session |
| fold-in | N-2 (wire.md line), N-5, N-6 (when next touching those files), N-7/N-9 (notes, no action) | opportunistic |
Decomposed 2026-09-24 into the fix-round task group
(`tasks/implementation/fix-*.md` + the ADR + the closing review) —
the grouping follows the review's batches, adjusted so no session
carries both a code-fix vertical and the test sweep:
C-2 is its own ADR-sized decision (the idle-timeout surface) and
should ride the batch-2 planning, not this review's fix round — it
is a *decision to make before the doors exist*, not a defect in the
core.
| Task | Items | Shape |
|---|---|---|
| `implementation/fix-bind-reply2-reentry` | C-1, D-1, N-6, S-2 | the consumer correctness fix + the same-file residues |
| `implementation/fix-producer-gate-policy` | C-3, D-2, S-1, N-2 | the gate-policy fix + the register test + the doc lines |
| `implementation/fix-rfc1928-posture` | N-1, N-4 | the keep-or-cut pass + the refusal vocabulary |
| `implementation/fix-hygiene-residue` | D-3, N-3, N-9 | the error-schema declaration + one-line postures |
| `implementation/fix-coverage-residue` | N-8 (D-2's test rides the producer task) | tests only; after the code fixes |
| `implementation/fix-test-helper-consolidation` | N-5 | after the coverage round (final population) |
| `architecture/adr-014-idle-timeout-posture` | C-2 | the ADR-sized decision; independent, before the doors |
| `implementation/review-fix-round-002` | — | the closing checkpoint; the batch-2 gate |
N-7 is recorded-only (no action — the review's own
recommendation); its bound-re-litigation note lives in the review
itself.
## References