Fourth review round (ADR-023): encode_payload typed (Codec), numeric-argument domains pinned by kind, plain-path SQLite open (URI flag dropped, D-29), watcher cadence posture — waves-1-2 general-review findings

This commit is contained in:
glm-5.3-flash committed 2026-10-08 10:17:56 +00:00
1 parent ee7871d25d
commit 44637eea5b
11 files changed
+502 -22

No files matched your search

+22 -4
View File
@@ -1,6 +1,6 @@
---
status: draft
last_updated: 2026-10-07 (third review round — findings resolved as ADR-021; question set remains closed)
last_updated: 2026-10-08 (fourth review round — waves-1–2 general-review findings resolved as ADR-023; question set remains closed)
---
# alkstore — Open Questions
@@ -61,8 +61,22 @@ an ADR-010/ADR-019 `Job`-struct disagreement, an unvalidated
drop disposition, unpinned `EventReceiver` error/close arms), all
decidable from decided material, resolved directly as
[ADR-021](decisions/021-tx-reads-and-value-shape-fixes.md) (tx-read
methods on `TxHandle`, `claimed_at` restored, schedule queue-argument
validation, drop = rollback, receiver arms pinned).
methods on `TxHandle`, `claimed_at` restored, schedule queue-argument
validation, drop = rollback, receiver arms pinned). **Fourth
review round (2026-10-08, the waves-1–2 general review — the
first round after implementation began):** the code review's four
decision-needing findings (`encode_payload`'s empty-Vec failure
arm, `claim_batch(n <= 0)`'s `LIMIT`-dialect semantics, the
inherited `SQLITE_OPEN_URI` flag, the 1 ms watcher-poll default)
were likewise all decidable from decided material — resolved
directly as
[ADR-023](decisions/023-fourth-review-round.md) (the helper
fallible with `Codec`; numeric-argument domains pinned by kind —
extents clamp empty, durations reject, boundaries total — a
core-contract amendment, since engine-side divergence here would
break engine-agnostic composition; plain-path `open`; the 1 ms
default standing with the cadence carried onto `SqliteOpts`). No
new open questions; the register stays closed.
Resolved questions stay listed with their resolution; they are not
deleted.
@@ -537,4 +551,8 @@ narrowed to the pinning work its own record already scoped.)*
None. **The open question set is empty** — every OQ above is resolved
(2026-10-04 through 2026-10-06, ADR-001 through ADR-018). Phase 1's
remaining work is architecture review closure and the implementation
phase's gates; no external arrivals are being waited on.
phase's gates; no external arrivals are being waited on. The review
rounds after closure (2026-10-06 second, 2026-10-07 third, 2026-10-08
fourth) likewise produced no new OQs — their findings resolved
directly as ADR-019/020, ADR-021, and
[ADR-023](decisions/023-fourth-review-round.md) respectively.