Fourth review round (ADR-023): encode_payload typed (Codec), numeric-argument domains pinned by kind, plain-path SQLite open (URI flag dropped, D-29), watcher cadence posture — waves-1-2 general-review findings

This commit is contained in:
glm-5.3-flash committed 2026-10-08 10:17:56 +00:00
1 parent ee7871d25d
commit 44637eea5b
11 files changed
+502 -22

No files matched your search

@@ -1,5 +1,17 @@
# General review — waves 1 and 2
> **Post-review note (2026-10-08):** the four decision-needing
> findings below are resolved as
> [ADR-023](../architecture/decisions/023-fourth-review-round.md) —
> N-2 (`encode_payload` typed, `Codec`), M-2 (numeric-argument domains
> pinned contract-side, extents clamp empty — decided broader than
> this report's engine-layer recommendation: the same dialect hazard
> exists on the stream reads, and domains must be engine-uniform),
> N-4 (URI flag dropped, a registered fork delta), N-6 (1 ms default
> stands, cadence carried onto `SqliteOpts`). The task-carried items
> (lint removal, wave-5 suite adds, wave-6 N-1 review) stand as
> ordered in §7.
- **Reviewer**: opencode (glm-5.3-flash)
- **Scope**: general review of everything landed by waves 1–2 (11 tasks, commits
`34e0b97..af5b59e`) — security posture, code smells, contract adherence,