review-004-fixes gate passed — all sixteen dispositions verified by code-read against the review's failure mechanisms (armor/state-machine/hardening/decision changes structurally match their tasks' Notes of record; every injected-panic/death/interleave test drives the real mechanism); no regressions among the review-004 inline fixes' pinned postures (tick drop-+-replenish, raw tx-form seed + mem has_offset_row, MAX_SLEEP_S caps, saturating claim stamp, register-failure unregisters, poison-recovery idiom, encode depth 127); records landed — review 004's recorded-findings items annotated with dispositions/task pointers (record reads closed), implementation.md gains the fix-batch review-rounds entry, task-file audit done with three minor hygiene defects fixed inline (stale placeholder lines incl. pre-existing ones in review-wave-3/release-readme, completed-AC checkboxes left unticked on five batch tasks, the gate description's fifteen→sixteen task count); gates green this session: build, server-less workspace tests, full live pg column vs harness pglo-poc (135+26+9), clippy -D warnings, fmt --check, fuzz corpus replay 6/6, wasm32 mem check, doc gate zero warnings, taskgraph validate (96); task -> completed

This commit is contained in:
glm-5.3-flash committed 2026-10-11 15:25:26 +00:00
1 parent 23cf0e7046
commit 609dc3b39c
12 files changed
+318 -58

No files matched your search

@@ -49,18 +49,18 @@ a mid-run close exits with the closed `Database` classification, never
## Acceptance Criteria
- [ ] The pg renew arm implements the landed arm set: `Ok(false)` →
- [x] The pg renew arm implements the landed arm set: `Ok(false)` →
`LeadershipLost` unchanged; `Err(e)` propagates unchanged (no
flattening) — no re-deciding; any discrepancy with the sqlite
task's decisions of record recorded, not deviated around
- [ ] Both arms pinned by tests against the harness server (the
- [x] Both arms pinned by tests against the harness server (the
closed-store arm and the genuine-loss arm, modeled on the
sqlite task's two pins)
- [ ] The ADR-009 §1 / core-contract annotations verified to read
- [x] The ADR-009 §1 / core-contract annotations verified to read
engine-neutral (they were landed as family-wide; cite them —
only pg-specific doc text needs touching, e.g.
engine-postgres.md's scheduler row if it describes the arm)
- [ ] `cargo test -p alkstore-postgres` (harness server), clippy
- [x] `cargo test -p alkstore-postgres` (harness server), clippy
`-D warnings`, fmt clean; workspace gates green server-less
## References