Wave-2 review gate: scheduler fire expires resolution fix (D-27, ADR-020 §2), pressure-test lock quality (D-28), lineage diff re-verified clean (task review-wave-2)
This commit is contained in:
1 parent
6618e13c3a
commit
af5b59ec8e
4 files changed
+153
-16
No files matched your search
@@ -82,8 +82,10 @@ only, not committed — the wave-2 review's primary input), and every
|
||||
divergence it surfaced is either a register entry below (D-21..D-26,
|
||||
appended; D-12 annotated in place) or a fixed omission (the
|
||||
lineage-less placeholder test in `ops.rs`'s pressure suite, removed).
|
||||
No unregistered divergence remains. Cherry-picks: empty at scaffold,
|
||||
append-only forever.
|
||||
No unregistered divergence remains. The wave-2 review gate
|
||||
(`review-wave-2`) re-ran the full-coverage lineage diff (clean —
|
||||
everything register-addressable) and appended D-27/D-28 for its two
|
||||
fixes. Cherry-picks: empty at scaffold, append-only forever.
|
||||
|
||||
| ID | Category | What | Where | Why | Lineage |
|
||||
|----|----------|------|-------|-----|---------|
|
||||
@@ -113,6 +115,8 @@ append-only forever.
|
||||
| D-24 | hygiene | `real_to_i64` boundary error text re-owned ("honker:" prefix → "alkstore:"; the lineage's better-sqlite3-facing sentence elided per D-15) | ops.rs (`real_to_i64`) | D-19's re-owning pattern at the error-string layer | ours |
|
||||
| D-25 | hygiene | watcher thread name "honker-update-poll" → "alkstore-update-poll" | watcher.rs (spawn path) | D-19's re-owning pattern at the thread-name layer | ours |
|
||||
| D-26 | hygiene | `volume_serial_number as u64` → `u64::from(volume_serial_number)` in `VolumeIdentity` (clippy lint conformance, zero behavior change) | watcher.rs (`stat_identity` region) | family clippy `-D warnings` gate | ours |
|
||||
| D-27 | re-derivation | wave-2 review fix — `scheduler_tick`'s fire enqueue resolved the schedule row's relative `expires_s` into the absolute row `expires_at` (`now + s` at the fire transaction, one clock read) instead of passing the relative value through; regression test pins a fired job's `expires_at = fire-instant + s` and its claimability. The pre-fix pass-through would have produced rows expired in 1970 under any `expires_s` schedule | `queue_ops.rs` (`scheduler_tick`, fire-expiry resolution + test) | ADR-020 §2 (relative `expires` → resolved absolute row value, resolved at enqueue against the single clock) — D-12's landed state carried the lineage's `expires_s` field shape without carrying the lineage's enqueue-side resolution; wave-2 review (task review-wave-2) re-derivation spot-check found it | ours |
|
||||
| D-28 | hygiene | wave-2 review fix — the cross-mechanism pressure test's lock-churn branch exercised a per-producer lock name (literal `"p{producer}"` had no interpolation, so all producers contended on one name) with its result swallowed via `.unwrap_or(0)`; now interpolates, releases periodically, propagates errors | `ops.rs` (pressure test, lock branch) | test-quality only (no lineage counterpart, no library code touched); `fork-provenance-and-floor`'s ported-surface pressure intent | ours |
|
||||
|
||||
### Cherry-picks
|
||||
|
||||
|
||||
Reference in new issue
Block a user