---
id: review-wave-6
name: Review gate — wave 6 (mem engine)
status: pending
depends_on: [mem-engine-integration, pg-fix-scheduler-tick-seam]
scope: moderate
risk: low
impact: phase
level: review
tags: [wave-6, review]
---

## Description

The wave-6 review gate (the plan's §Review gates, wave 6; the
born-pinned gate). Code-read the `alkstore-mem` engine against the
contract and the pinned ADR-024 text, and audit:

1. **Conformance read**: engine-vs-contract line by line, mirroring
   the wave-3/4 gate pattern — every trait surface against
   core-contract.md and the pinning ADRs (007/008/009/010/015/019/
   020/021/023), the tx overlay against ADR-024 + engine-mem.md §The
   tx overlay (commit-merge atomicity, wake-at-commit, drop = discard,
   panic-through-unwind).
2. **The third column as the compatibility instrument born pinned**:
   the mem column's wiring read row-by-row against the discharge map
   (which rows carry, which engine-shaped rows omit and why — the
   asymmetry classification, ADR-024 §3); `PayloadTooLarge`
   non-occurrence arm present; three-way arithmetic equivalence
   actually asserted green (backoff curve, opts resolution — the
   ADR-012 §2 one-owner rule's third owner), plus the derived-queue
   naming row composing identically.
3. **wasm32 acceptance audit** (ADR-024 §5): the compile gate clean,
   tokio feature subset verified on the manifest, no blocking calls
   in mem internals, the current-thread flavor actually enforced by
   the column's tests.
4. **engine-mem.md read against the implemented engine**; the
   deployment matrix's mem rows (`deployment.md`, landed with ADR-024)
   still true as implemented (honesty carriers: identity + docs +
   matrix — nothing runtime invented). Gate may flip `engine-mem.md`
   to `stable` if the read is clean.
5. **The rider closed**: `pg-fix-scheduler-tick-seam`'s arms verified
   (review 003 Finding 1 discharged into this window; Findings 2–3
   confirmed still parked for wave 7).
6. **Contract-window discipline**: the class-1 amend-in-place window
   is still open — any wobble the third implementation surfaced must
   appear as resolved ADR text (or be recorded as a finding with its
   disposition), not as a silent divergence between suite row and
   engine behavior.

## Acceptance Criteria

- [ ] Full conformance code-read recorded (findings + dispositions
      inline in this task's Notes, mirroring review-wave-3/4 style)
- [ ] Suite mem column green on host, 25-row set wired per the
      classification; three-way equivalence rows green
- [ ] wasm32 compile gate + feature-subset + current-thread flavor
      verified, recorded
- [ ] The rider's arms verified; Finding 1 disposition recorded
- [ ] Workspace gates re-run green this session (`cargo build`,
      `cargo test`, clippy `-D warnings`, fmt)
- [ ] `engine-mem.md` disposition decided (stable flip or follow-up)
      and `implementation.md`'s wave-6 row updated

## References

- docs/plans/implementation.md §Wave 6, §Review gates (wave 6 entry)
- docs/architecture/decisions/024-mem-engine.md (the charter this
  gate audits code against)
- docs/architecture/engine-mem.md
- tasks/review-wave-3.md / tasks/review-wave-4.md (the gate pattern)
- docs/reviews/003-wave-5-general-review.md (Finding 1's disposition
  trail; Findings 2–3's wave-7 park)

## Notes

> To be filled by implementation agent

## Summary

> To be filled on completion