alkstore/tasks/review-wave-8.md

id, name, status, depends_on, scope, risk, impact, level, tags

id	name	status	depends_on	scope	risk	impact	level	tags
review-wave-8	Review gate — wave 8 (release readiness)	pending	docs-frontmatter-cleanup release-renumber-sweep release-crate-docs release-contract-window-close release-n1-growth-posture release-findings-2-3-disposition release-flake-investigation release-deployment-matrix release-readme release-publish-prep	broad	low	project	review	wave-8 review-gate

Description

The wave-8 review gate (the plan's §Review gates pattern; the pre-release gate). Audit the release-readiness pass as landed:

1. Docs honesty audit: the README's claims traced to specs (the readme task's trace list re-verified by spot-read); the deployment matrix's rows read true as implemented across the three engines; the crate docs' posture claims consistent with the matrix; the env-boundary sentence present and the grep result current.
2. Contract-window closure audit: every wave-6 recorded observation disposed (wake-ordering decision landed per the user's call; the ADR-023 §2 classifications; the try_recv shape; the get_job prose; the mem-arithmetic disposition); every landed amendment dated + cited; the class-1 window's termination recorded — ADR-017 §2's "terminates permanently at the core crate's first release" becomes a fact at this gate: the record states the window closes with the first publish, and no undisposed class-1 candidate remains.
3. N-1 + Findings 2–3 dispositions audited: the growth-posture acceptance is a decision of record (not a shrug); the findings' landed-vs-parked dispositions recorded so the inventory is closed.
4. Flake-watch outcome audited: the investigation's conditions matrix + disposition read; if a follow-up fix task was created, its status is visible (a live engine bug blocks the release blessing — the gate says so explicitly rather than publishing over it).
5. Publish-prep audit: cargo package evidence per crate; the exclusion verification re-run this session (file lists of the built .crates — no fuzz/sidecar/suite leakage); the publish checklist of record complete and mechanical.
6. Frontmatter + records hygiene: the parse sweep re-run (zero invalid frontmatters under docs/); the renumber sweep's disposition list spot-checked (stale wave-7 references gone or annotated; genuine fuzz-wave references intact).
7. All gates re-run green this session: cargo build, cargo test, cargo clippy --all-targets -- -D warnings, cargo fmt --check, the fuzz corpus-replay gate, the wasm32 check, and the doc gate (cargo doc --no-deps warning-free).
8. Spec flips + records: the remaining draft architecture docs (core-contract.md, overview.md, queues.md, deployment.md, the architecture README) flip to stable with dated gate annotations — the release-facing spec set is stable at the gate, mirroring the wave-5/6 engine-spec flips; docs/architecture/README.md's Current State refreshed (waves 6–8); implementation.md's wave-8 row updated + a review-rounds entry; task files audited (all wave-8 dependencies completed, Notes/Summary filled).

Acceptance Criteria

• Docs honesty audit recorded (README traces, matrix rows, crate docs, env boundary)
• Contract-window closure audited; the class-1 termination record landed; no undisposed class-1 candidate remains
• N-1 + Findings 2–3 dispositions audited as decisions of record
• Flake-watch outcome audited; any follow-up task's blocking status stated explicitly
• Publish-prep audit recorded (package evidence + exclusion re-run + checklist complete)
• Frontmatter parse sweep + renumber-sweep spot-check green
• All gates re-run green this session (incl. fuzz replay + wasm + doc gates)
• Spec flips + records landed; implementation.md updated; task files audited

References

• docs/plans/implementation.md §Wave 8, §Review gates
• docs/architecture/decisions/017-contract-versioning.md §2 (the window termination this gate records)
• tasks/review-wave-5.md §Notes 6 (the flake ledger)
• tasks/review-wave-6.md §Recorded findings (the dispositions this gate audits)
• tasks/review-wave-7.md (the parked exclusion verification)
• tasks/review-wave-5.md / tasks/review-wave-6.md (the gate pattern)

Notes

To be filled by implementation agent

Summary

To be filled on completion