docs: add review #002 (follow-up on the 2026-09-05 resolution session)

Documents the post-hoc review of the five resolution commits:
- R1 (ADR-009 missing) and R2 (stale L1-redesign docs) — resolved in
  37ae07a
- R3 — install-time identity snapshot on the channels path, closed as
  intended (hub-proxy design predating the alkcall split; constraint
  recorded: registries must stay per-connection)
- R4 (silent death on the parse-failure path, no error frame) and R5
  (NegotiationSerialize mislabel on the fail-fast path) — open,
  deferred to the first post-1.0 error-surface decision
Also cross-links review #001's L1 resolution to ADR-009 and review #002.

Verification: cargo test 93 lib pass; fmt clean.
This commit is contained in:
2026-09-05 08:08:22 +00:00
parent 37ae07a4d4
commit 5b608117ff
2 changed files with 293 additions and 1 deletions
+5 -1
View File
@@ -575,7 +575,8 @@ check).
### Resolution (2026-09-05, L1 + L3 — the channels consumer path)
**L1 — resolved via the publisher decision: the channels path carries no
second negotiation frame (ADR-009 in `docs/architecture/decisions/`).**
second negotiation frame (ADR-009 in `docs/architecture/decisions/`,
added post-session in `37ae07a` — see review #002 R1).**
Two upstream alkcall changes were prerequisites (the review's premise
that the registry "validates `input`" was wrong — alkcall never
@@ -709,6 +710,9 @@ None — the review is fully resolved.
commit on `main` at review time). The resolution section above
reflects the tree at commit `9944153` and the 2026-09-05 L1+L3
resolution.
- A follow-up review of the 2026-09-05 resolution commits (including
this ADR's addition and the L1 redesign's doc fallout) is at
`docs/reviews/002-post-session-review.md`.
- The coverage numbers are from `cargo llvm-cov --all-features` on the
same tree. The `--show-missing-lines` output was used to attribute
gaps; the full report is at `target/llvm-cov/html`.