alktunnels/tasks/tunnels/review-core-crates.md at 50909ab1ca5b4063ef10937a338aa81a501325c5

Files

T

glm-5.3-flash 69498b79cc tasks: Phase 2 decomposition — 12-task dependency graph for v1

tasks/architecture/:
- oq-promotion-sync (planning): back-pointers from the phase-0 ledger
  + AGENTS.md to the promoted OQ tracker (the convergence checklist's
  final half)
- oq-tn-14-tracker: the Safe-Exit external-trigger tracker task for
  OQ-TN-14 (unix/stdio placement; [external-trigger, deferred-oq],
  risk trivial, level research per the two-halves rule)

tasks/tunnels/ (the implementation graph, 8 generations):
- crate-init: module skeleton per overview.md's module map
- params: TunnelParams + open-op spec (ADR-001 wire-stable surface)
- wire-codec: frame_datagram/DatagramReader + the 8 POC-pinned test
  families (ADR-003)
- producer-open-op: establisher (dial, plan flow R-01) + pump handler
  (pump_bidi inline R-02) + registration; POC-ported integration tests
- consumer-session: TunnelSession (open/adopt, data planes, teardown
  matrix — ADR-005); generalizes the reverse POC's ReverseTunnel
- producer-listen: the listen establisher + AcceptQueue contract
  (ADR-004 shape 2)
- local-socket-halves: the local feature (TCP/UDP/unix halves
  functions; truncation fail-loud per OQ-TN-13; unix ships per
  OQ-TN-14's lean-yes, stdio deferred)
- review-core-crates: review-injection point before the downstream
  tasks build on the high-risk producer/consumer shapes
- end-to-end-suite: 6 suites / >=20 tests consolidating both POC
  suites against the public API (the spec's executable form)
- review-impl: the phase-gate review (wire/API/conventions/docs sync;
  findings doc per the alkhttp/alkcall house pattern)

Graph verified with taskgraph: 12 tasks valid, no cycles, 8
generations; critical path = oq-promotion-sync -> crate-init ->
params -> wire-codec -> producer-open-op -> consumer-session ->
review-core-crates -> review-impl; risk concentrated in the two
session tasks (both POC-validated); parallel groups available at
generations 1 and 6

2026-09-07 19:07:20 +00:00

1.8 KiB

Raw Blame History

id, name, status, depends_on, scope, risk, impact, level, tags

name

status

depends_on

scope

risk

impact

level

Description

Review injection point (SDD §Review Injection — "high-risk tasks: review before proceeding"): tunnels/producer-open-op and tunnels/consumer-session are the two risk: high, impact: phase tasks and the crate's wire/API surface. Review them BEFORE tunnels/local-socket-halves and tunnels/end-to-end-suite build against the shapes — a wire or API mistake found here costs one task's rework; found later it costs three.

Checklist (focused — the full gate is `tunnels/review-impl`)

Wire conformance of what landed (params/codec/open-op vs wire.md + ADR-001/003) — the one-way-door check.
The pump handler shape: pump_bidi inline, JoinHandle tracks the data plane (R-02) — the POC's hang-bug class must be structurally absent.
Teardown matrix of TunnelSession — close/join/Drop soundness, no leaks (the W3 class).
No substrate types outside src/local/-to-be; no hand-rolled two-pump loops; no side-channel handoff.
Integration tests green + repeat-run stable (3×).

Deliverable: findings inline here (Notes/Summary); criticals block the downstream tasks (Safe Exit); majors create remediation notes for tunnels/review-impl to re-check.

Acceptance Criteria

The 5 checklist items each with a verdict
Criticals (if any) resolved before proceeding; majors logged

References

docs/architecture/ (the spec set under review)
docs/sdd_process.md §Review Injection

Notes

Agent fills during implementation.

Summary

Agent fills this on completion.

1.8 KiB Raw Blame History Unescape Escape