 glm-5.3-flash
|
27be01af93
|
Add review #006: 0.3.0 post-implementation review
Audits the shipped 0.3.0 code (commits ff85258..9949f91) for
correctness, untrusted-input discipline, 0.2.0 parity, code smells,
and coverage. Gates re-run green in-session (474 tests, clippy -D
warnings, doc, wasm32, publish --dry-run); coverage measured with
cargo-llvm-cov (89.59% lines / 84.80% fn).
Findings:
- H1: huge declared array count OOM-aborts validate_bytes (three
Vec::with_capacity(count) sites; release-blocking)
- H2: cyclic $ref stack-overflows OffsetMap::compute /
LayoutBuilder::new / materialize_aligned when driven standalone
(engine gated, public walkers not; parity-preserved)
- H3: field-disc unions — builder (variant-only layout), reader
(disc at union start), and materializer (position-correct shared
walk) disagree on layout and discriminator position; needs a
convention decision
- M1: ADR-006 check misses non-final inline Record fields (probe-
confirmed)
- M2: aligned-mode record fields untested end-to-end
- M3: read_field's aligned Struct arm is unreachable dead code
- M4: coverage weak spots (materialize.rs 64.5% lines; aligned
nested-struct recursion 0 executions through any test)
- L1-L6, N1: stride unwrap_or_default conflation, Null-schema
placeholder, dead locals, linear-scan get, variant_start doc gap,
missing field-disc roundtrip test, tunion/reader disc-kind split
Includes an operational warning: the H1/H2 reproducers OOM/stack-
abort the test harness — reproduce in an isolated process only.
Verification: file-only change, no code touched; suite green before
commit.
|
2026-09-02 15:06:26 +00:00 |
|