alkdev/flowgraph
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

resolve mechanical architecture review issues (C-01,C-02,C-03,W-01,W-09,W-10,W-12)

Browse Source 
- C-01: fix broken README link (call-graph-runtime.md → call-graph.md)
- C-02: add CallEdgeAttrs union type alias in schema.md
- C-03/W-12: rename TypedEdgeAttrs → OperationEdgeAttrs for consistent
  {GraphType}EdgeAttrs naming pattern, update all references
- W-01: standardize terminology — prerequisites=structural/graph,
  preconditions=reactive/computed, rename WorkflowNode.prerequisites
  to preconditions, rename computePrerequisites to computePreconditions
- W-09: update ADR-001/002/003 status from Proposed to Accepted
- W-10: clarify call graph mutation API — addCall creates triggered
  edges automatically, addDependency creates depends_on edges
- update review checklist with resolved items
This commit is contained in:
glm-5.1
2026-05-19 11:09:06 +00:00
parent 037dfec44b
commit c5e649cc9f
11 changed files with 47 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
docs/reviews/001-architecture-gap-analysis.md
View File

@@ -270,16 +270,16 @@ Strong separation of concerns argument. The consequence "The hub must keep its s
When addressing these issues, use this checklist to track progress:
- [ ] C-01: Fix README cross-reference link
- [ ] C-02: Add `CallEdgeAttrs` type alias to schema.md
- [ ] C-03: Resolve `OperationEdgeAttrs` vs `TypedEdgeAttrs` naming
- [x] C-01: Fix README cross-reference link
- [x] C-02: Add `CallEdgeAttrs` type alias to schema.md
- [x] C-03: Resolve `OperationEdgeAttrs` vs `TypedEdgeAttrs` naming (renamed `TypedEdgeAttrs` → `OperationEdgeAttrs`)
- [ ] C-04: Specify failure propagation semantics in reactive-execution.md
- [ ] C-05: Create FlowGraph public API document
- [ ] C-06: Document `<Map>` component in workflow-templates.md
- [ ] C-07: Specify `Conditional` else-branch behavior
- [ ] C-08: Specify `WorkflowReactiveRoot` ↔ `ReactiveHostConfig` ownership
- [ ] C-09: Create consumer integration guide
- [ ] W-01: Standardize `prerequisites` vs `preconditions` terminology
- [x] W-01: Standardize `prerequisites` vs `preconditions` terminology (prerequisites=structural/graph, preconditions=reactive/computed)
- [ ] W-02: Add reactive error boundary semantics
- [ ] W-03: Complete `ReactiveContext` interface definition
- [ ] W-04: Add template composition rules
@@ -287,10 +287,10 @@ When addressing these issues, use this checklist to track progress:
- [ ] W-06: Document signal/effect disposal lifecycle
- [ ] W-07: Consider ADR-004 for "no schema version"
- [ ] W-08: Specify type compatibility depth
- [ ] W-09: Update ADR statuses to Accepted
- [ ] W-10: Clarify call graph mutation API (`addDependencyEdge`)
- [x] W-09: Update ADR statuses to Accepted
- [x] W-10: Clarify call graph mutation API (clarified `addCall` creates `triggered` edges automatically, `addDependency` creates `depends_on` edges)
- [ ] W-11: Add performance characteristics section
- [ ] W-12: Standardize edge attribute naming pattern
- [x] W-12: Standardize edge attribute naming pattern (now `{GraphType}EdgeAttrs`: `OperationEdgeAttrs`, `CallEdgeAttrs`, `TemplateEdgeAttrs`)
- [ ] S-01: Getting Started walkthrough document
- [ ] S-02: Flow diagrams for template rendering pipeline
- [ ] S-03: Node status state machine diagram