docs: complete final review, mark iroh as blocked

This commit is contained in:
2026-05-08 08:12:21 +00:00
parent a4f32c66e8
commit 96ec2456e1
2 changed files with 32 additions and 4 deletions

View File

@@ -1,7 +1,7 @@
--- ---
id: deferred-iroh-adapters id: deferred-iroh-adapters
name: Iroh spoke and hub adapters (deferred) name: Iroh spoke and hub adapters (deferred)
status: pending status: blocked
depends_on: [review-worker-adapter] depends_on: [review-worker-adapter]
scope: system scope: system
risk: critical risk: critical

View File

@@ -1,7 +1,7 @@
--- ---
id: final-review-and-ci-validation id: final-review-and-ci-validation
name: "Final review: full test suite, build, and CI readiness" name: "Final review: full test suite, build, and CI readiness"
status: pending status: completed
depends_on: [review-worker-adapter, integration-test-ws-client-server] depends_on: [review-worker-adapter, integration-test-ws-client-server]
scope: moderate scope: moderate
risk: low risk: low
@@ -44,8 +44,36 @@ Final review before considering the package ready for use (excluding Iroh, which
## Notes ## Notes
> To be filled by implementation agent ### Final Review Report
**Build**: All 5 entry points produce correct ESM + CJS + declarations. tsup with splitting produces shared chunks correctly.
**Lint**: `tsc --noEmit` passes cleanly.
**Tests**: 242 tests across 8 files, all passing.
**Coverage**:
- `create_pubsub.ts`: 100% (all)
- `operators.ts`: 100% (all)
- `event-target-redis.ts`: 97.36%
- `event-target-websocket-client.ts`: 97.75%
- `event-target-websocket-server.ts`: 92.44%
- `event-target-worker.ts`: 51.26% (thread side untested — requires Worker env)
- `index.ts` / `types.ts`: 0% (barrel/type-only, expected)
- `repeater.ts`: 67.35% (inlined, complex async iterator)
- Overall: 81.99% statements, core modules > 90%
**Sub-path exports**: All 4 adapters have correct exports in package.json (ESM + CJS + d.ts + d.cts), tsup config entries, and barrel re-exports in index.ts.
**No runtime dependencies**: Confirmed. `dependencies` is `{}`. Repeater is inlined. `ioredis` is optional peer dep.
**Package consumption**: All sub-path imports resolve correctly:
- `@alkdev/pubsub` → core + operators + all adapters
- `@alkdev/pubsub/event-target-redis` → Redis adapter
- `@alkdev/pubsub/event-target-websocket-client` → WS client
- `@alkdev/pubsub/event-target-websocket-server` → WS server
- `@alkdev/pubsub/event-target-worker` → Worker adapter
## Summary ## Summary
> To be filled on completion **Final review PASSED.** 242 tests, build produces correct dual ESM/CJS output with all 5 entry points, type-check clean, coverage >80% (core modules >90%), no runtime dependencies, peer dep isolation correct, all sub-path exports configured. Package is ready for use (Iroh adapters deferred).