---
id: review-core-and-redis
name: Review core module tests and Redis adapter
status: pending
depends_on: [core-pubsub-tests, core-operators-tests, redis-adapter-tests]
scope: narrow
risk: low
impact: phase
level: review
---

## Description

Review checkpoint before moving to new adapter implementations. Verify that:
- Core tests cover the `createPubSub` contract thoroughly (publish, subscribe, topic scoping, `__` rejection, cleanup)
- Operator tests cover all 13 operators with edge cases
- Redis adapter tests pass reliably with real Redis or mock
- Code follows architecture conventions (no unnecessary comments, MIT headers on forked files)
- Build passes (`npm run build`)
- Type-check passes (`npm run lint / tsc --noEmit`)
- Test suite passes (`npm test`)

This is a quality gate before implementing new adapters. Mistakes in the core types or contract will cascade to every adapter.

## Acceptance Criteria

- [ ] `npm run build` passes cleanly
- [ ] `npm run lint` passes (tsc --noEmit)
- [ ] `npm test` passes with all core + Redis tests
- [ ] No regressions in existing functionality
- [ ] Core tests align with architecture spec (api-surface.md)
- [ ] Code follows project conventions (no comments in source, license headers on forked files)

## References

- docs/architecture/api-surface.md
- docs/architecture/event-targets/redis.md

## Notes

> To be filled by implementation agent

## Summary

> To be filled on completion