--- id: final-review-and-ci-validation name: "Final review: full test suite, build, and CI readiness" status: pending depends_on: [review-worker-adapter, integration-test-ws-client-server] scope: moderate risk: low impact: project level: review --- ## Description Final review before considering the package ready for use (excluding Iroh, which is deferred). Verify: 1. Full test suite passes (core + operators + Redis + WS client + WS server + Worker + integration) 2. Build produces correct dual ESM/CJS output with declarations for all entry points 3. Type-check passes for all source files 4. Package.json exports map covers all adapters 5. Each adapter has its own sub-path export configured correctly 6. Barrel re-export in `src/index.ts` includes everything 7. No test regressions 8. No extraneous files in npm package (check `npm pack` output) ## Acceptance Criteria - [ ] `npm run build` passes cleanly - [ ] `npm run lint` passes (tsc --noEmit) - [ ] `npm test` passes with full test suite - [ ] `npm run test:coverage` reports reasonable coverage (core > 80%) - [ ] All sub-path exports resolve correctly - [ ] Package can be consumed as `import { createPubSub } from '@alkdev/pubsub'` - [ ] Package can be consumed as `import { createRedisEventTarget } from '@alkdev/pubsub/event-target-redis'` - [ ] Package can be consumed as `import { createWebSocketClientEventTarget } from '@alkdev/pubsub/event-target-websocket-client'` - [ ] Package can be consumed as `import { createWebSocketServerEventTarget } from '@alkdev/pubsub/event-target-websocket-server'` - [ ] Package can be consumed as `import { createWorkerHostEventTarget } from '@alkdev/pubsub/event-target-worker'` - [ ] No runtime dependencies (Repeater is inlined) - [ ] Peer deps are optional and correct ## References - docs/architecture/build-distribution.md - All architecture docs ## Notes > To be filled by implementation agent ## Summary > To be filled on completion