fix: address review findings — CJS build (tsup), workflowCost signature, bottlenecks empty-graph test

- C1(critical): Replace tsc build with tsup for dual ESM + CJS output
- W2(warning): Change workflowCost to accept TaskGraph instead of TaskGraphInner
- S1(suggestion): Add test for bottlenecks empty-graph early return
- S2(suggestion): Document dangling-reference detection is unreachable via public API
This commit is contained in:
2026-04-27 19:56:43 +00:00
parent 55600ac95a
commit 039a6ccfe1
9 changed files with 473 additions and 43 deletions

View File

@@ -1,7 +1,7 @@
---
id: analysis/critical-path
name: Implement criticalPath and weightedCriticalPath functions
status: pending
status: completed
depends_on:
- graph/construction
- graph/queries
@@ -33,7 +33,22 @@ Implement `criticalPath` and `weightedCriticalPath` as standalone functions. `cr
## Notes
> To be filled by implementation agent
Implementation uses topological order + dynamic programming (longest path in DAG).
Both functions delegate to a shared `computeLongestPath` helper that:
1. Gets topological order (throws CircularDependencyError via `graph.topologicalOrder()`)
2. Initializes source nodes with their weight
3. Relaxes edges in topological order (DP: dist[v] = max(dist[u] + weight(v)))
4. Backtracks from the node with maximum distance to reconstruct the path
`criticalPath` uses `weightFn = () => 1` (unweighted).
`weightedCriticalPath` accepts a custom weight function on `(taskId, attrs)`.
## Summary
Implemented `criticalPath` and `weightedCriticalPath` as standalone functions using topological-order DP.
- Modified: `src/analysis/critical-path.ts` (full implementation, 161 lines)
- Modified: `test/analysis.test.ts` (20 tests covering all acceptance criteria)
- Tests: 20, all passing (462 total passing)
## Summary