glm-5.1
e592caed57
Review of all ADR documents (001-007) and peripheral architecture docs identified 3 critical, 10 warning, and 7 suggestion issues. Addressed in this commit: - W-1: Add draft qualifier to ADR-002 reference to incremental exploration - W-2: Add Alternatives Considered section to ADR-001 - W-3: Add Document Lifecycle section to README.md (draft/stable/deprecated) - W-4: Clarify includeCompleted semantics (only 'completed' status triggers exclusion) - W-5: Document file I/O runtime constraints in frontmatter.md - W-6: Add ADR reference to architecture.md redirect - W-7: Verify CVE-2025-64718 (confirmed real, improved description) - W-9: Convert workspace-absolute paths to relative/monorepo references - S-7: Add future ADR-008 note to incremental-update-exploration.md Critical issues (C-1, C-2, C-3) and remaining warnings (W-8, W-10, S-4, S-5) were addressed by a parallel agent in a prior commit. All 16 review tasks created and resolved.
911 B
911 B
id, name, status, depends_on, created, modified, scope, risk
| id | name | status | depends_on | created | modified | scope | risk |
|---|---|---|---|---|---|---|---|
| architecture/w-4-taskstatus-enum-values | Define TaskStatus enum values and completed semantics | completed | 2026-04-26T09:10:49.967999614Z | 2026-04-26T09:10:49.968000036Z | narrow | medium |
Description
Review ref: W-4 (Warning)
Files affected: docs/architecture/schemas.md, docs/architecture/cost-benefit.md
The TaskStatusEnum values are never explicitly listed — just "same pattern for TaskImpact, TaskLevel, TaskPriority, TaskStatus." Also, cost-benefit.md references includeCompleted: false but doesn't define which status value(s) constitute "completed."
Define TaskStatusEnum values explicitly. Specify which status(es) the includeCompleted option treats as "completed." This blocks implementation of both the schema and the workflowCost function.
Source: /docs/reviews/architecture-review-2026-04-26.md W-4