glm-5.3-flash
e2c255d40c
Decomposition of docs/reviews/002-post-remediation-review.md per its 5-unit remediation plan: - Unit 1 (security-critical): gw15-publish-body-cap, prj16-schema-via-call (CF-004 filed alkcall-side), fwd13-dot-segments, fwd16-missing-capability, oai11-ref-memoization - Unit 2 (timeout/terminality): ws13-idle-progress, fwd15-stream-timeout, cli01-retry-after-budget, con17-mcp-pagination, con18-wss-sweep-exit - Unit 3 (projection/docs): projection-truthfulness, mcp-batch-cap, gw16-status-drift - Unit 4 (spec-import): yaml-normalization, oai13-path-item-wildcards, import-loudness-cluster, js01-placeholder-check, fwd17-19-contract-decisions - Unit 5 (WS polish + tests): con18b-ws-polish, client-policy-wire-tests, cov-deployment-knobs, cov13-dead-code, srv11-srv12-router-ordering - review-002-bracketed-followup: tentatively planned post-bulk pass (stale-check, OQA-18 enforcement decision, CON-08/09 close() lever, cross-crate re-checks) — deliberately not serialized against the bulk Also: review-002 numbering repair (CON-14 was double-booked; MCP pagination now CON-14, from_wss monitor renumbered CON-18, missing CON-14 section added). taskgraph: 66 valid, no cycles; 24 pending (all review-002); gen-1/gen-2 parallel waves identified; workflow-cost hotspots are prj16 (12.8) and ws13 (11.1), both carrying the reviewed slicing guidance in their Notes.
2.2 KiB
id, name, status, depends_on, scope, risk, impact, level, tags
| id | name | status | depends_on | scope | risk | impact | level | tags | |||
|---|---|---|---|---|---|---|---|---|---|---|---|
| review-002-js01-placeholder-check | Fix placeholder check skipped when input_schema has no properties (JS-01) | pending | single | low | component | implementation |
|
Description
Review 002 JS-01 [major]. from_jsonschema's eager placeholder-binding
check is skipped when input_schema has no properties key:
spec_name_references_undeclared (from_jsonschema.rs:166-188) hits
if properties.is_empty() { return false; } at :173-175. So:
FromJsonSchema::new(spec_with_input_schema_type_object_no_properties,
path_template = "/widgets/{id}")
passes construction — then every call fails ({id} unbound →
INTERNAL at forward.rs:441-446; a peer-supplied id key →
INVALID_INPUT). The from_openapi equivalent (unbound_placeholders,
from_openapi.rs:36-57) handles the empty case correctly: with no
declared properties, any placeholder is unbound. The existing test
(from_jsonschema.rs:699-724) covers only the properties-present case.
Acceptance Criteria
- Drop the
is_emptyearly return (or returntruefor placeholders when properties are empty — same semantics as the from_openapi path) - Test:
FromJsonSchema::newwith a no-properties schema +{id}template fails at construction with the placeholder error; a no-properties schema with a placeholder-free template still constructs fine cargo test,cargo clippy --all-targets -- -D warnings,cargo fmt --checkpass
References
- docs/reviews/002-post-remediation-review.md (Part E', cluster item JS-01; Test-gap 11)
- src/adapters/from_jsonschema.rs:166-188 (the early return), :77-93 (the construction-time validation), :699-724 (the present-props test)
- src/adapters/from_openapi.rs:36-57 (the correct reference implementation)
- docs/architecture/decisions/066-from-jsonschema-as-http-adapter.md
Notes
One-line fix + one test. Explicitly approved to fold into any commit that is already touching from_jsonschema.rs (e.g. the wire-tests task) if a session prefers — but if touched standalone, keep it its own commit per the small-units convention.