glm-5.3-flash
12b35e2c5f
21 review-001 tasks across server/adapters/client/gateway/websocket/infra, chunked from the 7-unit remediation plan in docs/reviews/001-initial-implementation-review.md. - Scope split by mechanism, not one-per-finding: 15 tasks in generation 1 (parallelizable), 6 sequenced after their file-sharing precursors - Deliberately deferred until dependent fixes land: projection/doc fidelity partial (Unit 6 beyond dependency hygiene), coverage backfills (COV-01..07 via in-task acceptance for forward.rs), and per-finding minors (OAI-06/07, HY-02/04/06/10/11, CON-08) - Cross-crate WS-12 (alkcall demux 4 GiB discard alloc) noted for filing in alkcall, not here taskgraph: validate clean, no cycles, 6 generations
50 lines
1.9 KiB
Markdown
50 lines
1.9 KiB
Markdown
---
|
|
id: review-001-ws-data-channel-decision
|
|
name: Reconcile ADR-067 browser data channels with the v1 implementation (WS-03, planning)
|
|
status: pending
|
|
depends_on: []
|
|
scope: narrow
|
|
risk: low
|
|
impact: project
|
|
level: planning
|
|
tags: [websocket, review-001, planning]
|
|
---
|
|
|
|
## Description
|
|
|
|
Review 001 finding WS-03: ADR-067 (websocket.md §"Data channels for
|
|
browsers") promises browser-opened data channels and ADR-048 promises bidirectionality
|
|
via the connection-local overlay, but the implementation hands the base
|
|
registry to `install_channel_zero` and runs
|
|
`Dispatcher::run_loop_single_stream` (`src/websocket/upgrade.rs:40,62-98`);
|
|
no `ChannelCore`/`register_openable`/`ChannelOperations` wiring exists
|
|
anywhere (grep-verified). A browser can never open a data channel — the
|
|
capability ADR-067 says the channels design exists to provide.
|
|
|
|
This may have been a deliberate v1 cut (the WS tasks scoped channel-0
|
|
dispatch only), but the spec promise and the implementation have not been
|
|
reconciled in writing. This is a **decision task**, not an implementation
|
|
task: either (a) wire the data-channel path, or (b) file the OQ / amend
|
|
ADR-067 (+ ADR-048's overlay contract) to defer with a rationale.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] Decision made and recorded (implementation task + ADR/OQ update, or ADR-067 amendment)
|
|
- [ ] If v1-cut: ADR-067 and ADR-048 carry the reconciliation note; the gap is not silently silent
|
|
- [ ] If in-scope: a follow-up task file exists with scoped acceptance criteria (incl. a browser-opened-channel test)
|
|
|
|
## References
|
|
|
|
- docs/reviews/001-initial-implementation-review.md (Part B, WS-03)
|
|
- docs/architecture/decisions/067-websocket-carries-channels.md
|
|
- docs/architecture/decisions/048-websocket-native-session-not-gateway.md
|
|
|
|
## Notes
|
|
|
|
> Agent fills during implementation. Deliberately sequenced as
|
|
> planning so the WS-01/02 robustness work is not blocked on a design
|
|
> discussion.
|
|
|
|
## Summary
|
|
|
|
> Filled on completion. |