glm-5.3-flash
e2c255d40c
Decomposition of docs/reviews/002-post-remediation-review.md per its 5-unit remediation plan: - Unit 1 (security-critical): gw15-publish-body-cap, prj16-schema-via-call (CF-004 filed alkcall-side), fwd13-dot-segments, fwd16-missing-capability, oai11-ref-memoization - Unit 2 (timeout/terminality): ws13-idle-progress, fwd15-stream-timeout, cli01-retry-after-budget, con17-mcp-pagination, con18-wss-sweep-exit - Unit 3 (projection/docs): projection-truthfulness, mcp-batch-cap, gw16-status-drift - Unit 4 (spec-import): yaml-normalization, oai13-path-item-wildcards, import-loudness-cluster, js01-placeholder-check, fwd17-19-contract-decisions - Unit 5 (WS polish + tests): con18b-ws-polish, client-policy-wire-tests, cov-deployment-knobs, cov13-dead-code, srv11-srv12-router-ordering - review-002-bracketed-followup: tentatively planned post-bulk pass (stale-check, OQA-18 enforcement decision, CON-08/09 close() lever, cross-crate re-checks) — deliberately not serialized against the bulk Also: review-002 numbering repair (CON-14 was double-booked; MCP pagination now CON-14, from_wss monitor renumbered CON-18, missing CON-14 section added). taskgraph: 66 valid, no cycles; 24 pending (all review-002); gen-1/gen-2 parallel waves identified; workflow-cost hotspots are prj16 (12.8) and ws13 (11.1), both carrying the reviewed slicing guidance in their Notes.
69 lines
3.1 KiB
Markdown
69 lines
3.1 KiB
Markdown
---
|
|
id: review-002-yaml-normalization
|
|
name: YAML input normalization — duplicates, .inf, merge keys, non-string keys (OAI-12)
|
|
status: pending
|
|
depends_on: []
|
|
scope: narrow
|
|
risk: medium
|
|
impact: component
|
|
level: implementation
|
|
tags: [adapters, review-002, from-openapi, openapi-spec]
|
|
---
|
|
|
|
## Description
|
|
|
|
Review 002 OAI-12 [major]. `OpenAPISpec::from_yaml`
|
|
(`openapi_spec.rs:153-158`) is a single `yaml_serde::from_str::<Value>`
|
|
with zero post-parse normalization; three verified corruptions flow
|
|
through unimpeded (empirically confirmed against yaml_serde 0.10.7):
|
|
|
|
1. **Duplicate keys silently last-win** on the Value path
|
|
(`visit_map → values.insert`) while the JSON path *errors* on the
|
|
same document — the two input formats disagree, YAML's failure
|
|
mode is silent.
|
|
2. **`.inf`/`.nan` numbers become `Value::Null`** through
|
|
`Number::from_f64(∞) → None` — a declared constraint (`maximum:
|
|
.inf` is unusual, but any float inf) silently vanishes from the
|
|
advertised schema.
|
|
3. **Merge keys (`<<: *anchor`) are not applied** (yaml_serde's
|
|
`apply_merge()` is opt-in and unused) — `<<` survives as a literal
|
|
property name in the resolved/advertised schema.
|
|
|
|
Non-string keys (`200:` response codes as numbers etc.) were checked —
|
|
plain statuses survive via string round-trips — but numeric inference
|
|
into any string-matched field is a live hazard (e.g. `style: 1`).
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] A post-parse normalization pass on the YAML path (before
|
|
`from_value`): reject duplicate keys (loud, naming the path or
|
|
at least the document context), reject `.inf/.nan`-derived
|
|
nulls-from-floats (either reject or reject-with-context), and
|
|
decide merge keys: either invoke `apply_merge()` (matching YAML
|
|
1.1 user expectations; ADR-051 declares YAML 1.2 via yaml_serde —
|
|
verify which the crate claims) or reject `<<` keys loudly
|
|
- [ ] Non-string keys: reject or coerce-with-loudness (decide; JSON
|
|
path parity is the goal — the same document should mean the same
|
|
thing through both entry points or the difference must be loud)
|
|
- [ ] Tests at the `from_yaml` seam (not the parser): duplicate keys →
|
|
error; `.inf` → loud error (not silent null); merge key applied
|
|
or rejected; quoted-always spec (`"200":`) unchanged
|
|
- [ ] A doc note on the YAML/JSON parity contract (ADR-051 section or
|
|
the module doc)
|
|
- [ ] `cargo test`, `cargo clippy --all-targets -- -D warnings`,
|
|
`cargo fmt --check` pass
|
|
|
|
## References
|
|
|
|
- docs/reviews/002-post-remediation-review.md (Part E', OAI-12; Test-gap 9)
|
|
- src/adapters/openapi_spec.rs:153-158 (the seam), from_openapi.rs (the consumers)
|
|
- docs/architecture/decisions/051-yaml-input-for-from-openapi.md
|
|
- tasks/adapters/review-001-openapi-import-integrity.md (the import-integrity context)
|
|
|
|
## Notes
|
|
|
|
Keep the walk cheap (one pass, no allocation beyond error messages).
|
|
The alias-bomb/depth bounds are dependency-provided and verified
|
|
working (review 002 re-verified) — do not re-implement them; the task
|
|
is about *semantic* normalization, not resource limits. ADR-051 is the
|
|
decision record to update if the merge-key stance changes behavior. |