glm-5.1
84f16d66e7
Add 15 new tasks under tasks/architecture/ for Phase 0b (spec writing) and Phase 0c (review): Phase 0b — New specs (6): - spec-configuration: promote from research, cleanup, align with ADRs - spec-identity: carry from auth.md + services.md, canonical Identity - spec-secret-service: from research/services.md SecretProtocol - spec-storage: from research/storage.md, contract-level - spec-flowgraph: from research/flow.md, pure computation crate - spec-interface: new Layer 2 spec (highest risk new spec) - spec-services: irpc service layer + OperationEnv (broadest scope) Phase 0b — Spec updates (6): - spec-update-overview: add crate structure, Layer 3, services - spec-update-auth: IdentityProvider vs AuthService relationship - spec-update-call-protocol: OperationEnv dispatch paths - spec-update-server: DynamicConfig, ForwardingPolicy, IdentityProvider - spec-update-napi: reload API, call protocol references - spec-update-open-questions: resolve OQs per ADR decisions Phase 0b — Assembly (1): - spec-update-readme: add new docs and ADRs to tables Phase 0c — Review (1): - review-spec-foundation: validate consistency checklist Generation structure (6 total): Gen 1: 6 independent ADRs (parallel) Gen 2: adr-027, adr-028 (depend on adr-029) Gen 3: adr-033 + 6 spec docs + open-questions update (parallel) Gen 4: adr review + interface/services specs + 4 spec updates Gen 5: call-protocol update + readme update Gen 6: spec review
58 lines
2.6 KiB
Markdown
58 lines
2.6 KiB
Markdown
---
|
|
id: architecture/review-spec-foundation
|
|
name: Review Phase 0 specs — validate consistency, completeness, and ADR alignment
|
|
status: pending
|
|
depends_on:
|
|
- architecture/spec-configuration
|
|
- architecture/spec-identity
|
|
- architecture/spec-secret-service
|
|
- architecture/spec-storage
|
|
- architecture/spec-flowgraph
|
|
- architecture/spec-interface
|
|
- architecture/spec-services
|
|
- architecture/spec-update-overview
|
|
- architecture/spec-update-auth
|
|
- architecture/spec-update-call-protocol
|
|
- architecture/spec-update-server
|
|
- architecture/spec-update-napi
|
|
- architecture/spec-update-readme
|
|
- architecture/spec-update-open-questions
|
|
scope: broad
|
|
risk: low
|
|
impact: project
|
|
level: review
|
|
---
|
|
|
|
## Description
|
|
|
|
Review all Phase 0 spec documents after they're written. This is the Phase 0 review checklist from the integration plan, applied against the actual deliverables.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] **No inline decision rationale** — all "why" decisions are in ADRs, specs reference ADR numbers
|
|
- [ ] **No inline open questions** — all OQs are in open-questions.md, specs reference OQ numbers
|
|
- [ ] **Terminology is consistent** — head/worker everywhere (no hub/spoke in specs, ADRs retain historical language)
|
|
- [ ] **Layer boundaries are clear** — every component belongs to exactly one layer (Transport, Interface, Protocol)
|
|
- [ ] **Crate dependencies are acyclic** — core doesn't depend on secret, storage, or flowgraph per ADR-027
|
|
- [ ] **Every spec has YAML frontmatter** with status and last_updated
|
|
- [ ] **Identity is consistently defined** — Identity struct is `{id, scopes, resources}` everywhere (identity.md is canonical, auth.md references it)
|
|
- [ ] **OperationEnv is consistently described** — three dispatch paths match across services.md, call-protocol.md, and identity.md
|
|
- [ ] **irpc positioning is consistent** — always described as one dispatch backend for OperationEnv, never as a replacement for the call protocol
|
|
- [ ] **Interface trait is consistent** — SshInterface and RawFramingInterface match across interface.md and server.md
|
|
- [ ] **ForwardingPolicy is consistently placed** — in DynamicConfig, checked before proxy spawn, reference in server.md and configuration.md
|
|
- [ ] **README.md and ADR table** include all new documents and ADRs
|
|
- [ ] **No broken links** between doc references
|
|
- [ ] **All specs follow the format**: What, Why, Architecture, Constraints, Open Questions, Design Decisions
|
|
|
|
## References
|
|
|
|
- docs/research/integration-plan.md — Phase 0: Review Checklist
|
|
- docs/architecture/ — all architecture docs
|
|
|
|
## Notes
|
|
|
|
> To be filled by implementation agent
|
|
|
|
## Summary
|
|
|
|
> To be filled on completion |