glm-5.3-flash
49743c690e
docs/plans/implementation.md records the wave structure (core -> substrate fork || pg engine -> sqlite engine -> contract suite -> release), the decided points (contract-suite layout = option (a), engine-tests vs equivalence-suite split, no CI, mem-engine/fuzzing deferrals surfaced), and the review-gate rhythm. Wave 1 (foundations): workspace scaffold, core errors/validation, value types, trait surface, contract-suite scaffold (+ADR-022), review gate. Wave 2 (substrate fork): fork scaffold/provenance, connection+watcher port, queue-op re-derivation on contract v1, provenance/floor close, review gate.
59 lines
2.2 KiB
Markdown
59 lines
2.2 KiB
Markdown
---
|
|
id: fork-provenance-and-floor
|
|
name: Fork provenance register completion + inherited-test floor green
|
|
status: pending
|
|
depends_on: [fork-port-connection-watcher, fork-rederive-queue-ops]
|
|
scope: narrow
|
|
risk: low
|
|
impact: component
|
|
level: implementation
|
|
tags: [wave-2, substrate]
|
|
---
|
|
|
|
## Description
|
|
|
|
Close out the fork's bookkeeping and verify the test floor end-to-end
|
|
(ADR-018's adoption discipline; ADR-011's tests clause):
|
|
|
|
- **`PROVENANCE.md` delta register**: entries for every delta the port
|
|
actually made, category-tagged per ADR-018's categories — the three
|
|
watcher deltas (W-1, W-2, dead-man's switch), the table-family
|
|
rename, the bootstrap re-keying, the drops (recorded as
|
|
not-ported), the re-derivation (new code, contract-derived names),
|
|
and any mechanical adaptations the port surfaced that the plan
|
|
didn't anticipate. Each entry: what, why, the decision citation.
|
|
- **License/provenance cross-check**: the notice matches the actual
|
|
ported content; the register's revision citation (`f4e53c6`) matches
|
|
what was actually diffed.
|
|
- **Test floor**: run the full engine-crate test suite (inherited +
|
|
contract-property) as one gate; fix or explicitly record any
|
|
inherited test that the deltas legitimately changed (e.g. the
|
|
dead-man's-switch panic test becomes a watcher-fatal-death test).
|
|
- **Lineage-diff sanity pass**: produce (locally, not committed) the
|
|
diff of the substrate subtree vs. the honker-core sources at
|
|
`f4e53c6` and skim it for accidental divergence — anything not
|
|
covered by a register entry is either fixed or registered. This is
|
|
the wave-2 review's primary input.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] `PROVENANCE.md` register complete: every delta categorized and
|
|
cited; no unregistered divergence from the lineage
|
|
- [ ] License notice accurate; revision citation verified
|
|
- [ ] Full substrate test floor green in one run; changed inherited
|
|
tests documented in the register
|
|
- [ ] Lineage diff skimmed; findings recorded
|
|
|
|
## References
|
|
|
|
- docs/architecture/decisions/018-provenance-register-and-cherry-picks.md
|
|
- docs/architecture/decisions/011-sqlite-substrate-fork.md (tests clause)
|
|
- docs/research/quality-read-honker-core.md §6
|
|
|
|
## Notes
|
|
|
|
> To be filled by implementation agent
|
|
|
|
## Summary
|
|
|
|
> To be filled on completion |