50 lines
1.6 KiB
Markdown
50 lines
1.6 KiB
Markdown
---
|
|
id: normalize-tokio-dev-deps
|
|
name: Normalize the engines' dev-dep tokio feature sets (review 004 item 16)
|
|
status: pending
|
|
depends_on: []
|
|
scope: single
|
|
risk: trivial
|
|
impact: isolated
|
|
level: implementation
|
|
tags: [review-004-fixes, hygiene, metadata]
|
|
---
|
|
|
|
## Description
|
|
|
|
The cosmetic metadata asymmetry from
|
|
`docs/reviews/004-pre-release-general-review.md` §"Findings recorded,
|
|
not fixed" item 16: the three engines' dev-dep tokio features disagree
|
|
— sqlite `rt-multi-thread+macros+time`, pg `test-util`, mem
|
|
`rt+macros`. Harmless (the contract suite carries the test runtime)
|
|
but an easy-to-trip asymmetry when copying test code between engines.
|
|
|
|
Normalize to one uniform dev-dep feature set across the three engines.
|
|
Pick the union that keeps every engine's own tests green (likely
|
|
`rt-multi-thread + macros + time + test-util` — verify per engine;
|
|
feature unification means the workspace build is unaffected either
|
|
way). Dev-deps only: no published-surface change, no runtime-dep
|
|
change.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] The three engines' `[dev-dependencies]` tokio feature sets are
|
|
identical
|
|
- [ ] Each engine's own test target green (`cargo test -p` per engine;
|
|
the pg lib target's server-less SKIP posture is fine)
|
|
- [ ] Workspace gates green (build, clippy `-D warnings`, fmt)
|
|
|
|
## References
|
|
|
|
- docs/reviews/004-pre-release-general-review.md §"Findings recorded,
|
|
not fixed" item 16 (the finding)
|
|
- alkstore-sqlite/Cargo.toml:28, alkstore-postgres/Cargo.toml:22,
|
|
alkstore-mem/Cargo.toml:19 (the three differing sets)
|
|
|
|
## Notes
|
|
|
|
> To be filled by implementation agent
|
|
|
|
## Summary
|
|
|
|
> To be filled on completion |