alkstore/tasks/review-004-fixes.md

id, name, status, depends_on, scope, risk, impact, level, tags

id	name	status	depends_on	scope	risk	impact	level	tags
review-004-fixes	Review gate — review-004 fix batch (recorded-findings dispositions)	pending	sqlite-fix-seam-panic-safety sqlite-fix-watcher-death-subscribe sqlite-fix-listener-bridge-alignment sqlite-fix-scheduler-error-classification sqlite-substrate-safety-comments pg-fix-forwarder-hardening pg-fix-forwarder-diagnosability decide-log-facade-adoption pg-decide-stamp-arithmetic-side pg-fix-bigint-stamp-overflow pg-fix-scheduler-error-classification mem-doc-growth-outbox-notes core-pin-offset-initial-value core-fix-display-log-forging docs-pg-identifier-truncation-note normalize-tokio-dev-deps	broad	low	phase	review	review-004-fixes review-gate

Description

The fix batch's own gate (the review-wave-4-fixes pattern): review 004's sixteen recorded findings were decomposed into fifteen tasks; verify each disposition is real — code-read against the review's failure mechanism, not test-name-trust — and that the fixes didn't damage the postures review 004's inline fixes pinned.

Check, per finding (the review's §"Findings recorded, not fixed" numbering):

1. Seam panic-safety: the abandonment plumbing is real (a panic injected in a seam closure leaves the writer slot grantable and the reader pool intact — the test injects, it doesn't simulate); the design of record in Notes matches what landed.
2. Watcher death + initial-stat: post-death subscribe fails closed (not parks); the identity-unknown state survives the first successful stat; pre-death close-at-death pins green.
3. Bridge alignment: the listen bridge is std-thread shaped; the two bridges' residual difference (if any) named and justified.
4. Scheduler classification: the closed-store arm no longer reports LeadershipLost on either engine — the sqlite fix and the pg twin (pg-fix-scheduler-error-classification, surfaced at the sqlite task's implementation) both verified against the landed ADR-009 §1 arm set; the window-state/annotation record is present.
5. Substrate SAFETY comments: every flagged block carries a concrete invariant; the PROVENANCE delta entry registered (the diff-fidelity posture honored — this is the check that matters most here).
6. Forwarder hardening: the TOCTOU restructure is atomic decide-and-queue (code-read the guard/command ordering); the two hang arms bounded; the preserved postures (deadlock pitfalls, retry core, fanout guard, register-failure unregister, poison-recovery idiom) re-verified green.
7. Log facade: the decision of record exists with user sign-off; the diagnosability arms surface failures in the decided form; secret-free grep re-run.
8. BIGINT stamps: the decided guard at the decided sites; the extreme-stamped-row tests run against the live server; no re-deciding happened (or discrepancies recorded).
9. Mem doc notes: the growth/outbox pins present and anchored.
10. Offset pre-yield pin: the three-way verification evidence exists; the contract text pinned (or the divergence raised).
11. Display forging: the control-char pin; taxonomy untouched.
12. Identifier note: in the release text, dated, no-cap verdict untouched.
13. Tokio dev-deps: the three sets identical; tests green.

No regressions: review 004's inline fixes' pinned postures re-spot-checked where the batch touched them — the tick's drop-+-replenish arm, the tx-form negative seed (all three columns), the register-failure unregister, the poison-recovery idiom, the encode depth limit (127), the sleep caps, the doc corrections.

Records: review 004's recorded-findings items annotated with their dispositions/task pointers (the record reads closed); docs/plans/implementation.md gains a review-rounds entry for this batch; task files audited (all dependencies completed, Notes and Summary filled, no placeholder residue).

Gates: full battery — cargo build, cargo test --workspace (server-less), the live pg column vs the harness server (env per review 003's op note), cargo clippy --all-targets -- -D warnings, cargo fmt --check, the fuzz corpus replay, the wasm32 check, and the doc gate.

Acceptance Criteria

• Every finding's disposition verified by code-read/live run against the review's failure mechanism (the per-finding checks above)
• No regressions in the inline fixes' pinned postures
• Records landed (review-004 annotations, implementation.md review-rounds entry, task-file audit)
• All gates re-run green this session (incl. live pg column, fuzz replay, wasm32, doc gate)

References

• docs/reviews/004-pre-release-general-review.md §"Findings recorded, not fixed" (the sixteen items this gate disposes) and §"Findings fixed inline" (the postures re-spot-checked)
• tasks/review-wave-4-fixes.md (the gate pattern)
• docs/plans/implementation.md §Review rounds so far (the record to extend)

Notes

To be filled by implementation agent

Summary

To be filled on completion