66 lines
2.4 KiB
Markdown
66 lines
2.4 KiB
Markdown
---
|
|
id: normalize-tokio-dev-deps
|
|
name: Normalize the engines' dev-dep tokio feature sets (review 004 item 16)
|
|
status: completed
|
|
depends_on: []
|
|
scope: single
|
|
risk: trivial
|
|
impact: isolated
|
|
level: implementation
|
|
tags: [review-004-fixes, hygiene, metadata]
|
|
---
|
|
|
|
## Description
|
|
|
|
The cosmetic metadata asymmetry from
|
|
`docs/reviews/004-pre-release-general-review.md` §"Findings recorded,
|
|
not fixed" item 16: the three engines' dev-dep tokio features disagree
|
|
— sqlite `rt-multi-thread+macros+time`, pg `test-util`, mem
|
|
`rt+macros`. Harmless (the contract suite carries the test runtime)
|
|
but an easy-to-trip asymmetry when copying test code between engines.
|
|
|
|
Normalize to one uniform dev-dep feature set across the three engines.
|
|
Pick the union that keeps every engine's own tests green (likely
|
|
`rt-multi-thread + macros + time + test-util` — verify per engine;
|
|
feature unification means the workspace build is unaffected either
|
|
way). Dev-deps only: no published-surface change, no runtime-dep
|
|
change.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [x] The three engines' `[dev-dependencies]` tokio feature sets are
|
|
identical
|
|
- [x] Each engine's own test target green (`cargo test -p` per engine;
|
|
the pg lib target's server-less SKIP posture is fine)
|
|
- [x] Workspace gates green (build, clippy `-D warnings`, fmt)
|
|
|
|
## References
|
|
|
|
- docs/reviews/004-pre-release-general-review.md §"Findings recorded,
|
|
not fixed" item 16 (the finding)
|
|
- alkstore-sqlite/Cargo.toml:28, alkstore-postgres/Cargo.toml:22,
|
|
alkstore-mem/Cargo.toml:19 (the three differing sets)
|
|
|
|
## Notes
|
|
|
|
<!-- implementation decisions of record -->
|
|
|
|
The union picked exactly matches the task's expectation:
|
|
`rt-multi-thread + macros + time + test-util` — the pg engine's
|
|
dev-dep `test-util` coverage is preserved, no engine's tests needed
|
|
anything beyond the union, and no code change was required anywhere.
|
|
|
|
## Summary
|
|
|
|
Normalized all three engines' `[dev-dependencies]` tokio feature sets
|
|
to `["rt-multi-thread", "macros", "time", "test-util"]` (previously:
|
|
sqlite `rt-multi-thread+macros+time`, pg `test-util`, mem `rt+macros`)
|
|
— dev-dep metadata only, no published-surface or runtime-dep change.
|
|
|
|
Verified (2026-10-11): workspace `cargo build`, `cargo clippy
|
|
--all-targets -- -D warnings`, `cargo fmt --check` all clean;
|
|
`cargo test -p` green for alkstore-mem (102 unit + 26 ct),
|
|
alkstore-sqlite (203 unit + 26 ct + 1 doc), alkstore-postgres
|
|
(135 unit + 26 ct + 9 integration, full target incl. the server-less
|
|
SKIP posture).
|