deepseek-v4-pro
8ff7ba27f3
First full review of the alktty crate after Phase 5 landed. Covers coverage (cargo-llvm-cov), correctness, and code smell, with a remediation plan. - 2 Medium: TtySession never handles the negotiation-rejection error frame (M1); wait() swallows MalformedExitChunk (M2) - 6 Low: channels input ignored (L1), consumer stdout/stderr routing untested (L2), open_via_channels 0% covered (L3), mocks leak into public API (L4), cargo fmt fails (L5), pty bridge error paths untested (L6) - 6 Nit: 9 rustdoc warnings (N1), stale doc paths (N2), unsafe vs AGENTS.md §14 (N3), sleep-based timing (N4), duplicated seed helpers (N5), unverified MSRV (N6) Verification: cargo test (81), cargo test --all-features (123), clippy clean (native + wasm), wasm check clean, publish dry-run clean, llvm-cov 90.74% lines / 92.24% functions.