Pre-publish review #008: gate int_keys on canonical keys, restore no-prealloc array rule
Review #008 (docs/reviews/008-pre-publish-review.md) audits the two
post-#007 unreviewed commits (dea96f0 bench port, d4635d2 perf) before
the first crates.io publish of 0.3.0.
- F1: the int_keys integer dispatch accepted non-canonical mapping
keys ("01", "+1" parse as u64 1) — the reader dispatched disc 1
while the materializer, validation plan, and tunion rejected the
same buffer. compile_int_keys now builds the table only when every
key is canonical (v.to_string() == key); otherwise the string
fallback applies (agreement restored, perf kept for canonical
mappings). Tests: r8_non_canonical_mapping_key_disables_int_dispatch,
r8_canonical_mapping_keys_keep_int_dispatch.
- F2: d4635d2 reintroduced Vec::with_capacity(count) on both array
materializers. Bounded per array by MAX_ARRAY_ELEMENTS but nesting
compounds: probe (counting allocator) measured ~477 MB simultaneous
allocation from a ~1 KB schema + empty buffer (100-level stride-0
chain, all legal under the caps). H1's layer-1 rule restored:
Vec::new() + push. Bench unchanged (packet read 220µs vs 246µs
baseline). Test: r8_deeply_nested_stride0_array_rejects_before_bulk_prealloc.
- N3a disposition (review #007's deferred item): BastField::synthetic
(pub(crate), zero callers, #[allow(dead_code)]) deleted; the seven
source() accessors are public API and stay (semver decision —
removal needs an explicit ask); resolve_typeref_as_def's inline
struct/union/enum arms probe-verified reachable (inline struct
union variants are legal) — kept.
- CHANGELOG: 0.3.0 entry (compiled forms, breaking surface, hardening
fixes, coverage). README: ReadPlan/ValidationPlan roles, union
conventions, untrusted-schema bounds.
Verification: 569 tests green (491 lib + 17 + 34 + 15 + 12, + 2
ignored doctests), clippy -D warnings clean, cargo doc 0 warnings,
wasm32 build green, cargo publish --dry-run clean.
glm-5.3-flash
9803d3b768