glm-5.1
e592caed57
Review of all ADR documents (001-007) and peripheral architecture docs identified 3 critical, 10 warning, and 7 suggestion issues. Addressed in this commit: - W-1: Add draft qualifier to ADR-002 reference to incremental exploration - W-2: Add Alternatives Considered section to ADR-001 - W-3: Add Document Lifecycle section to README.md (draft/stable/deprecated) - W-4: Clarify includeCompleted semantics (only 'completed' status triggers exclusion) - W-5: Document file I/O runtime constraints in frontmatter.md - W-6: Add ADR reference to architecture.md redirect - W-7: Verify CVE-2025-64718 (confirmed real, improved description) - W-9: Convert workspace-absolute paths to relative/monorepo references - S-7: Add future ADR-008 note to incremental-update-exploration.md Critical issues (C-1, C-2, C-3) and remaining warnings (W-8, W-10, S-4, S-5) were addressed by a parallel agent in a prior commit. All 16 review tasks created and resolved.
23 lines
976 B
Markdown
23 lines
976 B
Markdown
---
|
|
id: architecture/s-4-error-classes-in-project-structure
|
|
name: Add DuplicateNodeError and DuplicateEdgeError to build-distribution.md error listing
|
|
status: completed
|
|
depends_on:
|
|
- architecture/c-1-construction-error-policy
|
|
created: 2026-04-26T09:11:08.034858853Z
|
|
modified: 2026-04-26T09:11:08.034859401Z
|
|
scope: narrow
|
|
risk: low
|
|
---
|
|
|
|
# Description
|
|
|
|
**Review ref**: S-4 (Suggestion)
|
|
**Files affected**: `docs/architecture/build-distribution.md`
|
|
|
|
The error directory listing in the project structure (line 54) shows `TaskgraphError, TaskNotFoundError, CircularDependencyError, InvalidInputError` but omits `DuplicateNodeError` and `DuplicateEdgeError` which are defined in `errors-validation.md`. Add the missing error classes to the comment.
|
|
|
|
Depends on C-1 (construction error policy) — if we resolve that DuplicateNodeError/DuplicateEdgeError remain as thrown errors, they must appear in this listing.
|
|
|
|
**Source**: `/docs/reviews/architecture-review-2026-04-26.md` S-4
|