glm-5.1
1306716897
19 tasks covering core testing, Redis hardening, WebSocket client/server adapters, Worker adapter, and final review gates. Iroh adapters are tracked as a deferred placeholder blocked on the @alkdev/iroh fork. Phases: core validation → Redis hardening → review gate → WebSocket adapters → review gate → Worker adapter → review gate → final validation.
45 lines
1.4 KiB
Markdown
45 lines
1.4 KiB
Markdown
---
|
|
id: review-core-and-redis
|
|
name: Review core module tests and Redis adapter
|
|
status: pending
|
|
depends_on: [core-pubsub-tests, core-operators-tests, redis-adapter-tests]
|
|
scope: narrow
|
|
risk: low
|
|
impact: phase
|
|
level: review
|
|
---
|
|
|
|
## Description
|
|
|
|
Review checkpoint before moving to new adapter implementations. Verify that:
|
|
- Core tests cover the `createPubSub` contract thoroughly (publish, subscribe, topic scoping, `__` rejection, cleanup)
|
|
- Operator tests cover all 13 operators with edge cases
|
|
- Redis adapter tests pass reliably with real Redis or mock
|
|
- Code follows architecture conventions (no unnecessary comments, MIT headers on forked files)
|
|
- Build passes (`npm run build`)
|
|
- Type-check passes (`npm run lint / tsc --noEmit`)
|
|
- Test suite passes (`npm test`)
|
|
|
|
This is a quality gate before implementing new adapters. Mistakes in the core types or contract will cascade to every adapter.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] `npm run build` passes cleanly
|
|
- [ ] `npm run lint` passes (tsc --noEmit)
|
|
- [ ] `npm test` passes with all core + Redis tests
|
|
- [ ] No regressions in existing functionality
|
|
- [ ] Core tests align with architecture spec (api-surface.md)
|
|
- [ ] Code follows project conventions (no comments in source, license headers on forked files)
|
|
|
|
## References
|
|
|
|
- docs/architecture/api-surface.md
|
|
- docs/architecture/event-targets/redis.md
|
|
|
|
## Notes
|
|
|
|
> To be filled by implementation agent
|
|
|
|
## Summary
|
|
|
|
> To be filled on completion |